From: David Marchand <david.marchand@redhat.com>
To: Chengwen Feng <fengchengwen@huawei.com>
Cc: dev <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>,
Conor Walsh <conor.walsh@intel.com>,
Kevin Laatz <kevin.laatz@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API
Date: Thu, 21 Oct 2021 15:43:04 +0200 [thread overview]
Message-ID: <CAJFAV8wiNthy3uSj+a7e2XfJTWar+T5iX7hiNs_XKF9EgMKRJQ@mail.gmail.com> (raw)
In-Reply-To: <20211021125938.52401-2-fengchengwen@huawei.com>
On Thu, Oct 21, 2021 at 3:04 PM Chengwen Feng <fengchengwen@huawei.com> wrote:
>
> This patch add check for rte_dma_info_get() API.
Fixes: 718f7804841f ("test/dma: add basic dmadev instance tests")
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Thanks for following up.
> ---
> app/test/test_dmadev.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c
> index 8b58256afc..d6d5dfc803 100644
> --- a/app/test/test_dmadev.c
> +++ b/app/test/test_dmadev.c
> @@ -746,8 +746,11 @@ test_dmadev_instance(int16_t dev_id)
> .nb_desc = TEST_RINGSIZE,
> };
> const int vchan = 0;
> + int ret;
>
> - rte_dma_info_get(dev_id, &info);
> + ret = rte_dma_info_get(dev_id, &info);
> + if (ret)
Nit: ret != 0
> + ERR_RETURN("Error with rte_dma_info_get()\n");
>
> printf("\n### Test dmadev instance %u [%s]\n",
> dev_id, info.dev_name);
> @@ -761,8 +764,8 @@ test_dmadev_instance(int16_t dev_id)
> if (rte_dma_vchan_setup(dev_id, vchan, &qconf) < 0)
> ERR_RETURN("Error with queue configuration\n");
>
> - rte_dma_info_get(dev_id, &info);
> - if (info.nb_vchans != 1)
> + ret = rte_dma_info_get(dev_id, &info);
> + if (ret || info.nb_vchans != 1)
Nit: ret != 0
> ERR_RETURN("Error, no configured queues reported on device id %u\n", dev_id);
>
> if (rte_dma_start(dev_id) != 0)
> --
> 2.33.0
>
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2021-10-21 13:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 6:59 [dpdk-dev] [PATCH 1/2] dmadev: hide devices array David Marchand
2021-10-20 6:59 ` [dpdk-dev] [PATCH 2/2] dmadev: remove symbol versioning for inline helpers David Marchand
2021-10-20 9:40 ` Bruce Richardson
2021-10-20 9:47 ` [dpdk-dev] [PATCH 1/2] dmadev: hide devices array fengchengwen
2021-10-20 9:55 ` David Marchand
2021-10-20 10:01 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 1/3] " Chengwen Feng
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API Chengwen Feng
2021-10-21 13:43 ` David Marchand [this message]
2021-10-21 14:03 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 12:59 ` [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode Chengwen Feng
2021-10-21 13:42 ` David Marchand
2021-10-21 14:04 ` Kevin Laatz
2021-10-21 14:26 ` Walsh, Conor
2021-10-21 20:20 ` David Marchand
2021-10-21 14:03 ` [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array Kevin Laatz
2021-10-26 6:04 ` Radha Mohan
2021-10-26 6:20 ` fengchengwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wiNthy3uSj+a7e2XfJTWar+T5iX7hiNs_XKF9EgMKRJQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=conor.walsh@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=kevin.laatz@intel.com \
--cc=mdr@ashroe.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).