From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94E5BA00C4; Fri, 7 Oct 2022 13:08:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6312B4284D; Fri, 7 Oct 2022 13:08:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 99054400D5 for ; Fri, 7 Oct 2022 13:08:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665140933; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nmpvP1UbHlAicWhYWjYkmD5tauaE/4Wam2Nx+6qpnAA=; b=SXdkwP61bwbex7YCef0sDnWLnyk+UGVH9M/OfI2WZRPsHlLjFVb63bLm3LAzMx2irIrWkH 24FYTFClrpdwqnjkPnSZsIcpDY3HbMOzrRDcNFq/D8UG6Ylh4slNgeJvr7t8ZxuvmpF7km ZcXpF8dVXe+m2qM0LyShEPhENplsIpw= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-303-3sqiiNgbO7CTOjOebgMxGQ-1; Fri, 07 Oct 2022 07:08:52 -0400 X-MC-Unique: 3sqiiNgbO7CTOjOebgMxGQ-1 Received: by mail-pl1-f199.google.com with SMTP id f18-20020a170902ce9200b0017f9ac4cfb5so2215171plg.22 for ; Fri, 07 Oct 2022 04:08:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nmpvP1UbHlAicWhYWjYkmD5tauaE/4Wam2Nx+6qpnAA=; b=ZFJ2rul8isXy/E3jY7DUPFSp/gUOoIHSA3/D+LZrd/PiN4T13mg+r73hf6gDxs/7Tw jspJJRnkLiwL0DBPQ28OCcUWigqwDRaoIzogMfGR2HYxZMf5XNQwk9IhNZzIh06McG0D f55P7LjKePp5Nb9L6KicHDYGV5rSbiM8rOFwiolAXt3iYs9NvTF4nzB/ycW206MgpYft ytEz50/orhuFiGUrm6uJFEhl1y5i2DKSk2xEE5zY6cO90BaQ9r2OvlRIKWLzm8wIWvBd NAI9H/QVIUrM6y/9OIzIPh+FRIR8B5YhjtVgjENzRlDblAn5cYCozDS50AtogSGhc6Fk Gd/Q== X-Gm-Message-State: ACrzQf24iCPlxUFC4uRLt21pP/UxIq2DFtknal5hCg6MFe0rrg2dK6cW EqY7zU2S9bnlFG/laKx571X9yqApdgv2sElTGjTFy987v1+leEvKZjmoJnnb6Io/i4pQT7kQE0P vfh9usVa4w52KYs5nw7Q= X-Received: by 2002:a63:2a97:0:b0:457:23e9:586d with SMTP id q145-20020a632a97000000b0045723e9586dmr4075372pgq.190.1665140931036; Fri, 07 Oct 2022 04:08:51 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42RXKrQNOlV2+fz7EUaG+4HxRdhLIA4wf1qELhAXm/CfUyiIRMfQpt4XiifXyPbdjBGSNGBZmM7yxcUGoLRyg= X-Received: by 2002:a63:2a97:0:b0:457:23e9:586d with SMTP id q145-20020a632a97000000b0045723e9586dmr4075350pgq.190.1665140930743; Fri, 07 Oct 2022 04:08:50 -0700 (PDT) MIME-Version: 1.0 References: <20221005143451.157613-1-bruce.richardson@intel.com> In-Reply-To: <20221005143451.157613-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 7 Oct 2022 13:08:38 +0200 Message-ID: Subject: Re: [PATCH 1/2] kni: flag deprecated status at build time To: Bruce Richardson Cc: dev@dpdk.org, techboard@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, On Wed, Oct 5, 2022 at 4:35 PM Bruce Richardson wrote: > diff --git a/drivers/net/kni/meson.build b/drivers/net/kni/meson.build > index 2acc989694..2deb2c4166 100644 > --- a/drivers/net/kni/meson.build > +++ b/drivers/net/kni/meson.build > @@ -6,6 +6,11 @@ if is_windows > reason = 'not supported on Windows' > subdir_done() > endif > +if not dpdk_conf.has('kni') I think it should be: if not dpdk_conf.has('RTE_LIB_KNI') And to reply to your recent comment, I don't think we need to update this driver documentation. The meson log is enough to figure out why net/kni is disabled. > + build = false > + reason = 'needs deprecated lib, "kni"' > + subdir_done() > +endif > > deps += 'kni' > sources = files('rte_eth_kni.c') -- David Marchand