From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D8BA45AAF; Fri, 4 Oct 2024 16:03:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A758410FC; Fri, 4 Oct 2024 16:03:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 06F2040E34 for ; Fri, 4 Oct 2024 16:03:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728050610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PoA7ubg9XtQjOYrntD6F5gzkbSKGeiQ+giOVa0rBiEg=; b=RhDlo4vJun8UnlRPEMYZ6W/amFAKwlWqX9G0obDfSSa0qzgdim1FFxVg+2pUsDn0+4loEV kxNk9rHqmUW2Jg3Z4X5MZU8XlQKTOuvmsWdLfloKA76Eo8cemxc/a1yF9vewgx6nq24nRp M24HDEWd9KqI2Itr8XL1b2lgWra6RSw= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-YM6SAWtNOHuDpUWlFVix9A-1; Fri, 04 Oct 2024 10:03:29 -0400 X-MC-Unique: YM6SAWtNOHuDpUWlFVix9A-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-53996a1e52bso2111864e87.0 for ; Fri, 04 Oct 2024 07:03:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728050608; x=1728655408; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PoA7ubg9XtQjOYrntD6F5gzkbSKGeiQ+giOVa0rBiEg=; b=tEs5y5X0KcDJ0msiRDV9bQcgIfn5jLUh2DY1KKvRH0RCxBGaOLyr4wBGrZclpZvq32 +PWOytB+vVDvRHmj49QV28QcumZmzoHr+eXO3lSQHEbaKt5E+IY0zO2xVDg8SPN5qK7A 1Q6HzEQKtxc/7XpuxLc/yDOryr+XEZ0SPHtg183n4fJd3iD2EeZ+rUXGSDriDGTwghYP aglzJ8dAOkAIv2ooYrIs0gKdYMQupycdo8f7Sa1BUS4x/qAgOQtWnK7jAG3uRulTm7o2 BFmJS5T6D4F/gAsyzVQUaloq3oib+CNfdFFmDPpVPD8mgKP+BVyvmQOvRDmLotU8l6wp NNmA== X-Gm-Message-State: AOJu0Yz2yhVqvj0twiMrhD5jY/5fuMqyQRVyD1MFSgIBHc+H82d0PZ8c nnx4WkhStBZ2pRhVX55iFUbmoJN+eOlvDUD0wxUnE6ZUv7d6nR6yrmb+IlDPrUvWkLnhsIP/L5Y qbsc2S7yYHJj5+02yX5IGHJm5BaFM0MB84X+BIdVvd7gZJ/3eNGoJHrVrTBF8yMQJYOInA9H+a8 t6+702TnjNFvKUvmI= X-Received: by 2002:a05:6512:3094:b0:539:96a1:e4cf with SMTP id 2adb3069b0e04-539ab88c39cmr1818789e87.32.1728050607706; Fri, 04 Oct 2024 07:03:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFa7WtPLBOWUkmpj875cVKr32D4ryE27MUroRyVBpwCJpevSOFZdDmnIMzLfgNDV7+dKf2SsJRuT4tvKWlguB4= X-Received: by 2002:a05:6512:3094:b0:539:96a1:e4cf with SMTP id 2adb3069b0e04-539ab88c39cmr1818750e87.32.1728050607183; Fri, 04 Oct 2024 07:03:27 -0700 (PDT) MIME-Version: 1.0 References: <20240930121525.3452847-1-hemant.agrawal@nxp.com> <20241001110325.4173762-1-hemant.agrawal@nxp.com> In-Reply-To: <20241001110325.4173762-1-hemant.agrawal@nxp.com> From: David Marchand Date: Fri, 4 Oct 2024 16:03:15 +0200 Message-ID: Subject: Re: [PATCH v5 00/18] NXP DPAA ETH driver enhancement and fixes To: Hemant Agrawal Cc: dev@dpdk.org, ferruh.yigit@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 1, 2024 at 1:03=E2=80=AFPM Hemant Agrawal wrote: > > v5: fix individual patch compilation and checkpatch warning > v4: fix clang compilation issues > v3: addressed Ferruh's comments > - dropped Tx rate limit API patch > - added one small bug fix > - fixed removal/add of fman_offline type > > v2: address review comments > - improve commit message > - add documentarion for new functions > - make IEEE1588 config runtime > > This series adds several enhancement to the NXP DPAA Ethernet driver. > > Primarily: > 1. timestamp and IEEE 1588 support > 2. OH and ONIC based virtual port config in DPAA > 3. frame display and debugging infra > > > Gagandeep Singh (3): > bus/dpaa: fix PFDRs leaks due to FQRNIs > net/dpaa: support mempool debug > net/dpaa: improve the dpaa port cleanup > > Hemant Agrawal (5): > bus/dpaa: fix VSP for 1G fm1-mac9 and 10 > bus/dpaa: fix the fman details status > bus/dpaa: add port buffer manager stats > net/dpaa: implement detailed packet parsing > net/dpaa: enhance DPAA frame display > > Jun Yang (2): > net/dpaa: share MAC FMC scheme and CC parse > net/dpaa: improve dpaa errata A010022 handling > > Rohit Raj (3): > net/dpaa: fix typecasting ch ID to u32 > bus/dpaa: add OH port mode for dpaa eth > bus/dpaa: add ONIC port mode for the DPAA eth > > Vanshika Shukla (5): > net/dpaa: support Tx confirmation to enable PTP > net/dpaa: add support to separate Tx conf queues > net/dpaa: support Rx/Tx timestamp read > net/dpaa: support IEEE 1588 PTP > net/dpaa: fix reallocate_mbuf handling > > doc/guides/nics/dpaa.rst | 64 ++- > doc/guides/nics/features/dpaa.ini | 2 + > drivers/bus/dpaa/base/fman/fman.c | 583 +++++++++++++++++++--- > drivers/bus/dpaa/base/fman/fman_hw.c | 102 +++- > drivers/bus/dpaa/base/fman/netcfg_layer.c | 19 +- > drivers/bus/dpaa/base/qbman/qman.c | 46 +- > drivers/bus/dpaa/dpaa_bus.c | 37 +- > drivers/bus/dpaa/include/fman.h | 112 ++++- > drivers/bus/dpaa/include/fsl_fman.h | 12 + > drivers/bus/dpaa/include/fsl_qman.h | 4 +- > drivers/bus/dpaa/version.map | 4 + > drivers/net/dpaa/dpaa_ethdev.c | 428 +++++++++++++--- > drivers/net/dpaa/dpaa_ethdev.h | 68 ++- > drivers/net/dpaa/dpaa_flow.c | 66 +-- > drivers/net/dpaa/dpaa_fmc.c | 421 ++++++++++------ > drivers/net/dpaa/dpaa_ptp.c | 118 +++++ > drivers/net/dpaa/dpaa_rxtx.c | 378 ++++++++++++-- > drivers/net/dpaa/dpaa_rxtx.h | 152 +++--- > drivers/net/dpaa/meson.build | 1 + > 19 files changed, 2105 insertions(+), 512 deletions(-) > create mode 100644 drivers/net/dpaa/dpaa_ptp.c Please Hemant, I see this series reintroduces \n issue in drivers/bus/dpaa/base/fman (use of macro FMAN_ERR). Can you send fixes against next-net ? Thanks. --=20 David Marchand