From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DBAEA04DD; Fri, 20 Nov 2020 10:20:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9058DDED; Fri, 20 Nov 2020 10:20:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 8CD8F3B5 for ; Fri, 20 Nov 2020 10:20:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605864006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kxQdv1OGfzxndHi1ncKF+7ia52rqnBIHhnrupxcW0a8=; b=NQyZwNnJvEKVhbEZSJRk1hvEyNYZuQvRtoVsg+YA8oFr6HmV6XAa8txyrUlRJZdrV/8ZF7 ZiTqio7hJJKoU48WkpvRrgFHmqFg+9PUVDX9/I68G/ihZIruMfpjuMJz+pg0XEOwSep+NU 9zbKhydjphreCMqWiHLJsZxdD/Uhj7E= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-5Y-dLUhDOae2xNvcQhGPaQ-1; Fri, 20 Nov 2020 04:20:03 -0500 X-MC-Unique: 5Y-dLUhDOae2xNvcQhGPaQ-1 Received: by mail-vk1-f198.google.com with SMTP id y16so3901378vke.0 for ; Fri, 20 Nov 2020 01:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxQdv1OGfzxndHi1ncKF+7ia52rqnBIHhnrupxcW0a8=; b=NXeAqUKJLY1Vn9zV0cEY7JSsdp70/U4wkQE7rRUgCURXG+m0zPktcom0gTTAcf3zdi STRkn3kYBztBwSPd0AoDS+jejzSkMVU5xY65HAJZeEU3p5jbOttJpNavCMNZWUDQPhvC PzosEWtb9pFor9RuvyD+ITmnSlDnPqYgC9uCiHCVz2uhKdRrrn5dUcEJlTcz4wpZmjXk j5ThNUl0jRqh7Vcn+NV6fyWuCmfSwdL3PNSsUniAZQweBcjtIjIM/qkPTQhA9gNeP+Ue 2ltG0krjCOsVsQm3SBTNu54DYDW5JYDzEq5YVy26szUzuu697/3xcsXZ764vhcDkuCR8 9rcA== X-Gm-Message-State: AOAM5333AgzqyhWd3jo5ed7G/sOEPyk2+R5Ax3jBF315dPACipON9eKd QSk/YfU4du8j6O5sw//8sIjZSU1ciGohlk0ZkBkTjr6jYGtEaKzthlkvrwpZS/qGjB2gMo+i3pX WXde68sUxN1PSPgYtACE= X-Received: by 2002:a1f:d205:: with SMTP id j5mr11921984vkg.9.1605864002707; Fri, 20 Nov 2020 01:20:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1ahphyqBljaS4+e1uzTKQA8iu6kxUiQk5/MgoQk4LXWwgvVWDSW3wwQlicsKhSqjpSwWqZAmY782+ihTeFTE= X-Received: by 2002:a1f:d205:: with SMTP id j5mr11921980vkg.9.1605864002531; Fri, 20 Nov 2020 01:20:02 -0800 (PST) MIME-Version: 1.0 References: <027ca076ea8e2be6bd76987da23298ffd5db550f.1605782511.git.anatoly.burakov@intel.com> In-Reply-To: <027ca076ea8e2be6bd76987da23298ffd5db550f.1605782511.git.anatoly.burakov@intel.com> From: David Marchand Date: Fri, 20 Nov 2020 10:19:51 +0100 Message-ID: To: Anatoly Burakov Cc: dev , Thomas Monjalon , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] doc: allow sphinx build with no DPDK version X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 19, 2020 at 11:42 AM Anatoly Burakov wrote: > > Currently, when building sphinx documentation, the build will only > succeed if being run from the build system, because the conf.py script > expects DPDK_VERSION environment variable to be set, and crashes if it > is not. > > However, there are certain external tools (such as sphinx documentation > preview extensions for certain IDE's) that use live preview and thus > rely on running their own sphinx commands. In these cases, it is useful > to permit building sphinx documentation without specifying the > DPDK_VERSION environment variable. The version string is the only thing > preventing manual sphinx build commands from working. > > Fix the conf.py to use "None" as a version string in cases when > DPDK_VERSION environment variable is not set. > > Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson So now, no excuse for documentation patches that fail to build :-). Applied, thanks. -- David Marchand