From: David Marchand <david.marchand@redhat.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, viacheslavo@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH] net/mlx5: avoid setting kernel MTU if not needed
Date: Wed, 4 Jun 2025 11:52:44 +0200 [thread overview]
Message-ID: <CAJFAV8wkOfzMStekpOMbEsPD3PjM7+JAxYy4R1B=cH4oGH1QOg@mail.gmail.com> (raw)
In-Reply-To: <20250603175334.x4iknunhjbrsceat@ds-vm-debian.local>
On Tue, Jun 3, 2025 at 7:54 PM Dariusz Sosnowski <dsosnowski@nvidia.com> wrote:
> > Atm, I don't see the need for keeping such a cached mtu value in priv.
> > There is only one user of the value, and it is for configuration
> > operation that can do a query to the kernel.
>
> I agree. It's not really needed, especially since the same value is also
> stored in dev->data->mtu, so the kernel query can easily be replaced
> with reading dev->data->mtu.
Good point, which makes this priv->mtu even less useful.
Thanks Dariusz.
--
David Marchand
prev parent reply other threads:[~2025-06-04 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-28 9:36 Maxime Coquelin
2025-05-28 12:12 ` David Marchand
2025-06-03 17:53 ` Dariusz Sosnowski
2025-06-03 17:56 ` Dariusz Sosnowski
2025-06-04 7:49 ` Dariusz Sosnowski
2025-06-04 9:52 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wkOfzMStekpOMbEsPD3PjM7+JAxYy4R1B=cH4oGH1QOg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).