DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Srujana Challa <schalla@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	 "chenbox@nvidia.com" <chenbox@nvidia.com>,
	Jerin Jacob <jerinj@marvell.com>,
	 Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>,
	Vamsi Krishna Attunuru <vattunuru@marvell.com>
Subject: Re: [EXTERNAL] Re: [PATCH v2] net/virtio_user: fix issue with converting cq descriptor IOVA address to VA
Date: Fri, 12 Jul 2024 13:30:00 +0200	[thread overview]
Message-ID: <CAJFAV8wkU5qspP3Mp5S-1k9kBcLVQhVugzvFX1x3Cx9kdOrjyQ@mail.gmail.com> (raw)
In-Reply-To: <DS0PR18MB53681B2533173ADB9258050DA0A52@DS0PR18MB5368.namprd18.prod.outlook.com>

On Thu, Jul 11, 2024 at 7:46 PM Srujana Challa <schalla@marvell.com> wrote:
> > -virtio_user_iova2virt(rte_iova_t iova)
> > +virtio_user_iova2virt(struct virtio_user_dev *dev, rte_iova_t iova)
> >
> > >  {
> > > -       if (rte_eal_iova_mode() == RTE_IOVA_VA)
> > > -               return (void *)(uintptr_t)iova;
> > > -       else
> > > +       if (rte_eal_iova_mode() == RTE_IOVA_PA && !use_va)
> > >                 return rte_mem_iova2virt(iova);
> > > +       else
> > > +               return (void *)(uintptr_t)iova;
> >
> > Why do we need to invert this test?
> Made this change to ensure that rte_mem_iova2virt() is not called when the IOVA mode is RTE_IOVA_DC
> by any chance.

Just repeating what I replied in the other thread as I see it was
suggested by Jerin.
It is not possible iova mode == RTE_IOVA_DC.


-- 
David Marchand


  parent reply	other threads:[~2024-07-12 11:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 12:44 Srujana Challa
2024-07-11 15:02 ` David Marchand
2024-07-11 17:46   ` [EXTERNAL] " Srujana Challa
2024-07-12  7:57     ` David Marchand
2024-07-12 11:30     ` David Marchand [this message]
2024-07-12 11:51       ` Srujana Challa
2024-07-12 12:36 ` [PATCH v3] net/virtio_user: fix cq descriptor conversion with non vDPA backend Srujana Challa
2024-07-12 14:24   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wkU5qspP3Mp5S-1k9kBcLVQhVugzvFX1x3Cx9kdOrjyQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=ndabilpuram@marvell.com \
    --cc=schalla@marvell.com \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).