From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C566AA0C4E;
Tue, 2 Nov 2021 18:46:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 8309E4069F;
Tue, 2 Nov 2021 18:46:04 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id B680B40689
for <dev@dpdk.org>; Tue, 2 Nov 2021 18:46:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1635875163;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=LRkDXg867+Usvezo/3M7TF8D6OhpWvdtYDfXPE09j0I=;
b=YhDSfRvFyVg7ALPWJyIyv8y6vXEC0gebsOIMdhixkWi4bAhVHVkxilMIFOsCVgA+xEpClA
7fc+Lx8nHtvhLNEdgenn/DxOs2vMydV4EYgdgWt+842cUYq9aizK/JbPOQntcas5/WLwqr
D8QAo2twxxSLahaFKrDjcORRHDgGraw=
Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com
[209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-77-KPxoHhP7MYiUmCS8dt_mdA-1; Tue, 02 Nov 2021 13:46:02 -0400
X-MC-Unique: KPxoHhP7MYiUmCS8dt_mdA-1
Received: by mail-lf1-f69.google.com with SMTP id
d10-20020a0565123d0a00b004002359a671so27132lfv.10
for <dev@dpdk.org>; Tue, 02 Nov 2021 10:46:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=LRkDXg867+Usvezo/3M7TF8D6OhpWvdtYDfXPE09j0I=;
b=bocR+18d8XtgvB4f/CiPWLtyzCPqoIKq8uA99a4n5DHyTCyPUrYPDtWxYQTLd9cHY3
AoSxAB9K86ROrQfCtDHIqCtM1S/zD2RFQJkwBXJxNlu84/4v0fCJHJe6f078YW7XdGun
yewHoRUFWG8SO2Ry29WA7w46zh6zTIvzsdAkn41qkv6yg+vEGkbCLgWBI4cEtg45LXOG
5pkn8r7TE2Eiu7smyT6k3GJKPLmyAjilKRklEtQ0H0lqrrDF7IP3ISPN0UTfWeaN20WK
feoINDF41uSisO0YTnIafWIlnmS3/nv+lkNlNhrRlYLi4aGk8+pPpygPoByMdXlUHXof
pZMw==
X-Gm-Message-State: AOAM531ioVBCfunJkGN0MygGs+L3GcelpaEovvKIeqaqnuI/Jh9xiwHQ
TaUJ6bpla8kL4S6/Va1UCxq3J1jFeQ1A0wS9mklivdn4XuNo+IGeyMI4LrQf7Dyt9JvGyCPn9b6
wOSAedDQYyG6aRpYok3M=
X-Received: by 2002:a05:6512:a8e:: with SMTP id
m14mr35928080lfu.575.1635875160495;
Tue, 02 Nov 2021 10:46:00 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwzxXIR6rdmVgKU0rE0RwLCGG8haoGXl77Gwpj1tjmC8R31/gX94WBGZAbC1A+Eh8WU/0kbZTHDqvFIrVe+f90=
X-Received: by 2002:a05:6512:a8e:: with SMTP id
m14mr35928051lfu.575.1635875160215;
Tue, 02 Nov 2021 10:46:00 -0700 (PDT)
MIME-Version: 1.0
References: <20210922122920.34759-1-david.hunt@intel.com>
<20210923110213.21350-1-david.hunt@intel.com>
<20210923110213.21350-2-david.hunt@intel.com>
In-Reply-To: <20210923110213.21350-2-david.hunt@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 2 Nov 2021 18:45:48 +0100
Message-ID: <CAJFAV8wkkTO0Mu2MdGD0yPj2hs+HMaZM8pO-yuGxv-X7KAASzA@mail.gmail.com>
To: David Hunt <david.hunt@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 2/2] eal: add additional info if core mask
too long
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Sep 23, 2021 at 1:03 PM David Hunt <david.hunt@intel.com> wrote:
>
> If the user requests to use an lcore above 128 using -c,
> the eal will exit with "EAL: invalid coremask syntax" and
> very little else useful information.
>
> This patch adds some extra information suggesting to use --lcores
> so that physical cores above RTE_MAX_LCORE (default 128) can be
> used. This is achieved by using the --lcores option by mapping
> the logical cores in the application to physical cores.
>
> For example, if "-c 0x300000000000000000000000000000000" is
> used, we see the following additional output on the command line:
>
> EAL: lcore 128 >= RTE_MAX_LCORE (128)
> EAL: lcore 129 >= RTE_MAX_LCORE (128)
> EAL: to use high physical core ids , please use --lcores to
> map them to lcore ids below RTE_MAX_LCORE,
> EAL: e.g. --lcores 0@128,1@129
>
> Signed-off-by: David Hunt <david.hunt@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> changes in v3
> * added this patch to the set. Addresses the changes for
> the -c option.
> changes in v4
> * fixed buffer overrun in populating lcore array.
> * switched from strlcpy to strdup due to a clang error.
> changes in v5
> * replaced strdup and frees with a const char *, as we
> just need to keep track of original pointer location.
> * reverted err: usage to return -1, as no free() needed.
> * other minod code cleanups.
> ---
> ---
> lib/eal/common/eal_common_options.c | 47 ++++++++++++++++++++++++-----
> 1 file changed, 40 insertions(+), 7 deletions(-)
>
> diff --git a/lib/eal/common/eal_common_options.c b/lib/eal/common/eal_common_options.c
> index 72735e0b09..7f715e4c15 100644
> --- a/lib/eal/common/eal_common_options.c
> +++ b/lib/eal/common/eal_common_options.c
> @@ -750,10 +750,12 @@ check_core_list(int *lcores, unsigned int count)
> static int
> eal_parse_coremask(const char *coremask, int *cores)
> {
> - unsigned count = 0;
> + unsigned int count = 0;
> int i, j, idx;
> int val;
> char c;
> + int lcores[RTE_MAX_LCORE];
> + const char *coremask_orig = coremask;
>
> for (idx = 0; idx < RTE_MAX_LCORE; idx++)
> cores[idx] = -1;
> @@ -770,29 +772,60 @@ eal_parse_coremask(const char *coremask, int *cores)
> i = strlen(coremask);
> while ((i > 0) && isblank(coremask[i - 1]))
> i--;
> - if (i == 0)
> + if (i == 0) {
> + RTE_LOG(ERR, EAL, "No lcores in coremask: [%s]\n",
> + coremask_orig);
> return -1;
> + }
>
> - for (i = i - 1; i >= 0 && idx < RTE_MAX_LCORE; i--) {
> + for (i = i - 1; i >= 0; i--) {
This loop exit condition changes here: this ensures that, once we
leave the loop, i == -1.
As a consequence... (see below)
> c = coremask[i];
> if (isxdigit(c) == 0) {
> /* invalid characters */
> + RTE_LOG(ERR, EAL, "invalid characters in coremask: [%s]\n",
> + coremask_orig);
> return -1;
> }
> val = xdigit2val(c);
> - for (j = 0; j < BITS_PER_HEX && idx < RTE_MAX_LCORE; j++, idx++)
> + for (j = 0; j < BITS_PER_HEX; j++, idx++)
> {
> if ((1 << j) & val) {
> - cores[idx] = count;
> + if (count >= RTE_MAX_LCORE) {
> + RTE_LOG(ERR, EAL, "Too many lcores provided. Cannot exceed %d\n",
> + RTE_MAX_LCORE);
> + return -1;
> + }
> + lcores[count] = idx;
> count++;
> }
> }
> }
... this loop below is dead code.
> for (; i >= 0; i--)
> - if (coremask[i] != '0')
> + if (coremask[i] != '0') {
> + RTE_LOG(ERR, EAL, "invalid characters in coremask: [%s]\n",
> + coremask_orig);
Nit: capital letter.
> return -1;
> - if (count == 0)
> + }
> + if (count == 0) {
> + RTE_LOG(ERR, EAL, "No lcores in coremask: [%s]\n",
> + coremask_orig);
> + return -1;
> + }
> +
> + if (check_core_list(lcores, count))
> return -1;
> +
> + /*
> + * Now that we've gto a list of cores no longer than
Same typo I commented on patch 1 for v4.
> + * RTE_MAX_LCORE, and no lcore in that list is greater
> + * than RTE_MAX_LCORE, populate the cores
> + * array and return.
> + */
> + do {
> + count--;
> + cores[lcores[count]] = count;
> + } while (count != 0);
> +
> return 0;
> }
>
> --
> 2.17.1
>
--
David Marchand