From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F540A0A0C; Thu, 1 Jul 2021 15:57:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AEEC40141; Thu, 1 Jul 2021 15:57:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F2AD84003E for ; Thu, 1 Jul 2021 15:57:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625147836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9JoZPwY2h3/6mp/Gg6kTssvIQ71K5agCtj62r+QbeZw=; b=VYqor5sn3gBn8jXFyyyHCkjQ0tIH5xf6VIiqCWaD2poo7qA3zAVmgTYRNeX6uvUStx91wR EwraBxliGuWza6GrAU2zhTFtdAtyS3F31AGHKf6w9xJR4wubBYux1QyYF1g0vhSbPViZDs G7HHLixUeWS/FEjyEm31BOkg1KXP/xA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-ufO8i5XHMUG7FiYQ7SOJGw-1; Thu, 01 Jul 2021 09:57:13 -0400 X-MC-Unique: ufO8i5XHMUG7FiYQ7SOJGw-1 Received: by mail-vk1-f197.google.com with SMTP id b12-20020a056122124cb029024f6b600c04so1305400vkp.23 for ; Thu, 01 Jul 2021 06:57:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9JoZPwY2h3/6mp/Gg6kTssvIQ71K5agCtj62r+QbeZw=; b=ejZcU30ZaF5nCUtl76rwRO+QbQbWdWpd8qBbcuZdAu3YxF3sCjzNeNpz9wzsczr+vw VWiapnqDHUJJjVXJaxvNDk15idSPplPmU+Sdd8IppkHonUpncJNUX3//oH3ZPbzWrPhp twzZifq9lc0DIyTtMc1C06Z+GeRrSZkt0Ms31aArNnWbNMZ6hIjHL6sQzA3fo7rDbzh5 XcScMiH4107gS4pzkgpIjjvgG+cFRxs6ErA/fuT8s+zUhPdLADlyhP3Y7SY4bUqqYTnm SwlKcYY2qubjSYR0kr622eMAbviN8wiqBtsVq5fWuWXe0vG2xw74jjkdX3gAVccrQnt4 r2fw== X-Gm-Message-State: AOAM530dyT1wLcTSOpoT6FsPhbA5JJirPdd/lGuXYGkRI+CQmztKv0jD AT0u+gftl5vX1YGU3x/4Ck8M7YanH5waYg1RQRBetnFi6yi04fGlDiQnSB3uOIl/qMbqagh48G0 dn2ZRT54lcXqf61hUFz8= X-Received: by 2002:ab0:7409:: with SMTP id r9mr33848uap.53.1625147833309; Thu, 01 Jul 2021 06:57:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4I8g2aHhQR8vA83B5nLyuNqIpMd21JkftwUmePoPsOGc/8PWvQ/AypXTjnNqBBQsVZ9XlenYz8XonFDZUiCQ= X-Received: by 2002:ab0:7409:: with SMTP id r9mr33827uap.53.1625147833101; Thu, 01 Jul 2021 06:57:13 -0700 (PDT) MIME-Version: 1.0 References: <20210602094108.1575640-1-jiawenwu@trustnetic.com> <20210602094108.1575640-6-jiawenwu@trustnetic.com> In-Reply-To: <20210602094108.1575640-6-jiawenwu@trustnetic.com> From: David Marchand Date: Thu, 1 Jul 2021 15:57:01 +0200 Message-ID: To: Jiawen Wu Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 05/24] net/ngbe: add log type and error type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, Currently looking at new drivers posted on the ml. On Wed, Jun 2, 2021 at 11:40 AM Jiawen Wu wrote: > @@ -124,3 +131,12 @@ RTE_PMD_REGISTER_PCI(net_ngbe, rte_ngbe_pmd); > RTE_PMD_REGISTER_PCI_TABLE(net_ngbe, pci_id_ngbe_map); > RTE_PMD_REGISTER_KMOD_DEP(net_ngbe, "* igb_uio | uio_pci_generic | vfio-pci"); > > +RTE_LOG_REGISTER(ngbe_logtype_init, pmd.net.ngbe.init, NOTICE); > +RTE_LOG_REGISTER(ngbe_logtype_driver, pmd.net.ngbe.driver, NOTICE); Please use helpers added recently: https://git.dpdk.org/dpdk/commit/?id=eeded2044af5bbe88220120b14933536cbb3edb6 Converting this patch should be quick: RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_init, init, NOTICE) RTE_LOG_REGISTER_SUFFIX(ngbe_logtype_driver, driver, NOTICE); etc... > + > +#ifdef RTE_ETHDEV_DEBUG_RX > + RTE_LOG_REGISTER(ngbe_logtype_rx, pmd.net.ngbe.rx, DEBUG); > +#endif > +#ifdef RTE_ETHDEV_DEBUG_TX > + RTE_LOG_REGISTER(ngbe_logtype_tx, pmd.net.ngbe.tx, DEBUG); > +#endif -- David Marchand