From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 246B9A0C55; Wed, 13 Oct 2021 12:18:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1BD8410DA; Wed, 13 Oct 2021 12:18:26 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 07F2A40E64 for ; Wed, 13 Oct 2021 12:18:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634120304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=X8y5jMFoUxhAYsidHLlNyyRgu5IYPyS9BWslblog3qw=; b=T4N+WBDVZf8NJ5xc0l3PQ/8ZWZLGr7MLrWnWPsbHe4daXSAvnBVIEoGuJZbYTXW45A1Dgs Po21oek6M74wf2GDxVj1nt4EiMMZqYuoV0spqZt/g8rJac1MsxQzg5OfVSlzkFfZ/KfKZg jgJGzMHsBnowRixjqjOaneUpkPhEOwk= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-376-s4u0IG_zOdKaTuwmGluGCA-1; Wed, 13 Oct 2021 06:18:23 -0400 X-MC-Unique: s4u0IG_zOdKaTuwmGluGCA-1 Received: by mail-lf1-f69.google.com with SMTP id bi16-20020a0565120e9000b003fd56ef5a94so1639973lfb.3 for ; Wed, 13 Oct 2021 03:18:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=X8y5jMFoUxhAYsidHLlNyyRgu5IYPyS9BWslblog3qw=; b=acPvGNgrL1u10NtZK4XWWFJoIjfeqSUr6kxFexkJQUWuUIIrZvnolDbRLVWXCjHQK/ us+7cAe8iNvv2Q50mpzMQwyTlHMFXdRP+IYSzDDp+eHN6iMx3NM0IzuIrB7GCIgu2rLT voBhzpFDq/wf78yk9nhyz/LxXYiNGYx8R5SiF5MyMZunlkHDYftVJnBAml4X2UEGQKca vKsqlfAIfsmFwvCj3Zh6cszLeC14wJm11Pk8JlyaFPqDefMggeb0wpzkYWmGy2djpDaB 3dz2Qj5zmB6wQV+dwZqeicAjnnyfCItsZV34trMJAZ8Y1TnHRgfruto2kQInT4FDEfL4 zE8w== X-Gm-Message-State: AOAM530B4fZypu/Cbz3DGnxj4kX9Pr5N8nrvSPq+veKuyVxgt+HHl6hj 04jXEl6RXuMeygcxJGy6Ur9tzDICwlRbm+ElJMYl6FoZBx2jbjk/8ttf630j6IOzcxKiKf/0rZE M4On1/VegBSWGk+MVEc8= X-Received: by 2002:a2e:a54d:: with SMTP id e13mr33186835ljn.159.1634120301899; Wed, 13 Oct 2021 03:18:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwn8ZQ+wAEsYhGQwy/huYa8pDvGLML3gxe8uhm2fmtXX4u6TkMLCx/LI9x4p0m5OJuk6O/+qDdqY7GqUzwBic= X-Received: by 2002:a2e:a54d:: with SMTP id e13mr33186810ljn.159.1634120301633; Wed, 13 Oct 2021 03:18:21 -0700 (PDT) MIME-Version: 1.0 References: <20210921081632.858873-1-dkozlyuk@nvidia.com> <20211011085644.2716490-1-dkozlyuk@nvidia.com> <20211011085644.2716490-3-dkozlyuk@nvidia.com> In-Reply-To: From: David Marchand Date: Wed, 13 Oct 2021 12:18:10 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dev , Slava Ovsiienko , Anatoly Burakov , NBU-Contact-Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v6 2/3] eal: add memory pre-allocation from existing files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 12, 2021 at 11:09 PM Dmitry Kozlyuk wrote= : > > From this, I see two parts in this patch: > > - faster restart, reusing hugepage files as is (combination of not call= ing > > unlink() and doing "clear on alloc"), > > This part is interesting, and I think a single knob for this would be > > enough. > > In combination with rte_extmem* API this know would indeed allow to imple= ment the feature in the app. However, the drawback is that all the logic to= select hugepage size, NUMA, and names would need to be done from the app, = probably with its own options. OTOH, there is already hugetlbfs and numactl= to avoid apps duplicating this logic. Also, it's not only the fast restart= , but also the fast initial start on a prepared system. How do you "prepare" a system? > > > - finegrained control of hugepage files, but it has the drawback of > > imposing primary/secondary run with the same options. > > The second part seems complex to configure. I see conflicts with > > existing options, so it seems a good way to get caught up in the carpet > > (sorry if it translates badly from French :p). > > I don't see why synchronizing memory options is a big issue. We have too many options for the memory subsystem. I mentionned --socket-mem, --huge-dir, --file-prefix. But there is also --huge-unlink, --no-shconf, --in-memory, --legacy-mem, --single-file-segments, --match-allocations and --socket-limit. Some of those do part of the job, others are incompatible with this new option and probably some are orthogonal. Sure we can add a new one that prepare your toasts, coffee and wake up the kids (that's progress!). Maybe you can provide an example on how this is used? Thanks. --=20 David Marchand