Re: [PATCH] mem: fix displaying heap ID failed for heap info command

[David Marchand <david.marchand@redhat.com>]

On Thu, Feb 9, 2023 at 4:24 AM fengchengwen <fengchengwen@huawei.com> wrote:
>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
>
> And, how abort add error log in telemetry valid_name, so so that problems can
> be identified as early as possible.
>
> On 2023/2/9 11:03, Huisong Li wrote:
> > The telemetry lib has added a allowed characters set for dictionary names,
> > See commit
> > 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names")
> >
> > The space is not in this set, which cause the heap ID in /eal/heap_info
> > cannot be displayed. Additionally, 'heap' is also misspelling. So use

I agree this typo is ugly, but I wonder if some telemetry users
started relying on it...


> > 'Heap_id' to replace 'Head id'.
> >
> > Fixes: e6732d0d6e26 ("mem: add telemetry infos")

IIUC, the commit that broke displaying "Head id" is actually the one
that limited the set of chars.


> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Huisong Li <lihuisong@huawei.com>


-- 
David Marchand