From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 410F441C4B; Thu, 9 Feb 2023 09:49:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A25C4161A; Thu, 9 Feb 2023 09:49:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id F179141611 for ; Thu, 9 Feb 2023 09:49:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675932548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T+GCMiyP7E15phUuJFzj85kE4G4w+piJK/+5HDqBJO0=; b=FTSFj6z+XOAEmJPMGPxaVfFTVxntTiJ8Pya93JhXYHcK4rSk0JrAOhhjl1Vub06hiPrGAv UcLMA2h6VpHx96d78XbZYz0mKCoWfq0ZIielptfitRQR+Oi8m587smrGmQJEYQuMDBkRm+ U6Hzun4HmgC1UFRTfQxnUUvVjhHig4U= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-403-oGkYW_GAPzidOLGbBGnt8w-1; Thu, 09 Feb 2023 03:49:07 -0500 X-MC-Unique: oGkYW_GAPzidOLGbBGnt8w-1 Received: by mail-pl1-f199.google.com with SMTP id g12-20020a170902868c00b00199148d00f2so961329plo.17 for ; Thu, 09 Feb 2023 00:49:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T+GCMiyP7E15phUuJFzj85kE4G4w+piJK/+5HDqBJO0=; b=utLbwpVhQAIA4nJxQvEPQFaaH3MLhA/IQEQX/JqU4naiI4BilhpIN09+IJnqIC1uFN 3b+aU1BvGEs9B1bl9c8Wc+/JI18tWmBnc5gl+35XxJtl+Y0fwZcMQ+oOPUZMwzQ9zt0k rFG7LU7VSKB0kKopLunztu2tDRDVWbVIvyiF1nJDCH3xC5Bh+L391hmSuaio6g7bdHNc OMqBAW0L6YWH4tsv/3kofMEzRYpoOQ6S3xrSjulESMdt7uakRV6EVo6/NXxK6R5NDmsn amn/N2oNbGA70m3A8WsYLSf391om2lcaUtmoiw8dENb2bVStBBjleEQhGUT/PH+zKHTy o/2g== X-Gm-Message-State: AO0yUKUsm6g5ZinyX87CO7qkLwLodET2QMepbISf+cUN2tImvFfMlDaD OagTuz+KN3f0Nkx8L+IIWJgqyVtbk7gQ8YZokJaMjNR9TDhEm2K54nFLC3eNi2Jqb/VUPIDvYa1 9LVJGD6PNiKTXccZrGcU= X-Received: by 2002:a63:af44:0:b0:4ad:30aa:8e6a with SMTP id s4-20020a63af44000000b004ad30aa8e6amr2256857pgo.40.1675932546288; Thu, 09 Feb 2023 00:49:06 -0800 (PST) X-Google-Smtp-Source: AK7set/ki/+CC2wXGcXVoFNTFg9NrLnJ2xV9U6LKYCHlnoJGQUO5AWN3tjZjtNatetdLt3P0sYAghAWLms2F3c/A08s= X-Received: by 2002:a63:af44:0:b0:4ad:30aa:8e6a with SMTP id s4-20020a63af44000000b004ad30aa8e6amr2256853pgo.40.1675932546039; Thu, 09 Feb 2023 00:49:06 -0800 (PST) MIME-Version: 1.0 References: <20230209030341.9697-1-lihuisong@huawei.com> In-Reply-To: From: David Marchand Date: Thu, 9 Feb 2023 09:48:54 +0100 Message-ID: Subject: Re: [PATCH] mem: fix displaying heap ID failed for heap info command To: fengchengwen Cc: Huisong Li , dev@dpdk.org, bruce.richardson@intel.com, mb@smartsharesystems.com, huangdaode@huawei.com, liudongdong3@huawei.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 4:24 AM fengchengwen wrote: > > Acked-by: Chengwen Feng > > And, how abort add error log in telemetry valid_name, so so that problems can > be identified as early as possible. > > On 2023/2/9 11:03, Huisong Li wrote: > > The telemetry lib has added a allowed characters set for dictionary names, > > See commit > > 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") > > > > The space is not in this set, which cause the heap ID in /eal/heap_info > > cannot be displayed. Additionally, 'heap' is also misspelling. So use I agree this typo is ugly, but I wonder if some telemetry users started relying on it... > > 'Heap_id' to replace 'Head id'. > > > > Fixes: e6732d0d6e26 ("mem: add telemetry infos") IIUC, the commit that broke displaying "Head id" is actually the one that limited the set of chars. > > Cc: stable@dpdk.org > > > > Signed-off-by: Huisong Li -- David Marchand