From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A82E743CAD; Thu, 14 Mar 2024 16:59:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E41CF40E28; Thu, 14 Mar 2024 16:59:11 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8005740297 for ; Thu, 14 Mar 2024 16:59:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710431950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yKiBxkM4mptroLV+6+CVIZ7bwtuWbUZlrjY190Z0eao=; b=FqgOF0MRYYHm7g8sfoVQXvJLqfsBWBVK9vmaRjP6BPtaVJwKIV0F31xwibWxCsZFQYvMsC 9phbe+F2bhISTat0ErTX9QWYO/UX1ooZOU7lIjcdya7O/6+ZEagzD//phTcFLYUesXEwpJ DuzkqA7iZyg7VvGH4RR8x0PWCNNZJKI= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-338-VVPRaNjjPDuT5KRQ1FX0XA-1; Thu, 14 Mar 2024 11:59:08 -0400 X-MC-Unique: VVPRaNjjPDuT5KRQ1FX0XA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-5139c92ba2eso1320361e87.1 for ; Thu, 14 Mar 2024 08:59:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710431947; x=1711036747; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yKiBxkM4mptroLV+6+CVIZ7bwtuWbUZlrjY190Z0eao=; b=EzO7JK6B8Z5L1F4eikofHdImya4YNW79DXukhRgdP96XW2SWD+3OXOb6V729rstblX HycZe4JjeXf/+P2TkDDttK3F9HivVJxZi9f9IWy7kqHVxMKlk6XfTmHe8TrdLSDToh/d uLqP37B5bxbGnz3LjBtXAjaBNtofVJR8weFaeB1jQX4axmp2OP45AUTyG/FgYZpezVfd UppSGeSEGxDmxt9/+L6XS2sOBfypP1WLgsI5mDisn9KaGKv/pohfwp8mkwrd99+HUHwb woZ5nz+na0MTe9/FEbPCCHjSnR+k2mxtiZKGf5ZLiRXPquCDOf33iiscseX33lMoTk9L uZGQ== X-Gm-Message-State: AOJu0YwwbDhrM+ffgLHD8Pso2R6Iw5WF/p+fyhgaLQ2Zrvhp5yojLHa8 Li0J7VJ2bEfv3H+FWIBp9/fK3omLPjimZ5A0s7Bju0tVJUfk5rphYyR2c8qAOw3Rw3HeRHdxVFl SwIvxImaPkoVinv/Wpa9jUBjEyPipJ5s2+6c8ruqh4mviBXFlkz7atyDAykEocN/cSB8P3K0CC2 VoLbmuo0NxxVqjf5E= X-Received: by 2002:ac2:5b8d:0:b0:513:c5a1:a8f6 with SMTP id o13-20020ac25b8d000000b00513c5a1a8f6mr854124lfn.17.1710431947125; Thu, 14 Mar 2024 08:59:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFdOi/LtYmcBCyJE7AXmgpiBmykWgV+2x2lfmxUp4N0yAVgKY9+W/+aaGDwyZCjwykqqkS1Kh4lCSloao1Abbk= X-Received: by 2002:ac2:5b8d:0:b0:513:c5a1:a8f6 with SMTP id o13-20020ac25b8d000000b00513c5a1a8f6mr854117lfn.17.1710431946829; Thu, 14 Mar 2024 08:59:06 -0700 (PDT) MIME-Version: 1.0 References: <1709932817-29583-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1709932817-29583-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 14 Mar 2024 16:58:54 +0100 Message-ID: Subject: Re: [PATCH] hash: remove return statement from function returning void To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Sameh Gobriel , Stephen Hemminger , Vladimir Medvedkin , Yipeng Wang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Tyler, On Fri, Mar 8, 2024 at 10:20=E2=80=AFPM Tyler Retzlaff wrote: > > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void. > Remove superfluous return statement from rte_thash_gfni_bulk. > > Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs") > Cc: stephen@networkplumber.org > > Signed-off-by: Tyler Retzlaff > --- > lib/hash/rte_thash_gfni.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/hash/rte_thash_gfni.h b/lib/hash/rte_thash_gfni.h > index edae2e8..132f375 100644 > --- a/lib/hash/rte_thash_gfni.h > +++ b/lib/hash/rte_thash_gfni.h > @@ -71,7 +71,7 @@ > rte_thash_gfni_bulk(const uint64_t *mtrx, int len, uint8_t *tuple[], > uint32_t val[], uint32_t num) > { > - return rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num); > + rte_thash_gfni_bulk_stub(mtrx, len, tuple, val, num); > } I am surprised the CI did not catch it. I need to pass -pedantic when compiling with this header, but no code does this in-tree. How did you catch this issue? --=20 David Marchand