From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B36FAA00C3; Wed, 21 Sep 2022 15:35:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5E72410E8; Wed, 21 Sep 2022 15:35:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 06D464014F for ; Wed, 21 Sep 2022 15:35:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663767330; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wxG124wtT+2Hgzcd5beBiyuzJW0y2bpmQkBxa2YD0js=; b=VWKmQcQuNgSIW32nNXeip3yafs2rDwMNQhBlvsniACkmyo9krWCYVW3n4mR/ZME+s3qexC zZHQwzItjQzNrJk/hXCHYLtuv8MWqEUBID35Rk7tZhf2PnIB26z91OQ0eWSX+/DJphfVzz OQWwC7DJ/U16o+b4O+DcccyXMIrieyM= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-433-ZpY3ZU3JPI6DeamrxVWdzQ-1; Wed, 21 Sep 2022 09:35:29 -0400 X-MC-Unique: ZpY3ZU3JPI6DeamrxVWdzQ-1 Received: by mail-lf1-f70.google.com with SMTP id k14-20020a0565123d8e00b0049918295183so2073271lfv.16 for ; Wed, 21 Sep 2022 06:35:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=wxG124wtT+2Hgzcd5beBiyuzJW0y2bpmQkBxa2YD0js=; b=jJK5dCsKZeTAkfiJhLr9cK94HmA0Bq01U3v0ovnpP1JUKI/SB/byeOcZH6+8rJv2ig ZCGE1d0VX28iwsCaiL2HCDj3Mo1cFyawsRK4uE+nzOhu5gRJu2l+r4ImuhBzb+bBYML6 bgkvwAGwrzb4LUIKa2D3nbXsScEr7UJTbkJecNqLsVqruz7YkwAYyjJwrHjgYNEC04an lHJgvUmPI9X65q079ILZqv1vWmYctG/XTOLDS+OQeXCeYM4vMZXRUuSpWpuxZc27T1jQ ksMfTHuPZZvjO5K1HgeRo4YWrNhm9IFLSawDNwzhjfEaCmY+3VvkwLVeMCUCZz9ve+JE WOeA== X-Gm-Message-State: ACrzQf1p6FqE8MIwU/VKyBAwqZAWVouOVkh/2usV5Q8CMgtWNJZpuCJ0 at+JIv/uNLISbg3y2ekmL1v9cjyx3Kk3kmDnCu/Z17yPsnywzYKXdYTe5iVgnsVeg1ItwIGOW4Y U4dL0XOl0ZdZ8A2Htfug= X-Received: by 2002:a05:6512:1289:b0:49f:1b3d:88c5 with SMTP id u9-20020a056512128900b0049f1b3d88c5mr10248244lfs.499.1663767327761; Wed, 21 Sep 2022 06:35:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7GgK8gXo2dQZBhGnvOJW951FSPhmsd5IjIur+sPjjYAHJQ9eRzXK9a7oai7+oJk6eZmRezVOofbOfiIEXLF/0= X-Received: by 2002:a05:6512:1289:b0:49f:1b3d:88c5 with SMTP id u9-20020a056512128900b0049f1b3d88c5mr10248239lfs.499.1663767327546; Wed, 21 Sep 2022 06:35:27 -0700 (PDT) MIME-Version: 1.0 References: <20220728094103.137862-1-fidaullah.noonari@emumba.com> <20220728210327.7077be93@sovereign> In-Reply-To: <20220728210327.7077be93@sovereign> From: David Marchand Date: Wed, 21 Sep 2022 15:35:16 +0200 Message-ID: Subject: Re: [PATCH v2] eal: change alloc_sz calculation which may cause unnecessarily allocation To: Dmitry Kozlyuk , Fidaullah Noonari Cc: dev@dpdk.org, "Burakov, Anatoly" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jul 28, 2022 at 8:03 PM Dmitry Kozlyuk wrote: > > 2022-07-28 14:41 (UTC+0500), Fidaullah Noonari: > > The amount of memory to allocate from the system for heap expansion > > was calculated in a way that may yield one page more than needed. > > This could hit the allocation limit from the system or EAL. > > The allocation would fail despite enough memory being available. > > > > In response to mail: > > http://inbox.dpdk.org/dev/CAEYuUWCnRZNwxiOHEeTHw0Gy9aFJRLZtvAG9g=smuUvUEMcFXg@mail.gmail.com/ > > > > Signed-off-by: Fidaullah Noonari > > Acked-by: Dmitry Kozlyuk > Do you have a reproducer? This sounds like a fix, should we backport it? -- David Marchand