From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B601E454EF;
Tue, 25 Jun 2024 14:04:40 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 55FA0427DB;
Tue, 25 Jun 2024 14:04:40 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 410CD427DB
for <dev@dpdk.org>; Tue, 25 Jun 2024 14:02:04 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1719316923;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=g8XDd/GL99cOAr/FgE6b2+IQzAALAuRqQeVPkjqoXYk=;
b=IzqvVHeqCmXyyo8QWCAVasET6aAsJkSqPoJRr3gIFTHXFRWj8pFIQa8ChAjjRZRW0ICxJM
vuuIKft30cEBgD6RDElhk3v+jR1MtTJ9nlWolAZ2C33cJS6FD04CHNnvFAZxRhvcMGRAWR
9+DLjfq66H3abGS4H52Ju5J9t2K7pww=
Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com
[209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-180-xMFNccqHOsGMLkOapTzNLg-1; Tue, 25 Jun 2024 08:02:02 -0400
X-MC-Unique: xMFNccqHOsGMLkOapTzNLg-1
Received: by mail-lj1-f200.google.com with SMTP id
38308e7fff4ca-2ec617f8b6fso17778941fa.0
for <dev@dpdk.org>; Tue, 25 Jun 2024 05:02:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1719316921; x=1719921721;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=g8XDd/GL99cOAr/FgE6b2+IQzAALAuRqQeVPkjqoXYk=;
b=kLM+d7d3QtfqK6DBFrCugr9MGLKX8fiSz15nWo/h3XHwzjoBHUX1SgkQmSy/d3mzT0
S7e9eX4TMWhdCuoEyzBrFMUVSJBwz8DcAx5PguLDrIKjeBQx5X742og9oWgNEj8g0i6l
nyQPu5FLCZNAQ+QuwnXDykPgRCxqOZYFZrqqYgMDfMTr9VyVdZjcBM13dDb6ezDwMq+q
Yv8M9NS7cs230vgbobodQ2ZnnSsRkZUFzIg8VdU4dul99sMhB6oRVE7W1WTXNs3Co7SC
nNfHRLz2RKP1G5YajdjzpKhPi3ZVX77Rtpad9lkPZUkTQe8wIi2UyjRSSHFBdRxstEYr
X1QQ==
X-Forwarded-Encrypted: i=1;
AJvYcCX/2yE799DC2Wub1EMFmitLXn/VKTSgZlVo8/Iz9/JLfzcILdsqorevIJUCrdv+/uaQls+BrgXMP+qZO9c=
X-Gm-Message-State: AOJu0YzpvjbjSEKEhATklASUarSGWefwCYj0XsgYOosAijEFl1/hcW3M
qazifR4zajvikdutOntnxTXS5jiYEFjjxQhf4tcP91mWSrW+YNZBimZ4yo7jUGwyiOZWYlr40o7
CzpPqv7++ahWtFaTykTwgmpCN9J6bfwD0uDvvsC+t3evf2HBzFH28V8k24kxoUVbDYEG33UPfzh
y7U8e+/wsyMdjsfeQ=
X-Received: by 2002:a05:651c:209:b0:2ec:5777:aa61 with SMTP id
38308e7fff4ca-2ec5931002amr57676481fa.3.1719316920969;
Tue, 25 Jun 2024 05:02:00 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IHHU0xs96MACMyZTCvnpBJ9CWK99C/5EtADc0BUN6skPRChEn3XAG6dFRGABjbDMpXBBVl/MuzGJ0C/9UCRiIA=
X-Received: by 2002:a05:651c:209:b0:2ec:5777:aa61 with SMTP id
38308e7fff4ca-2ec5931002amr57676381fa.3.1719316920635; Tue, 25 Jun 2024
05:02:00 -0700 (PDT)
MIME-Version: 1.0
References: <20240624110415.3230-1-vratnikov@netgate.com>
<20240624081357.00940a55@hermes.local>
In-Reply-To: <20240624081357.00940a55@hermes.local>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 25 Jun 2024 14:01:49 +0200
Message-ID: <CAJFAV8woE1OBN432gYtkF-Sk8G5sPWbV5d5kHEHXD44uNHjtjQ@mail.gmail.com>
Subject: Re: [PATCH v2] bus/vmbus: add device_order field to rte_vmbus_dev
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Vladimir Ratnikov <vratnikov@netgate.com>, longli@microsoft.com,
dev@dpdk.org
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Jun 24, 2024 at 5:14=E2=80=AFPM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Mon, 24 Jun 2024 11:04:15 +0000
> Vladimir Ratnikov <vratnikov@netgate.com> wrote:
>
> > diff --git a/drivers/bus/vmbus/bus_vmbus_driver.h b/drivers/bus/vmbus/b=
us_vmbus_driver.h
> > index e2475a642d..6b010cbe41 100644
> > --- a/drivers/bus/vmbus/bus_vmbus_driver.h
> > +++ b/drivers/bus/vmbus/bus_vmbus_driver.h
> > @@ -37,6 +37,7 @@ struct rte_vmbus_device {
> > rte_uuid_t device_id; /**< VMBUS device id */
> > rte_uuid_t class_id; /**< VMBUS device type */
> > uint32_t relid; /**< id for primary */
> > + uint16_t device_order; /**< Device order after pr=
obing */
> > uint8_t monitor_id; /**< monitor page */
> > int uio_num; /**< UIO device number */
> > uint32_t *int_page; /**< VMBUS interrupt page =
*/
> > diff --git a/drivers/bus/vmbus/vmbus_common.c b/drivers/bus/vmbus/vmbus=
_common.c
>
> Is this an ABI change?
drivers/bus/vmbus/meson.build:driver_sdk_headers =3D files('bus_vmbus_drive=
r.h')
Only drivers of this bus know the rte_vmbus_device object.
So this patch does not impact the public ABI.
Yet, I fail to see what this patch is trying to achieve.
--=20
David Marchand