From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 444A5A0C43; Wed, 20 Oct 2021 21:54:26 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C712D40150; Wed, 20 Oct 2021 21:54:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E775F40142 for ; Wed, 20 Oct 2021 21:54:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634759664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AhSYuT6s7nQobmHlRVg0zK9qIvAQV3GlNxCp8sRHx8o=; b=i4SXkp2aJpj/awwbdAOun/6/W2GRldMhNI95JochxO0dBsNEY+4/V31QnkwGj3Yn5OYlKA AlQwNkWgY+riazFgwHRykclNwFjFA0TW5TSHzChWGebrI5o/H+4g69qjASPn/IsjP8LmAm RyFek5+DJt4zNGmswP1XY0Krznu7L9o= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-yc42SNlQPnq4D4-7I3SpKA-1; Wed, 20 Oct 2021 15:54:23 -0400 X-MC-Unique: yc42SNlQPnq4D4-7I3SpKA-1 Received: by mail-lf1-f69.google.com with SMTP id x7-20020a056512130700b003fd1a7424a8so3448798lfu.5 for ; Wed, 20 Oct 2021 12:54:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AhSYuT6s7nQobmHlRVg0zK9qIvAQV3GlNxCp8sRHx8o=; b=vtaRIqB/hxJbLBQEIpk6Z18RU1RrShL5+0xniEtvwUCmi8aCxNOTDFyXdgkyVkBL3N Vy2NQ1mv2jtR2Lj351tS5DiZQz3kSouRrjUnAxF3Y8hDxqS2c5/qIMXTO8wHt2y5VRI1 /oDOYHXoEO8QB0qh8OHNB82ak2SYUWRg5wADZrAGlLJIiYy6MBP2a1eDpw2svGcDex0D wKDvWa7QJV6hOt45XdEYAYKBF+O4S4l4O3QmFZq+wLfDiDMz9KEhzp1ZmbDEJxfdQ1Zh PeZi1cGa2eCFAncTGt0uAwFN3iPdNmkq5Z0vNIVaBnZyxcg1mQIiISF213cLo+100wV+ N7ig== X-Gm-Message-State: AOAM530h+qAiYsPlURpWyr6GyXXxsklcMdlWNnb+ZV9/390c4kgRlbns V9sRai8miig40G0Q2cy7rX5nc1SNxyR2GHFS2qGEe8Hc+gIK18Gw3kNqF03PsVLXjPl+RA2IaSu 5hq7dYnJuO4R/fshGJ2o= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr1196952lfe.217.1634759661545; Wed, 20 Oct 2021 12:54:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2u2mNMC9KeqzEMmudJYTL1j54SLE20hOfTIN+yk46hJM9okGEsbqSKzh1vf3rsBwRPpDYGnXwXuGxpwaNYq0= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr1196936lfe.217.1634759661386; Wed, 20 Oct 2021 12:54:21 -0700 (PDT) MIME-Version: 1.0 References: <1634153265-193315-1-git-send-email-vladimir.medvedkin@intel.com> <1634233699-197151-1-git-send-email-vladimir.medvedkin@intel.com> <543fb591-d38a-5573-1bbc-db6a0c624893@intel.com> <21a6e602-1138-b8bb-e5c1-ff9c6c314c59@intel.com> In-Reply-To: <21a6e602-1138-b8bb-e5c1-ff9c6c314c59@intel.com> From: David Marchand Date: Wed, 20 Oct 2021 21:54:10 +0200 Message-ID: To: "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson Cc: dev , dpdk stable , "Medvedkin, Vladimir" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3] test/hash: fix buffer overflow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 19, 2021 at 5:58 PM Medvedkin, Vladimir wrote: > > I am not against the fix, but it seems to test something different > > than what an application using the hash library would do. > > Or if an application directly calls this hash function, maybe the unit > > test should not test it via rte_hash_create (which seems to defeat the > > abstraction). > > > > I'd say that user should not use this hash function with rte_hash. > Yipeng, Sameh, Bruce, > what do you think? Guys, can we conclude? Thanks. -- David Marchand