From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67809A00BE; Wed, 29 Apr 2020 10:22:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A3951D95D; Wed, 29 Apr 2020 10:22:27 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 780421D958 for ; Wed, 29 Apr 2020 10:22:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588148544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z31no7zQvLbxD4gMHAWpXX0F2t1iTJ//bm6hx/LYfXc=; b=HjE2vBpEhg72ByB9ra4AQqZbOv2OOa0uyx+4PjWru4Ce02vJQ49ZzLKcllLu0v8Ukhuf7d w1P6nnRuIQTkABC/5mGPa+igeUpL1VN6twp7XKh5Zc7tqXTCfVoIuyFxAfzFuMyTS2WuNd 2OPWcIR92oGaHdenuLVbakL4gb/KTIo= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-qfWLgie5PQCTCh3HjF9-sg-1; Wed, 29 Apr 2020 04:22:23 -0400 X-MC-Unique: qfWLgie5PQCTCh3HjF9-sg-1 Received: by mail-vk1-f197.google.com with SMTP id 68so1037704vkx.22 for ; Wed, 29 Apr 2020 01:22:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XIbiwz9KekFN1BXDeDLfarQ+zAmj2hxJEiC9UKeyhbs=; b=eKn+Xn4eu34Y89ELSEIoJUTq6CWMgMgQORX8/NGRJaFXwNt+7viLohBPpHzgt6qw6v s4RnfCBE/es7sSiloLG8OMstJve1YZnWWi33FsdaT9YsWhvouKjyRwzZO+YxituQoNhu AYZ6rgs/83ERT4tCFaFIlxCtRK3AfAEwAqjxCb2MIzPpak/wBPZFJ+sd3aajWXBCJCRz 2weS2YfEhtkQrUzXQy0m2PmkAI1aT2k9yDEKt6NWRwvZ4LWcirKcHuXfoMJlCVel3LJH xeGgRmP1Lv1FD0C6wtJR5t+cNS+42lxdhKqCAYhr1bFUURDr71kVaxbtz1vwLRYtNRL2 tQpA== X-Gm-Message-State: AGi0PuaSrKbY4grer9r4eMiPvd8zpfcn68svV8jWRjx/0M19s2FtcqVP LZ2nHQFM9Zirj4kRkaF9/oJHK7q2gtFLzXM7M5+vLrMhCsecbOBCKPodfsEz5UjqIsKic+WFMTk 2lVtcmCh+L1kmiFpolLo= X-Received: by 2002:a05:6102:114f:: with SMTP id j15mr24937389vsg.180.1588148542661; Wed, 29 Apr 2020 01:22:22 -0700 (PDT) X-Google-Smtp-Source: APiQypK7TcT0vxuMAGdRAInXzkKiCaD0RmZV7DnfQ3+zYifrNJhlDzbhqdR7vTNyYyQMZSSk7+4zhSUEh1lzE316LvY= X-Received: by 2002:a05:6102:114f:: with SMTP id j15mr24937375vsg.180.1588148542389; Wed, 29 Apr 2020 01:22:22 -0700 (PDT) MIME-Version: 1.0 References: <20190613142344.9188-1-nhorman@tuxdriver.com> <20200425105620.73021-1-haiyue.wang@intel.com> In-Reply-To: From: David Marchand Date: Wed, 29 Apr 2020 10:22:11 +0200 Message-ID: To: "Wang, Haiyue" Cc: dev , Thomas Monjalon , "Richardson, Bruce" , "Yigit, Ferruh" , Neil Horman , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v7 0/6] dpdk: introduce __rte_internal tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 25, 2020 at 8:10 PM Wang, Haiyue wrote: > > Hi David, > > > -----Original Message----- > > From: David Marchand > > Sent: Saturday, April 25, 2020 22:39 > > To: Wang, Haiyue > > Cc: dev ; Thomas Monjalon ; Richards= on, Bruce > > ; Yigit, Ferruh ; N= eil Horman > > ; Ray Kinsella > > Subject: Re: [PATCH v7 0/6] dpdk: introduce __rte_internal tag > > > > On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang wro= te: > > > > > > Move the internal function into INTERNAL session to avoid the ABI > > > checking, and it is only used for DPDK drivers or related library. > > > > > > __rte_internal funA > > > > > > INTERNAL { > > > global: > > > > > > funA > > > }; > > > > Thanks a lot for working on this. > > I did some modifications (see my replies on patch 3 and 5) and applied > > this series. > > > > We are just missing the update on the scripts mentioned in a previous m= ail. > > Can you work on this for rc2? > > > > Do you mean ? Sorry, I was referring to another mail: """ > We are missing updates on devtools/check-abi-version.sh and > devtools/update_version_map_abi.py. """ Those scripts devtools/check-abi-version.sh and devtools/update_version_map_abi.py are not "internal" aware. Can you take care of them? > > > > This will apply to common drivers that will be 100% internal. > > > > Not sure if this is an issue. > > > > > > This part should be fine, I want others to be aware of this. > > > I am not one of the ABI maintainers, but in my opinion it is OK > > to have "pure internal" libs with version 0.x. > > I've tested it with Intel's drivers/common/iavf, it works as expected. > a). librte_common_iavf.so.0.200.2 > b). Skipped experimental library librte_common_iavf.dump. > > This has been updated by your modification. > + if is_stable > lib_version =3D abi_version > so_version =3D stable_so_version > + else > + lib_version =3D experimental_abi_version > + so_version =3D experimental_so_version > endif Thanks for testing. --=20 David Marchand