From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02E51A034F; Fri, 12 Nov 2021 15:26:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 940144114D; Fri, 12 Nov 2021 15:26:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A71414113E for ; Fri, 12 Nov 2021 15:26:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636727185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=35/yNOO3IqnOW+6VP0TSlOi0THzuLspA/4zspbx4ZEw=; b=KJF5AM42ffUUq0ZTS0QroLKqF2rNvrnRxdtrkVVHR0Nw2eprchKmAE6YmRFm5/YfC+PBec YTMAb5f0Betas2Ci/OXisFw1c/8nrEhsNjBUgttwYB9qL1FHUPxaesJdbcgOTAE9hZx1rt 5YKBsVMtCqmljxd3yj2laQut5aHQMcY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-3lzZ35FJOf2AMQ2zgV_lYA-1; Fri, 12 Nov 2021 09:26:23 -0500 X-MC-Unique: 3lzZ35FJOf2AMQ2zgV_lYA-1 Received: by mail-lj1-f199.google.com with SMTP id h21-20020a05651c159500b00219132ab503so2887790ljq.12 for ; Fri, 12 Nov 2021 06:26:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=35/yNOO3IqnOW+6VP0TSlOi0THzuLspA/4zspbx4ZEw=; b=P0DxK6cxZP8fQXeVA3GiJ2WmBmpS9oJdXe2VfyGoUoNK/NAN6ANF5bLK9eO29x8GZI x1p30jCa+s7yOk+7NRDdfR6k3dPbJYsNU83CBBuxd6L6Trkh5gmpzsQLiScc5BMSyKBe jya73CivDkHaJPpuyJ+Ewkp9MzR/uzMu+W+QMDcqzdEFotwLCoFMa4zNFZ9Oef+5tO75 qpPZzr+OrJWQfkq5jPiNufI2EfcN3TYhfDsQDXmNSabZVi1CqifyBFdNx8cf+VphitbJ gZz4pIPkDSxytBPSYDMWoqKa/ocyZkNTluiIm3Ry+RQQ83gu352LdmVY4Cniw/uhxbqz 8AhA== X-Gm-Message-State: AOAM533mKsHMC/2xTEn02KkHFm8fJJKDpTO7ymeGDWdvo+5TmRW26VPA ZTRqK5KaQQRTH1UaUjVYs8f0ccSF3R1cRuO80plr4T/2u7SpAB00t6+eqbnTyLXflbGkznf0o1x fFd+y+EwyOoyjiOCO0tI= X-Received: by 2002:a2e:96c2:: with SMTP id d2mr15271197ljj.46.1636727182298; Fri, 12 Nov 2021 06:26:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJy+FaRhTZVT/T7Xq+MayUWEBWOmJTxXnMZz0f+xvfVAn6lblNHuzwifeeRkSngb95jgdt0XAucWGmjHnDF9neM= X-Received: by 2002:a2e:96c2:: with SMTP id d2mr15271145ljj.46.1636727182104; Fri, 12 Nov 2021 06:26:22 -0800 (PST) MIME-Version: 1.0 References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-8-conor.walsh@intel.com> In-Reply-To: From: David Marchand Date: Fri, 12 Nov 2021 15:26:11 +0100 Message-ID: Subject: Re: [PATCH 7/7] lib/power: fix unused but set variables To: "Walsh, Conor" Cc: "Yigit, Ferruh" , "Liang, LongfengX" , dev , "Hunt, David" , "Wang, Yipeng1" , "Gobriel, Sameh" , "Richardson, Bruce" , "Medvedkin, Vladimir" , Hemant Agrawal , Sachin Saxena , "Trahe, Fiona" , "Griffin, John" , "Jain, Deepak K" , "Van Haaren, Harry" , Ajit Khaparde , Somnath Kotur , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Shijith Thotton , Srisivasubramanian Srinivasan , "heinrich.kuhn@corigine.com" , Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , "Wang, Yong" , "Mcnamara, John" , Shreyansh Jain , "santosh.shukla@caviumnetworks.com" , Akhil Goyal , "Zhang, Roy Fan" , "Kusztal, ArkadiuszX" , "michael.baucom@broadcom.com" , Venkat Duvvuru , Lance Richardson , "kishore.padmanabha@broadcom.com" , Jerin Jacob , "derek.chickles@caviumnetworks.com" , "ssrinivasan@caviumnetworks.com" , "mjatharakonda@oneconvergence.com" , "simon.horman@corigine.com" , "david.george@sophos.com" , "sony.chacko@qlogic.com" , "harish.patil@qlogic.com" , Stephen Hemminger , Tomasz Kulasek , "ian.betts@intel.com" , Liang Ma , "lei.a.yao@intel.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Nov 12, 2021 at 3:17 PM Walsh, Conor wrote: > > Hi David, > > I will make those changes to the commit logs and respin them. > I'll also drop this patch from the set. These comments are trivial. We might get more substantial comments from drivers maintainers. I recommend waiting a bit before respinning. Thanks. -- David Marchand