From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D414343419; Fri, 1 Dec 2023 09:10:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AA9F0402B9; Fri, 1 Dec 2023 09:10:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 6311F402B6 for ; Fri, 1 Dec 2023 09:10:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701418231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+fLc5ftHH6D5jLfX9ODU1XYLxThHBY+2vjupQI11+uw=; b=TuIUNG0N+ilUdxel02QOdc655g3WCBtgl6pq8/JNAzZB/DuoV1Bb2MNuDgkeM+094h/Ztu nFMqGtNO+KsYqnOHwOot7Yv0dWIY0d7bMjWviZxc7nYVtjGqAeJ3/BM+sjSPVZzHFZkXFT 0N8vStoL3zH8sIv+XkBccSAArCIT7XQ= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-do9frmaXMwenb9-nhKd0LA-1; Fri, 01 Dec 2023 03:10:30 -0500 X-MC-Unique: do9frmaXMwenb9-nhKd0LA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c9c99a4fdbso18577361fa.0 for ; Fri, 01 Dec 2023 00:10:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701418229; x=1702023029; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fLc5ftHH6D5jLfX9ODU1XYLxThHBY+2vjupQI11+uw=; b=qvBwHFs7OAE12N2I1Lr0vWtnGVeFRrPn4FnVP6MmQLpJtyRCriN0Jf7IRnFUVVfVA1 NWyMcdG8eXtG00wDVws3Y00nJTLhTqNW46Rb7g9ciU4dY3Zs4AlyGY/9uWBHbOd+gttb f/QYNJazzgE6u6b9x09OwYpMGyNCunt4rMorfa/VGnwWnhDylEboJnmUKIYMYF1h322+ nrbIjtCGQ8pFX70APSgRpErqR1LfUc93EfETJrMwOHRvCzblva+fVzYmwDFy6zIB1HjG Gajb+woC3pxfQg70o6Pg0HuqmEQBEsNdyFjwTppffFGio7IIzQXHJEky5gZ27bj5876H xYmg== X-Gm-Message-State: AOJu0YxEetf5XzeGj6sC/GXrxb9HoChmvuY8FwucF1xT/Cw45m10QiBB YKwtWJcjA1EGOjUMhAp2cOrEnR5TGL+QgKfIHyoWVu/a5XF9xz3rSwpir2BVRWuLCkuaE34DxOB DlVxHWxjbWcvilsj+vHI= X-Received: by 2002:a05:651c:1053:b0:2c9:d874:6efd with SMTP id x19-20020a05651c105300b002c9d8746efdmr500578ljm.90.1701418229271; Fri, 01 Dec 2023 00:10:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGLZskJukB7vmlRvtSNiOS0ULs76xCaJfzqV+J665p8VN+1ZwFGXPUlGopbzGJ/nx2g+dm+ne9xswoHlac1RQQ= X-Received: by 2002:a05:651c:1053:b0:2c9:d874:6efd with SMTP id x19-20020a05651c105300b002c9d8746efdmr500567ljm.90.1701418228951; Fri, 01 Dec 2023 00:10:28 -0800 (PST) MIME-Version: 1.0 References: <20230208044825.1682620-1-stephen@networkplumber.org> <20230814163125.63033-1-stephen@networkplumber.org> <20230814163125.63033-2-stephen@networkplumber.org> In-Reply-To: <20230814163125.63033-2-stephen@networkplumber.org> From: David Marchand Date: Fri, 1 Dec 2023 09:10:17 +0100 Message-ID: Subject: Re: [PATCH v8 1/6] ip_frag: use a dynamic logtype To: Stephen Hemminger Cc: dev@dpdk.org, Konstantin Ananyev , Anatoly Burakov , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Aug 14, 2023 at 6:31=E2=80=AFPM Stephen Hemminger wrote: > @@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, uint32_= t bucket_entries, > if (rte_is_power_of_2(bucket_entries) =3D=3D 0 || > nb_entries > UINT32_MAX || nb_entries =3D=3D 0 || > nb_entries < max_entries) { > - RTE_LOG(ERR, USER1, "%s: invalid input parameter\n", __fu= nc__); > + RTE_LOG(ERR, IPFRAG, "%s: invalid input parameter\n", __f= unc__); > return NULL; > } > > sz =3D sizeof (*tbl) + nb_entries * sizeof (tbl->pkt[0]); > if ((tbl =3D rte_zmalloc_socket(__func__, sz, RTE_CACHE_LINE_SIZE= , > socket_id)) =3D=3D NULL) { > - RTE_LOG(ERR, USER1, > + RTE_LOG(ERR, IPFRAG, > "%s: allocation of %zu bytes at socket %d failed = do\n", > __func__, sz, socket_id); > return NULL; > } > > - RTE_LOG(INFO, USER1, "%s: allocated of %zu bytes at socket %d\n", > + RTE_LOG(INFO, IPFRAG, "%s: allocated of %zu bytes at socket %d\n"= , > __func__, sz, socket_id); > > tbl->max_cycles =3D max_cycles; > -- > 2.39.2 > Any reason not to use the IP_FRAG_LOG macro? This is easy for me to fix when applying if you have no objection. --=20 David Marchand