From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28D4B41C4D; Thu, 9 Feb 2023 10:04:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12AE0427F2; Thu, 9 Feb 2023 10:04:35 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 17AE740DF8 for ; Thu, 9 Feb 2023 10:04:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675933472; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=h4vd26nLLFnwkCFTL8cV3ZLwm178MYm2wWG1SdmEhPA=; b=cjLykjmi+wv84IIkpYQdN9as4lhF4xBXPgoJTOek2DHB6yxcOLFxIbx9GK+wwmBwjR2OsX BLexcj5JlC1uDKkCN2ORT09HIDCOi8tKlZuAVm9q4r0X8mjaPcqY+R+rU1VkJZl8OB2kOx 7HGFPDD+F+zvCkojDjsfA+r1+NEFpY4= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-8-qLGMoDvRPDedXfmcon6Whg-1; Thu, 09 Feb 2023 04:04:31 -0500 X-MC-Unique: qLGMoDvRPDedXfmcon6Whg-1 Received: by mail-pf1-f200.google.com with SMTP id cp14-20020a056a00348e00b005a858f5c99bso665278pfb.22 for ; Thu, 09 Feb 2023 01:04:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h4vd26nLLFnwkCFTL8cV3ZLwm178MYm2wWG1SdmEhPA=; b=jJlvT/qHs3Eto6/J9ysHc1i+Pi7294tHm4so76XdMDJyXQH19l3I1vMY1Jn0dxa2MA TvxUUcigFKYCtp2PPXJqlquifQREIIcUPsUs6ZfXRnRn8phjeur71DKijlkbpz4kCN+r tGpe86/kyyT6HXdeiSva9LVeHJ3K7YHn5YfpTC0BIe1BVeNXLN11VIlaRuml+0XKaIG/ hTR22lUqF12QXBuijk90/9xw9v7llWYuqpLM8tlW/b7UTtN7moO0k9TQKKi+pHHCBbKU 2meARJACzwG5DevhBMwMRrcVOGRwR2MeA68be76fOYYO6YoAdd1r0ozdwdhlJLWOR8F+ muNQ== X-Gm-Message-State: AO0yUKXP2vE8tBXf90Rq6+a5hTw3PI3Mi012R5FxjRWUSPOnhdNdyJ1U /I2h2Gdc9BKnPDWtY2axlbknBie2qQvcbd7LLfs85TKA/NQ0ZzhwF9AAbnjoq+7V5jHRIn/2LTz HYVn4MFM9+FhrHB/aFOQ= X-Received: by 2002:a17:90a:8592:b0:230:b57f:5229 with SMTP id m18-20020a17090a859200b00230b57f5229mr1566732pjn.68.1675933470283; Thu, 09 Feb 2023 01:04:30 -0800 (PST) X-Google-Smtp-Source: AK7set+dL5nNrRHelLzE87GMaIHZwKEnuZsWEUxCc1J/ZenJaPZXagb84bM0coOr7++AGOMKo8SV8aGh44TeUvpfDg4= X-Received: by 2002:a17:90a:8592:b0:230:b57f:5229 with SMTP id m18-20020a17090a859200b00230b57f5229mr1566722pjn.68.1675933470007; Thu, 09 Feb 2023 01:04:30 -0800 (PST) MIME-Version: 1.0 References: <20230206105311.9577-1-fengchengwen@huawei.com> <20230206105311.9577-2-fengchengwen@huawei.com> In-Reply-To: <20230206105311.9577-2-fengchengwen@huawei.com> From: David Marchand Date: Thu, 9 Feb 2023 10:04:18 +0100 Message-ID: Subject: Re: [PATCH 1/2] eal: fix mmap fail regarded as success To: Chengwen Feng Cc: thomas@monjalon.net, ferruh.yigit@amd.com, Bruce Richardson , Anatoly Burakov , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Feb 6, 2023 at 11:59 AM Chengwen Feng wrote: > > The map_shared_memory() function should treat mmap MAP_FAILED as NULL > because callers compare it with NULL to determine whether the map is > failed. > > Fixes: 764bf26873b9 ("add FreeBSD support") > Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng Reviewed-by: David Marchand -- David Marchand