From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ED09A0579; Fri, 9 Apr 2021 15:27:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EDB5140FBE; Fri, 9 Apr 2021 15:27:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E6996140FBD for ; Fri, 9 Apr 2021 15:27:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617974865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UxMijN0HKNHTsN/HEe/7Ga1F4xedtli+6+P7C/1GIr8=; b=JtyVxSL1aKxWmQKnER6fuhWu/yw9AzsK4ePLoDjrLhvNIf9cyaJjH7sNbk0OcxMsVA3yJN Hi9EGLbxUGaLwNtUFqYvPxWU6khQGt56MMfkKbN3wjUhl/XbUk1tiCHjo28dFOXnV4Yx6D kWGZPblkR1q4ckw2WEP0IQZ/O/egT/0= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-324-KvLSs4qaP3u1mmlr_wAN9w-1; Fri, 09 Apr 2021 09:27:44 -0400 X-MC-Unique: KvLSs4qaP3u1mmlr_wAN9w-1 Received: by mail-vs1-f69.google.com with SMTP id g21so635450vso.20 for ; Fri, 09 Apr 2021 06:27:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UxMijN0HKNHTsN/HEe/7Ga1F4xedtli+6+P7C/1GIr8=; b=OxCKtZxEPr/VlBiYPlHpDVaflFRvbbvlfCgbExquOyZbFegYdt92VInE+PBLlehxPL lE4p4g+A+4m9Cuw6zw1gZxPUbR0ThYilP0AthJEiJHFd2ZrU/smivn9jxezQEoUWhKdT 5J54GRJocY/LWPULH3zsOIMqaSYb6Ycwnl8xnJ7LcYIrdm4ybgSgnQHaRca9uWdW/B/s 89qPw6oITGXswSsbkFx2VCLsEKggs/6JBjQp5u3P0Z2alsPPn9r26oyMbfAo4vjYnz68 Bbbj/bwmMGaeJV3rzY91n3gFk7Pgt35EIsgwwjYxTEDQuTwgB7FE00gmk93MI+8MdWQH tA6Q== X-Gm-Message-State: AOAM533+goJOlifHQicRJfpjgdr4XabCCDOXyjXpc+q6DOvOtqhH1JV6 0/NoNhc60d0Sy5Q+rvBh0xgyyLs1Zr3pAGfSKUTvOmf9YWNDGfu1+pr30/zK3U48pOoiAvDUET0 0W7lYepiVut9EVtrP8Hg= X-Received: by 2002:a67:efd4:: with SMTP id s20mr8899188vsp.27.1617974863031; Fri, 09 Apr 2021 06:27:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnu7qK6wUZVtcgtNaMJml1TSiRqV1FLOVrxjTsHnu8QhtN32KwQYIgLgx5noRd+a+LhbYUq0UXi767RXRv7hw= X-Received: by 2002:a67:efd4:: with SMTP id s20mr8899161vsp.27.1617974862818; Fri, 09 Apr 2021 06:27:42 -0700 (PDT) MIME-Version: 1.0 References: <20210308222410.819751-1-thomas@monjalon.net> <9c5f5e42-6bda-56ac-cf4e-fe449e945113@intel.com> In-Reply-To: <9c5f5e42-6bda-56ac-cf4e-fe449e945113@intel.com> From: David Marchand Date: Fri, 9 Apr 2021 15:27:31 +0200 Message-ID: To: Thomas Monjalon Cc: dev , "Burakov, Anatoly" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] vfio: reformat logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 1, 2021 at 1:25 PM Burakov, Anatoly wrote: > > On 08-Mar-21 10:24 PM, Thomas Monjalon wrote: > > The log messages had various issues: > > - split on 2 lines, making search (grep) difficult > > - long lines (can be split after the string) > > - indented for no good reason (parent message may have higher log level) > > - inconsistent use of __func__, not meaningful context for user > > - lack of context (general message not mentioning VFIO) > > - log level too high (more below) > > > > Message having its level decreased from WARNING to NOTICE: > > "not managed by VFIO driver, skipping" > > Message having its level decreased from INFO to DEBUG: > > "Probing VFIO support..." > > > > Signed-off-by: Thomas Monjalon > Acked-by: Anatoly Burakov Applied, thanks. -- David Marchand