From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A03E463BD; Fri, 14 Mar 2025 18:40:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C15A400D6; Fri, 14 Mar 2025 18:40:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E808400D5 for ; Fri, 14 Mar 2025 18:40:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741974012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltHdlUdyWJ42LTKxh1EdpUq8w+qWe4Qo66SMsXd8xMo=; b=h+XaeMVvP5o/CCnIL/MTapKPZcZDllEaw3UL9xGsRv89KKmPNwFzrZwN9aiK4U2KTJrzgJ ySF7nSjALRwHCm2ucFXFykK93bS7wSbpg9Lb3b1cN7lR06k7p8hw/XFseLBzEngkn4MwQq RJTX6EZ0Eb/RlvHaUArnyCJ9dEzQRG8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-SpbTPs1jNnKBzpwuu0nYzA-1; Fri, 14 Mar 2025 13:40:09 -0400 X-MC-Unique: SpbTPs1jNnKBzpwuu0nYzA-1 X-Mimecast-MFC-AGG-ID: SpbTPs1jNnKBzpwuu0nYzA_1741974008 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5499a93f894so2051955e87.1 for ; Fri, 14 Mar 2025 10:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741974007; x=1742578807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltHdlUdyWJ42LTKxh1EdpUq8w+qWe4Qo66SMsXd8xMo=; b=A2ICV1VSLzsr10m7hYTPUeFriymV94TM0zyEsLeT3AnI0/k6SNfAID10eQr1dRQcJ0 ytkT7Nawq6vOQxhyXOwEj2gUiB1KJXrW9wPClsud/Ckq/5aBrKZ2ctwmf5HZT4AVTOpL GmIyYDxIebxkGNmgaRSsbVOBfTdgSBFu6Ck5jydZUg4MEsi1G7Ie+dwvx+hrHvsc41w/ a1ZpK6eoM6mvawLxkJgTG94+0KvT0LwOr15OJRh2yta73n+LmTYvfyaMr26K1dBfEnc+ fmyT8Bqa9j0YKP89H7xZga3hqGAipABsDUko1O4Wv7XkzI9YmyHhRy4mG0UToACdzstE dJvg== X-Gm-Message-State: AOJu0YyjM6tRRlP51hEF2F7u87rULkl8vlB+oQoxwsRdvkuz1bYq7N7W fkPdamhC55E+kTqRvmG9fZz8o19oD+Wh065yh3tpd1BZEgGeuz3VaqDrSSqJdi9v+WScsrml41U sRgv+6VWVkvCh0+6FzErAt2MRL/sRwWaIUHlAszbxzmh9302lXL12qX+DN5wF57tnoTDd+nfQay DuYLHt96YOY2rUiog= X-Gm-Gg: ASbGncvjU6l5CCziboplHSGxJH+UMrkMb/SnT7QmhZ0K3b5QDFgLWVv0x5QdYZAqYUf +uoBuKg+uySzgeO1uFE47jRb4lCfxk2cY7lqo4aEwDBVsWZoH/6+MhHEIxzk1NTC6kLawWrOSSq g= X-Received: by 2002:a05:6512:3e1e:b0:549:8dd6:fb41 with SMTP id 2adb3069b0e04-549ba44cc1amr3263320e87.24.1741974007336; Fri, 14 Mar 2025 10:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRGKZPpblarKhnwkfWiZnTKR3QSs7TRzqqb+m+I3hZvDSElBO5rOtUEJ1VU2J4899tsr8k+s/JroF0G5YASVc= X-Received: by 2002:a05:6512:3e1e:b0:549:8dd6:fb41 with SMTP id 2adb3069b0e04-549ba44cc1amr3263253e87.24.1741974006882; Fri, 14 Mar 2025 10:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20250305212349.2036410-1-david.marchand@redhat.com> <20250311095609.194523-1-david.marchand@redhat.com> <20250311095609.194523-7-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 14 Mar 2025 18:39:54 +0100 X-Gm-Features: AQ5f1JpEWFccSfmsegDt2npFMhGkU0kfsODgx2bo-Hb9S1FEESNB2lh1W2O-P6Y Message-ID: Subject: Re: [RFC v3 6/8] build: mark exported symbols To: Bruce Richardson Cc: dev@dpdk.org, thomas@monjalon.net, andremue@linux.microsoft.com, Nicolas Chautru , Parav Pandit , Xueming Li , Nipun Gupta , Nikhil Agarwal , Hemant Agrawal , Sachin Saxena , Rosen Xu , Chenbo Xia , Tomasz Duszynski , Chengwen Feng , Long Li , Wei Hu , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Anoob Joseph , Andrew Boyer , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad , Liron Himi , Chaoyong He , Nagadheeraj Rottela , Srikanth Jampala , Andrew Rybchenko , Ankur Dwivedi , Tejasree Kondoj , Gagandeep Singh , Kai Ji , Vamsi Attunuru , Pavan Nikhilesh , Shijith Thotton , Pravin Pathak , Ashwin Sekhar T K , Igor Russkikh , Ajit Khaparde , Somnath Kotur , Chas Williams , "Min Hu (Connor)" , Ian Stokes , Vladimir Medvedkin , Anatoly Burakov , Jingjing Wu , Praveen Shetty , Cristian Dumitrescu , Maxime Coquelin , David Hunt , Sivaprasad Tummala , Akhil Goyal , Konstantin Ananyev , Fan Zhang , Ashish Gupta , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Kevin Laatz , Wathsala Vithanage , Tyler Retzlaff , Jerin Jacob , Harry van Haaren , Min Zhou , David Christensen , Stanislaw Kardach , Dmitry Kozlyuk , Byron Marohn , Yipeng Wang , Ferruh Yigit , Abhinandan Gujjar , Amit Prakash Shukla , Naga Harish K S V , Erik Gabriel Carrillo , Elena Agostini , Zhirun Yan , Jiayu Hu , Sameh Gobriel , Reshma Pattan , Stephen Hemminger , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Srikanth Yalavarthi , Jasvinder Singh , Gaetan Rivet , Volodymyr Fialko , Honnappa Nagarahalli X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g_E5HiFbXXhu0nGEXsIoRxVdsVEmVPfz-bQMHu8QDUM_1741974008 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 14, 2025 at 6:29=E2=80=AFPM Bruce Richardson wrote: > > > What I'd actually like more, but never have had time to actually try = out is > > > to generalise the instruction-set-specific build stuff into the highe= r level > > > drivers/meson.build code. After all, much of the code for doing so is= just > > > duplicated - check for AVX512 or AVX2 and if present build these file= s with > > > the extra flags for that instruction set. > > > > > > Something similar with the base code. Most base code builds follow pr= etty > > > much the exact same routine. > > > > Having those separate libraries require special cases every time, so > > yes, it would be great if those could be factored in some shared > > mechanism in drivers/meson.build. > > > > Putting the AVX stuff aside, and back to why we need those separate > > libraries for base drivers... I think the main use is to waive some > > build warnings, is there something else? > > If so.. I think some drivers could already be cleaned (like net/e1000, > > net/ngbe, net/octeontx, net/thunderx, net/txgbe, raw/ifpga at a first > > glance). > > > > The AVX stuff seems a bit more complex, as there are multiple combinati= ons... > > > > First attempt seems to go surprisingly smoothly[1]. It still builds, whic= h is > a start, though obviously some testing will be needed to check nothing el= se > is broken. If it builds.. what more to ask for? :-) > It really helped that most code just seemed to have been copy-pasted arou= nd > the place. I had a quick look, it lgtm on the principle. Could this be applied to lib/ ? (I see some complications with AVX512 special instructions in lib/net..). --=20 David Marchand