From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A03E463BD; Fri, 14 Mar 2025 18:40:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C15A400D6; Fri, 14 Mar 2025 18:40:14 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E808400D5 for <dev@dpdk.org>; Fri, 14 Mar 2025 18:40:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741974012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ltHdlUdyWJ42LTKxh1EdpUq8w+qWe4Qo66SMsXd8xMo=; b=h+XaeMVvP5o/CCnIL/MTapKPZcZDllEaw3UL9xGsRv89KKmPNwFzrZwN9aiK4U2KTJrzgJ ySF7nSjALRwHCm2ucFXFykK93bS7wSbpg9Lb3b1cN7lR06k7p8hw/XFseLBzEngkn4MwQq RJTX6EZ0Eb/RlvHaUArnyCJ9dEzQRG8= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-SpbTPs1jNnKBzpwuu0nYzA-1; Fri, 14 Mar 2025 13:40:09 -0400 X-MC-Unique: SpbTPs1jNnKBzpwuu0nYzA-1 X-Mimecast-MFC-AGG-ID: SpbTPs1jNnKBzpwuu0nYzA_1741974008 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5499a93f894so2051955e87.1 for <dev@dpdk.org>; Fri, 14 Mar 2025 10:40:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741974007; x=1742578807; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltHdlUdyWJ42LTKxh1EdpUq8w+qWe4Qo66SMsXd8xMo=; b=A2ICV1VSLzsr10m7hYTPUeFriymV94TM0zyEsLeT3AnI0/k6SNfAID10eQr1dRQcJ0 ytkT7Nawq6vOQxhyXOwEj2gUiB1KJXrW9wPClsud/Ckq/5aBrKZ2ctwmf5HZT4AVTOpL GmIyYDxIebxkGNmgaRSsbVOBfTdgSBFu6Ck5jydZUg4MEsi1G7Ie+dwvx+hrHvsc41w/ a1ZpK6eoM6mvawLxkJgTG94+0KvT0LwOr15OJRh2yta73n+LmTYvfyaMr26K1dBfEnc+ fmyT8Bqa9j0YKP89H7xZga3hqGAipABsDUko1O4Wv7XkzI9YmyHhRy4mG0UToACdzstE dJvg== X-Gm-Message-State: AOJu0YyjM6tRRlP51hEF2F7u87rULkl8vlB+oQoxwsRdvkuz1bYq7N7W fkPdamhC55E+kTqRvmG9fZz8o19oD+Wh065yh3tpd1BZEgGeuz3VaqDrSSqJdi9v+WScsrml41U sRgv+6VWVkvCh0+6FzErAt2MRL/sRwWaIUHlAszbxzmh9302lXL12qX+DN5wF57tnoTDd+nfQay DuYLHt96YOY2rUiog= X-Gm-Gg: ASbGncvjU6l5CCziboplHSGxJH+UMrkMb/SnT7QmhZ0K3b5QDFgLWVv0x5QdYZAqYUf +uoBuKg+uySzgeO1uFE47jRb4lCfxk2cY7lqo4aEwDBVsWZoH/6+MhHEIxzk1NTC6kLawWrOSSq g= X-Received: by 2002:a05:6512:3e1e:b0:549:8dd6:fb41 with SMTP id 2adb3069b0e04-549ba44cc1amr3263320e87.24.1741974007336; Fri, 14 Mar 2025 10:40:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRGKZPpblarKhnwkfWiZnTKR3QSs7TRzqqb+m+I3hZvDSElBO5rOtUEJ1VU2J4899tsr8k+s/JroF0G5YASVc= X-Received: by 2002:a05:6512:3e1e:b0:549:8dd6:fb41 with SMTP id 2adb3069b0e04-549ba44cc1amr3263253e87.24.1741974006882; Fri, 14 Mar 2025 10:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20250305212349.2036410-1-david.marchand@redhat.com> <20250311095609.194523-1-david.marchand@redhat.com> <20250311095609.194523-7-david.marchand@redhat.com> <Z9MWQR_o3m4T_rFt@bricha3-mobl1.ger.corp.intel.com> <CAJFAV8w0MPV7XQpMyiGTsSVDGuW1LctGyrXZ6n52O7AYzij7Zw@mail.gmail.com> <Z9RYCXF6Ag23k8Uy@bricha3-mobl1.ger.corp.intel.com> <CAJFAV8zsgxW7goppOjNariu_oA+ET5HeNTOeepDSHsE31KmkNA@mail.gmail.com> <Z9RnNPIKpBD5Oz0Y@bricha3-mobl1.ger.corp.intel.com> In-Reply-To: <Z9RnNPIKpBD5Oz0Y@bricha3-mobl1.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Fri, 14 Mar 2025 18:39:54 +0100 X-Gm-Features: AQ5f1JpEWFccSfmsegDt2npFMhGkU0kfsODgx2bo-Hb9S1FEESNB2lh1W2O-P6Y Message-ID: <CAJFAV8wrmuhn-nsiDc+RrCqth13hjyrubhqcZK17mqpDaDVuWw@mail.gmail.com> Subject: Re: [RFC v3 6/8] build: mark exported symbols To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, thomas@monjalon.net, andremue@linux.microsoft.com, Nicolas Chautru <nicolas.chautru@intel.com>, Parav Pandit <parav@nvidia.com>, Xueming Li <xuemingl@nvidia.com>, Nipun Gupta <nipun.gupta@amd.com>, Nikhil Agarwal <nikhil.agarwal@amd.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com>, Rosen Xu <rosen.xu@intel.com>, Chenbo Xia <chenbox@nvidia.com>, Tomasz Duszynski <tduszynski@marvell.com>, Chengwen Feng <fengchengwen@huawei.com>, Long Li <longli@microsoft.com>, Wei Hu <weh@microsoft.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>, Harman Kalra <hkalra@marvell.com>, Anoob Joseph <anoobj@marvell.com>, Andrew Boyer <andrew.boyer@amd.com>, Dariusz Sosnowski <dsosnowski@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>, Matan Azrad <matan@nvidia.com>, Liron Himi <lironh@marvell.com>, Chaoyong He <chaoyong.he@corigine.com>, Nagadheeraj Rottela <rnagadheeraj@marvell.com>, Srikanth Jampala <jsrikanth@marvell.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ankur Dwivedi <adwivedi@marvell.com>, Tejasree Kondoj <ktejasree@marvell.com>, Gagandeep Singh <g.singh@nxp.com>, Kai Ji <kai.ji@intel.com>, Vamsi Attunuru <vattunuru@marvell.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, Shijith Thotton <sthotton@marvell.com>, Pravin Pathak <pravin.pathak@intel.com>, Ashwin Sekhar T K <asekhar@marvell.com>, Igor Russkikh <irusskikh@marvell.com>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com>, Chas Williams <chas3@att.com>, "Min Hu (Connor)" <humin29@huawei.com>, Ian Stokes <ian.stokes@intel.com>, Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Anatoly Burakov <anatoly.burakov@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Praveen Shetty <praveen.shetty@intel.com>, Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Maxime Coquelin <maxime.coquelin@redhat.com>, David Hunt <david.hunt@intel.com>, Sivaprasad Tummala <sivaprasad.tummala@amd.com>, Akhil Goyal <gakhil@marvell.com>, Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>, Fan Zhang <fanzhang.oss@gmail.com>, Ashish Gupta <ashish.gupta@marvell.com>, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>, Kevin Laatz <kevin.laatz@intel.com>, Wathsala Vithanage <wathsala.vithanage@arm.com>, Tyler Retzlaff <roretzla@linux.microsoft.com>, Jerin Jacob <jerinj@marvell.com>, Harry van Haaren <harry.van.haaren@intel.com>, Min Zhou <zhoumin@loongson.cn>, David Christensen <drc@linux.ibm.com>, Stanislaw Kardach <stanislaw.kardach@gmail.com>, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Byron Marohn <byron.marohn@intel.com>, Yipeng Wang <yipeng1.wang@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Abhinandan Gujjar <abhinandan.gujjar@intel.com>, Amit Prakash Shukla <amitprakashs@marvell.com>, Naga Harish K S V <s.v.naga.harish.k@intel.com>, Erik Gabriel Carrillo <erik.g.carrillo@intel.com>, Elena Agostini <eagostini@nvidia.com>, Zhirun Yan <yanzhirun_163@163.com>, Jiayu Hu <hujiayu.hu@foxmail.com>, Sameh Gobriel <sameh.gobriel@intel.com>, Reshma Pattan <reshma.pattan@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>, Srikanth Yalavarthi <syalavarthi@marvell.com>, Jasvinder Singh <jasvinder.singh@intel.com>, Gaetan Rivet <grive@u256.net>, Volodymyr Fialko <vfialko@marvell.com>, Honnappa Nagarahalli <honnappa.nagarahalli@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: g_E5HiFbXXhu0nGEXsIoRxVdsVEmVPfz-bQMHu8QDUM_1741974008 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Fri, Mar 14, 2025 at 6:29=E2=80=AFPM Bruce Richardson <bruce.richardson@intel.com> wrote: > > > What I'd actually like more, but never have had time to actually try = out is > > > to generalise the instruction-set-specific build stuff into the highe= r level > > > drivers/meson.build code. After all, much of the code for doing so is= just > > > duplicated - check for AVX512 or AVX2 and if present build these file= s with > > > the extra flags for that instruction set. > > > > > > Something similar with the base code. Most base code builds follow pr= etty > > > much the exact same routine. > > > > Having those separate libraries require special cases every time, so > > yes, it would be great if those could be factored in some shared > > mechanism in drivers/meson.build. > > > > Putting the AVX stuff aside, and back to why we need those separate > > libraries for base drivers... I think the main use is to waive some > > build warnings, is there something else? > > If so.. I think some drivers could already be cleaned (like net/e1000, > > net/ngbe, net/octeontx, net/thunderx, net/txgbe, raw/ifpga at a first > > glance). > > > > The AVX stuff seems a bit more complex, as there are multiple combinati= ons... > > > > First attempt seems to go surprisingly smoothly[1]. It still builds, whic= h is > a start, though obviously some testing will be needed to check nothing el= se > is broken. If it builds.. what more to ask for? :-) > It really helped that most code just seemed to have been copy-pasted arou= nd > the place. I had a quick look, it lgtm on the principle. Could this be applied to lib/ ? (I see some complications with AVX512 special instructions in lib/net..). --=20 David Marchand