From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3577CA053A; Wed, 5 Aug 2020 11:19:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EAE631BFFA; Wed, 5 Aug 2020 11:19:57 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 278142BB5 for ; Wed, 5 Aug 2020 11:19:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596619196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bknj4P0Bs5MhoohhFrprAxBE24Omv4lI/RlloGW2Nc8=; b=WNpLJNIAknceMaD8P8K6U/Ue7/GaW5QLogrHs9MkogGzGW+D/699lHGLV7L+0ix8CZAOCN rkOu2M6vAN2Bmka/Dlmc+pxe4U7RhOY47XXr+dIYmiRBfGuv/tAvBy8/LUgcFxuDQmtVeC b4lYnNscvTN9qVl1nL0D3ElomgW+qNI= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-372-T_hjmnXWPVWinOI63qgh8Q-1; Wed, 05 Aug 2020 05:19:55 -0400 X-MC-Unique: T_hjmnXWPVWinOI63qgh8Q-1 Received: by mail-ot1-f69.google.com with SMTP id w14so5238978otj.1 for ; Wed, 05 Aug 2020 02:19:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Bknj4P0Bs5MhoohhFrprAxBE24Omv4lI/RlloGW2Nc8=; b=dwfJq75az7thONHcbU3HkY37Qp7oRcjnAv5HcFwdEVoUeISFTvJskbeWyzJaDGL3Ns saB+k34GkNKRNFJFIyLkuj15PjT5KF8LDWOnVbao9MYyfs3+YsyGUuY3iaYkYb3s3uTM PDmu+3PyLvAZseneJObmI1iPe3BscuNezhhVdhKMoJh3G5eCa1fS2HrEIMnIVg4FuC5Y bD+rJikcNNeLazPk01nZ7oVWA43GvbN95RaXtg4C5zKNw0yZ/75Z6TQd3wHG6iE/KdF/ /FBYvMJcPX8I5o/ApUoPwjkYgAn6RvNirNaA+yTOPWQ10q4z9ORcHv8ZDWaWySvjE4W6 mU9Q== X-Gm-Message-State: AOAM531YXSVQVmcdpakIgi5MxxuxgJ9C27625hptDRpBTwzWII+/9s1k 5dbqccepbl6oOB5cCy+Q5Dxs0qultj6gYOHI/LHKg04mCd8m2n+bRMnLXvQ4G5NlojlkCIByC87 lD7vBDrFOF8Z1crUIEtc= X-Received: by 2002:a9d:6e19:: with SMTP id e25mr1904772otr.198.1596619194244; Wed, 05 Aug 2020 02:19:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0j8T7yOxXyT+Y0doeqjEdBsfiCkxZgcDdCK952oMBOfsTpv25hl8daWhi0lSIu7R2PU597V+DoAJ2ZooXIXY= X-Received: by 2002:a9d:6e19:: with SMTP id e25mr1904761otr.198.1596619193970; Wed, 05 Aug 2020 02:19:53 -0700 (PDT) MIME-Version: 1.0 References: <20200804094120.3338635-1-thomas@monjalon.net> <20200804094808.3339810-1-thomas@monjalon.net> In-Reply-To: <20200804094808.3339810-1-thomas@monjalon.net> From: David Marchand Date: Wed, 5 Aug 2020 11:19:42 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Ferruh Yigit , Andrew Rybchenko X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] ethdev: remove device-specific comments from VLAN API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Aug 4, 2020 at 11:48 AM Thomas Monjalon wrote: > > Some confusing comments were still present from old days, > when most drivers were from Intel. > > Signed-off-by: Thomas Monjalon > --- > v2: remove i40e comment for pvid field > --- > lib/librte_ethdev/rte_ethdev.h | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 57e4a6ca58..d29930fd84 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -924,7 +924,6 @@ struct rte_eth_txmode { > */ > uint64_t offloads; > > - /* For i40e specifically */ > uint16_t pvid; > __extension__ > uint8_t hw_vlan_reject_tagged : 1, > @@ -2846,7 +2845,6 @@ int rte_eth_dev_vlan_filter(uint16_t port_id, uint16_t vlan_id, int on); > > /** > * Enable/Disable hardware VLAN Strip by a rx queue of an Ethernet device. > - * 82599/X540/X550 can support VLAN stripping at the rx queue level > * > * @param port_id > * The port identifier of the Ethernet device. > @@ -2868,8 +2866,7 @@ int rte_eth_dev_set_vlan_strip_on_queue(uint16_t port_id, uint16_t rx_queue_id, > > /** > * Set the Outer VLAN Ether Type by an Ethernet device, it can be inserted to > - * the VLAN Header. This is a register setup available on some Intel NIC, not > - * but all, please check the data sheet for availability. > + * the VLAN header. > * > * @param port_id > * The port identifier of the Ethernet device. > @@ -2888,12 +2885,7 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t port_id, > uint16_t tag_type); > > /** > - * Set VLAN offload configuration on an Ethernet device > - * Enable/Disable Extended VLAN by an Ethernet device, This is a register setup > - * available on some Intel NIC, not but all, please check the data sheet for > - * availability. > - * Enable/Disable VLAN Strip can be done on rx queue for certain NIC, but here > - * the configuration is applied on the port level. > + * Set VLAN offload configuration on an Ethernet device. > * > * @param port_id > * The port identifier of the Ethernet device. Reviewed-by: David Marchand -- David Marchand