From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EC6DA04B8; Tue, 5 May 2020 16:53:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 896F61D160; Tue, 5 May 2020 16:53:55 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 6590D1D15E for ; Tue, 5 May 2020 16:53:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588690433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8OdBAi2Ld3xLtSwOnA0i6zuV4V59WNg3pE7VJvRiS4=; b=PGhV5G0/iZlz9zMp8IlVGbfyXyGzb+Ov4DcA1wWBU919+uCMaH6Wi0IpNwb/68fCdOS8Q8 GQ7Knj7/B1QX/QvTyW54vGLqG55tCQbq0aqucivBAOqCQXayXjsUbL9dnltZC5QmrJo+di GBPtUQFmmZjF2za+/ufJ1GUfFKL8RRk= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-257-144Uwk46MiGCpGLvXStKmA-1; Tue, 05 May 2020 10:53:52 -0400 X-MC-Unique: 144Uwk46MiGCpGLvXStKmA-1 Received: by mail-vs1-f70.google.com with SMTP id l191so536793vsd.22 for ; Tue, 05 May 2020 07:53:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P8Iw8R0pt8pnpycsEf5+rjEVJzUOEqcqg2UQNoPHCyc=; b=Qmc5+IJ01oT+fW9zEbozI5Ec9IhaUAU7/gMkvAEBMBrunWhUgtfTVCO53W0MnAw8cM 6AB+El5f+4OwBPHaNoTjOIA7g7xk8nXNml06xqOi70zxl3vziRRcQ9VVriHJF82sxm9O OgZAXczpdOncVk2ZAOxKuAbE+1EMybmBmFJIi6X3K42RKnRrcaa6dooH8G3JQFMT9kO1 ByFm+yfaNEq87GT7VzXk2LCbTOoyZwQ4WxubmxE60DSidjZK3wnJqXlQbCFmFDO9flaC hhFLPFrnH90kTIAGWeLV3nVv/C7IzN5jzCs9K5T+44gC4UrbKdkeuGs8EOHNppYb+yAq RP5w== X-Gm-Message-State: AGi0PuYv9/pzo6NKdsQBEm1jKhOxtG9VioRtx7Yscuq8OuaF3rz+Cbqb aY0B8qHLCoCMSRTq0dm5/ZUU6hU+YHjxq5IOpbwzxPEhWXzY11SlpkhFCYZs/YyN+4Eu+AsoJes kxbGB3kAiB0LIyl8ck5s= X-Received: by 2002:ab0:5586:: with SMTP id v6mr2524913uaa.87.1588690431716; Tue, 05 May 2020 07:53:51 -0700 (PDT) X-Google-Smtp-Source: APiQypIt5pM/2ygW0c5Mu3Y4nSgQbYsVJW9JkPhM08G5an0OKFmEZ/v0/Vbc4+f5VBMloLqAuaQIidDDk0/fJBfvZaU= X-Received: by 2002:ab0:5586:: with SMTP id v6mr2524882uaa.87.1588690431318; Tue, 05 May 2020 07:53:51 -0700 (PDT) MIME-Version: 1.0 References: <20200505112057.20901-1-ophirmu@mellanox.com> In-Reply-To: <20200505112057.20901-1-ophirmu@mellanox.com> From: David Marchand Date: Tue, 5 May 2020 16:53:40 +0200 Message-ID: To: Ophir Munk Cc: dev , Raslan Darawsheh , Matan Azrad , Neil Horman , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v1 1/3] devtools: create internal ignore file for libabigail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Don't forget to Cc: Ray. On Tue, May 5, 2020 at 1:21 PM Ophir Munk wrote: > > Create file libabigail.internalignore where it is specified to ignore > all symbols in library file librte_pmd_mlx.* during an ABI check. I don't like the separate file, having rules with comments in a single place is easier to maintain. Why waive all changes in all mlx drivers? There is a single issue with 20.02, see below. Besides, looking at next patches, why keep experimental symbols? If all symbols in common/mlx5 are for internal use, mark them _all_ as such= . > > Signed-off-by: Ophir Munk > --- > devtools/check-abi.sh | 4 +++- > devtools/libabigail.internalignore | 4 ++++ > 2 files changed, 7 insertions(+), 1 deletion(-) > create mode 100644 devtools/libabigail.internalignore > > diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh > index dd9120e..3bad19a 100755 > --- a/devtools/check-abi.sh > +++ b/devtools/check-abi.sh > @@ -10,7 +10,9 @@ fi > refdir=3D$1 > newdir=3D$2 > warnonly=3D${3:-} > -ABIDIFF_OPTIONS=3D"--suppr $(dirname $0)/libabigail.abignore --no-added-= syms" > +ABIDIFF_OPTIONS=3D"--suppr $(dirname $0))/libabigail.abignore" \ > + " --suppr $(dirname $0))/libabigail.internalignore" \ > + " --no-added-syms" > > if [ ! -d $refdir ]; then > echo "Error: reference directory '$refdir' does not exist." > diff --git a/devtools/libabigail.internalignore b/devtools/libabigail.int= ernalignore > new file mode 100644 > index 0000000..55df5b1 > --- /dev/null > +++ b/devtools/libabigail.internalignore > @@ -0,0 +1,4 @@ > +; These functions were moved from stable to internal. > +; This is a temporary exception till DPDK 20.11. This is not until 20.11 if we merge this patch now. It is only when comparing 20.02 to 20.05. After this, symbols will be marked INTERNAL and will be skipped by the generic rule, so we can remove this exception in 20.08-rc0. > +[suppress_file] > + file_name_regexp =3D librte*mlx5* > -- > 2.8.4 A stricter rule is enough, can you try something like: +[suppress_file] + file_name_regexp =3D ^librte_common_mlx5\. --=20 David Marchand