From: David Marchand <david.marchand@redhat.com>
To: Conor Walsh <conor.walsh@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
longfengx.liang@intel.com, dev <dev@dpdk.org>,
David Hunt <david.hunt@intel.com>,
"Wang, Yipeng1" <yipeng1.wang@intel.com>,
"Gobriel, Sameh" <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@oss.nxp.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
John Griffin <john.griffin@intel.com>,
Deepak Kumar Jain <deepak.k.jain@intel.com>,
Van Haaren Harry <harry.van.haaren@intel.com>,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Ziyang Xuan <xuanziyang2@huawei.com>,
Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
Guoyang Zhou <zhouguoyang@huawei.com>,
Shijith Thotton <sthotton@marvell.com>,
Srisivasubramanian Srinivasan <srinivasan@marvell.com>,
heinrich.kuhn@corigine.com, Harman Kalra <hkalra@marvell.com>,
Rasesh Mody <rmody@marvell.com>,
Devendra Singh Rawat <dsinghrawat@marvell.com>,
Jiawen Wu <jiawenwu@trustnetic.com>,
Yong Wang <yongwang@vmware.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
santosh.shukla@caviumnetworks.com,
Akhil Goyal <gakhil@marvell.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
michael.baucom@broadcom.com,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
Lance Richardson <lance.richardson@broadcom.com>,
kishore.padmanabha@broadcom.com,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
derek.chickles@caviumnetworks.com,
ssrinivasan@caviumnetworks.com, mjatharakonda@oneconvergence.com,
simon.horman@corigine.com, david.george@sophos.com,
sony.chacko@qlogic.com, harish.patil@qlogic.com,
Stephen Hemminger <stephen@networkplumber.org>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
ian.betts@intel.com, Liang Ma <liang.j.ma@intel.com>,
lei.a.yao@intel.com
Subject: Re: [PATCH 7/7] lib/power: fix unused but set variables
Date: Fri, 12 Nov 2021 15:13:35 +0100 [thread overview]
Message-ID: <CAJFAV8wsJsQjV70rg0h_ckUF8bHoS3Zqp9y4A_JFNRZZqG4yFg@mail.gmail.com> (raw)
In-Reply-To: <20211112140111.922171-8-conor.walsh@intel.com>
Hello Conor,
On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh <conor.walsh@intel.com> wrote:
>
> This patch removes the tot_ppi variable from the update_stats function
> within empty poll in the power library as it is an unused but set
> variable.
About the commitlog, commenting on this patch, but it applies to other
of the series.
>
> Bugzilla ID: 881
No need for an empty line between bugzilla and fixes lines.
>
> Fixes: 450f0791312c ("power: add traffic pattern aware power control")
We will want those fixes in stable branches.
Cc: stable@dpdk.org
>
> Signed-off-by: Conor Walsh <conor.walsh@intel.com>
> Reported-by: Liang Longfeng <longfengx.liang@intel.com>
Reports come before signing off a fix :-)
Now, on this specific patch, Jim already provided a fix for this
issue, you can drop it from your series.
https://patchwork.dpdk.org/project/dpdk/patch/20211105155351.350403-1-james.r.harris@intel.com/
--
David Marchand
next prev parent reply other threads:[~2021-11-12 14:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-12 14:01 [PATCH 0/7] " Conor Walsh
2021-11-12 14:01 ` [PATCH 1/7] app/test: " Conor Walsh
2021-11-12 14:29 ` Medvedkin, Vladimir
2021-11-12 14:01 ` [PATCH 2/7] drivers/bus/fslmc: " Conor Walsh
2021-11-12 14:01 ` [PATCH 3/7] drivers/common/qat: " Conor Walsh
2021-11-12 14:01 ` [PATCH 4/7] drivers/event/sw: " Conor Walsh
2021-11-12 15:15 ` Van Haaren, Harry
2021-11-12 14:01 ` [PATCH 5/7] drivers/net: " Conor Walsh
2021-11-12 16:17 ` Ferruh Yigit
2021-11-12 16:27 ` David Marchand
2021-11-12 16:38 ` Walsh, Conor
2021-11-12 16:41 ` Stephen Hemminger
2021-11-12 16:46 ` Walsh, Conor
2021-11-12 16:35 ` Walsh, Conor
2021-11-15 9:28 ` David Marchand
2021-11-16 4:58 ` Somnath Kotur
2021-11-16 5:08 ` Ajit Khaparde
2021-11-12 14:01 ` [PATCH 6/7] examples/performance-thread: " Conor Walsh
2021-11-12 14:01 ` [PATCH 7/7] lib/power: " Conor Walsh
2021-11-12 14:13 ` David Marchand [this message]
2021-11-12 14:17 ` Walsh, Conor
2021-11-12 14:26 ` David Marchand
2021-11-15 17:58 ` [PATCH 0/6] " Conor Walsh
2021-11-15 17:58 ` [PATCH 1/6] app/test: " Conor Walsh
2021-11-15 17:58 ` [PATCH 2/6] drivers/bus/fslmc: " Conor Walsh
2021-11-15 17:58 ` [PATCH 3/6] drivers/common/qat: " Conor Walsh
2021-11-15 17:58 ` [PATCH 4/6] drivers/event/sw: " Conor Walsh
2021-11-15 17:58 ` [PATCH 5/6] drivers/net: " Conor Walsh
2021-11-16 12:04 ` David Marchand
2021-11-15 17:58 ` [PATCH 6/6] examples/performance-thread: " Conor Walsh
2021-11-16 12:28 ` [PATCH 0/6] " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wsJsQjV70rg0h_ckUF8bHoS3Zqp9y4A_JFNRZZqG4yFg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=ajit.khaparde@broadcom.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=cloud.wangxiaoyun@huawei.com \
--cc=conor.walsh@intel.com \
--cc=david.george@sophos.com \
--cc=david.hunt@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=derek.chickles@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=gakhil@marvell.com \
--cc=harish.patil@qlogic.com \
--cc=harry.van.haaren@intel.com \
--cc=heinrich.kuhn@corigine.com \
--cc=hemant.agrawal@nxp.com \
--cc=hkalra@marvell.com \
--cc=ian.betts@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jiawenwu@trustnetic.com \
--cc=john.griffin@intel.com \
--cc=john.mcnamara@intel.com \
--cc=kishore.padmanabha@broadcom.com \
--cc=lance.richardson@broadcom.com \
--cc=lei.a.yao@intel.com \
--cc=liang.j.ma@intel.com \
--cc=longfengx.liang@intel.com \
--cc=michael.baucom@broadcom.com \
--cc=mjatharakonda@oneconvergence.com \
--cc=rmody@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=sachin.saxena@oss.nxp.com \
--cc=sameh.gobriel@intel.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=shreyansh.jain@nxp.com \
--cc=simon.horman@corigine.com \
--cc=somnath.kotur@broadcom.com \
--cc=sony.chacko@qlogic.com \
--cc=srinivasan@marvell.com \
--cc=ssrinivasan@caviumnetworks.com \
--cc=stephen@networkplumber.org \
--cc=sthotton@marvell.com \
--cc=tomaszx.kulasek@intel.com \
--cc=venkatkumar.duvvuru@broadcom.com \
--cc=vladimir.medvedkin@intel.com \
--cc=xuanziyang2@huawei.com \
--cc=yipeng1.wang@intel.com \
--cc=yongwang@vmware.com \
--cc=zhouguoyang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).