Re: [PATCH] bus/vdev: vdev_cleanup checks dev->device.driver

[David Marchand <david.marchand@redhat.com>]

On Wed, Oct 19, 2022 at 12:55 PM Zhangfei Gao <zhangfei.gao@linaro.org> wrote:
>
> The vdev_probe calls driver->probe, which may fail
> and dev->device.driver will still be NULL.
>
> In vdev_cleanup, drv = container_of(dev->device.driver) returns !NULL,
> then drv->remove will trigger Segmentation fault.
> Fix it by checking dev->device.driver first.
>
> Log:
> Thread 1 "dpdk-test" received signal SIGSEGV, Segmentation fault.
> 0x00000000012c484d in vdev_cleanup ()

I suspect you hit this issue when running some crypto autotest.
Can you confirm?


The commit that introduced the issue should be mentionned, with a
Fixes: tag, like:
Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown")

>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>  drivers/bus/vdev/vdev.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
> index f5b43f1930..fbdaf68380 100644
> --- a/drivers/bus/vdev/vdev.c
> +++ b/drivers/bus/vdev/vdev.c
> @@ -577,6 +577,9 @@ vdev_cleanup(void)
>                 const struct rte_vdev_driver *drv;
>                 int ret = 0;
>
> +               if (dev->device.driver == NULL)
> +                       continue;
> +
>                 drv = container_of(dev->device.driver, const struct rte_vdev_driver, driver);
>
>                 if (drv == NULL || drv->remove == NULL)

If dev->device.driver != NULL, then drv won't be NULL.


-- 
David Marchand