From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dmarchan@redhat.com> Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id AFDC82956 for <dev@dpdk.org>; Wed, 20 Mar 2019 10:24:07 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id q189so369898vkq.11 for <dev@dpdk.org>; Wed, 20 Mar 2019 02:24:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c4U5843GHnVIetYLg8gV5lFhGsxD7b67WOIqN8LorAw=; b=Zcrn/PGn/O4S2ZkIuppvCrWFPeT12RAUHIMhTrz0riY23yI2Xoa79hFkxfguchgdWA pICyZxnMAIc8ump8VeAXPXPc0ow8V+9MCvajZfIHvQBAuqr+xgb50qLf9X9qcZf1t/Pw JG8zrN5QQpimjo2OWkXUcyfvUR7G+WDOLy7eYYeKY3WIICMtSMbB7spCF+rShIU2kpxv e9nQZvP4DZ9J4phgsmVbK7G0wisloiu4gcQu7XgLvoPXp8Sx9JIa5uSRf1uP29U6Uowf UhS+GCrzdwQMbmDOk51KDoKkPqo1dpQS2PTvXrHMbHQ9fYrA8tYjOT8pp7WB0xVPRy6d cQmA== X-Gm-Message-State: APjAAAXOYsoqIiUu07FULk7wgmqPPvQlA62K8H5B+JT7v4nrg/T57J4i kT3+f05CkjdtnDRIfoOpmZ1vfcNTqI8faUv9eI0axg== X-Google-Smtp-Source: APXvYqyQ7eP3RXGXHV/aXIX/JVlL600c2y2ueozUXAG8078eVhkCsclwPimqocUaW/DRnYZrmq8ibWTeXZEVmD2k+6k= X-Received: by 2002:a1f:e845:: with SMTP id f66mr4021511vkh.86.1553073847144; Wed, 20 Mar 2019 02:24:07 -0700 (PDT) MIME-Version: 1.0 References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190319071256.26302-1-xiaolong.ye@intel.com> <20190319071256.26302-7-xiaolong.ye@intel.com> <b9834d2e5e48a7bfbdedbcfc942b191bc0fc95f4.camel@marvell.com> In-Reply-To: <b9834d2e5e48a7bfbdedbcfc942b191bc0fc95f4.camel@marvell.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 20 Mar 2019 10:23:56 +0100 Message-ID: <CAJFAV8wsbGfXz=3_QBtwYYfaep2oh6KQ3R3DeyYZo3wdWRbi2Q@mail.gmail.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> Cc: "xiaolong.ye@intel.com" <xiaolong.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "magnus.karlsson@intel.com" <magnus.karlsson@intel.com>, "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>, "bjorn.topel@intel.com" <bjorn.topel@intel.com> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 20 Mar 2019 09:24:07 -0000 On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < jerinj@marvell.com> wrote: > On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: > > When create rte_mempool, flags can be parsed from command line. > > Now, it is possible for testpmd to create a af_xdp friendly > > mempool (which enable zero copy). > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com> > > --- > > app/test-pmd/parameters.c | 12 ++++++++++++ > > app/test-pmd/testpmd.c | 17 ++++++++++------- > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > > If I understand it correctly, The user needs to change all the > application in order to avail zero copy feature of XDP. > > If so, > > How about creating wrapper mempool driver for xdp at drivers/mempool/? > and mempool's best mempool feature to select the required mempool > driver for XDP at runtime without changing the apps. > > see rte_mbuf_best_mempool_ops() > see struct eth_dev_ops::pool_ops_supported > Glab to read this, I was under the same impression :-) -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7E1B5A00E6 for <public@inbox.dpdk.org>; Wed, 20 Mar 2019 10:24:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53FD74C93; Wed, 20 Mar 2019 10:24:08 +0100 (CET) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id AFDC82956 for <dev@dpdk.org>; Wed, 20 Mar 2019 10:24:07 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id q189so369898vkq.11 for <dev@dpdk.org>; Wed, 20 Mar 2019 02:24:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c4U5843GHnVIetYLg8gV5lFhGsxD7b67WOIqN8LorAw=; b=Zcrn/PGn/O4S2ZkIuppvCrWFPeT12RAUHIMhTrz0riY23yI2Xoa79hFkxfguchgdWA pICyZxnMAIc8ump8VeAXPXPc0ow8V+9MCvajZfIHvQBAuqr+xgb50qLf9X9qcZf1t/Pw JG8zrN5QQpimjo2OWkXUcyfvUR7G+WDOLy7eYYeKY3WIICMtSMbB7spCF+rShIU2kpxv e9nQZvP4DZ9J4phgsmVbK7G0wisloiu4gcQu7XgLvoPXp8Sx9JIa5uSRf1uP29U6Uowf UhS+GCrzdwQMbmDOk51KDoKkPqo1dpQS2PTvXrHMbHQ9fYrA8tYjOT8pp7WB0xVPRy6d cQmA== X-Gm-Message-State: APjAAAXOYsoqIiUu07FULk7wgmqPPvQlA62K8H5B+JT7v4nrg/T57J4i kT3+f05CkjdtnDRIfoOpmZ1vfcNTqI8faUv9eI0axg== X-Google-Smtp-Source: APXvYqyQ7eP3RXGXHV/aXIX/JVlL600c2y2ueozUXAG8078eVhkCsclwPimqocUaW/DRnYZrmq8ibWTeXZEVmD2k+6k= X-Received: by 2002:a1f:e845:: with SMTP id f66mr4021511vkh.86.1553073847144; Wed, 20 Mar 2019 02:24:07 -0700 (PDT) MIME-Version: 1.0 References: <20190301080947.91086-1-xiaolong.ye@intel.com> <20190319071256.26302-1-xiaolong.ye@intel.com> <20190319071256.26302-7-xiaolong.ye@intel.com> <b9834d2e5e48a7bfbdedbcfc942b191bc0fc95f4.camel@marvell.com> In-Reply-To: <b9834d2e5e48a7bfbdedbcfc942b191bc0fc95f4.camel@marvell.com> From: David Marchand <david.marchand@redhat.com> Date: Wed, 20 Mar 2019 10:23:56 +0100 Message-ID: <CAJFAV8wsbGfXz=3_QBtwYYfaep2oh6KQ3R3DeyYZo3wdWRbi2Q@mail.gmail.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com> Cc: "xiaolong.ye@intel.com" <xiaolong.ye@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "olivier.matz@6wind.com" <olivier.matz@6wind.com>, "magnus.karlsson@intel.com" <magnus.karlsson@intel.com>, "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>, "bjorn.topel@intel.com" <bjorn.topel@intel.com> Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 6/6] app/testpmd: add mempool flags parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190320092356.FrXeDs3yn9l7p71JN71RlRF6Zk1Eb-wmm-Ytjef6-2k@z> On Wed, Mar 20, 2019 at 12:37 AM Jerin Jacob Kollanukkaran < jerinj@marvell.com> wrote: > On Tue, 2019-03-19 at 15:12 +0800, Xiaolong Ye wrote: > > When create rte_mempool, flags can be parsed from command line. > > Now, it is possible for testpmd to create a af_xdp friendly > > mempool (which enable zero copy). > > > > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > > Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com> > > --- > > app/test-pmd/parameters.c | 12 ++++++++++++ > > app/test-pmd/testpmd.c | 17 ++++++++++------- > > app/test-pmd/testpmd.h | 1 + > > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > > If I understand it correctly, The user needs to change all the > application in order to avail zero copy feature of XDP. > > If so, > > How about creating wrapper mempool driver for xdp at drivers/mempool/? > and mempool's best mempool feature to select the required mempool > driver for XDP at runtime without changing the apps. > > see rte_mbuf_best_mempool_ops() > see struct eth_dev_ops::pool_ops_supported > Glab to read this, I was under the same impression :-) -- David Marchand