From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A4887A0547; Fri, 14 Feb 2020 17:39:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DD35F72; Fri, 14 Feb 2020 17:39:47 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 4CB3BB62 for ; Fri, 14 Feb 2020 17:39:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581698385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KRS2wPiaO8aDtYFmu1tZwXK+/xSh64fgSIiVPludz84=; b=HL7INZt15K5ncyoOVTRR4E3kNG8q0L7ALQ1c+zVdHU4XWh293WoBcJkxERuXO/UYvYxMJ6 0GH2n/psFAfRFK9LrOT+rm36lDPSoy3dE1bRxX24Uugh5QDIgZTaB6XwN/zYD9AQY4Seix Lkim3Don3lrLxBPn63R1NKZZwfj6wsg= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-Fv2xn0sxO_qmfHbWQu4AnA-1; Fri, 14 Feb 2020 11:39:44 -0500 Received: by mail-ua1-f69.google.com with SMTP id f15so2401655uap.4 for ; Fri, 14 Feb 2020 08:39:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KRS2wPiaO8aDtYFmu1tZwXK+/xSh64fgSIiVPludz84=; b=rI2SXXEBH9XJxf3GWVI002PcEPybVo6cI5bLp69KgGJmkYwijPoRgjBGIUH/3vzZSL irH/EdGtiJfTOuj6nOqKuD/MWeMPK3VXI/1xVvjsJZcTQ4eItupufiGsuxc7UKhR7npN tcdcyrCJofAxG53wSZrXVhsmh9HhtCSHifIlEoLYQ0BEvahgfZj7jqxa+1WJld0T1R1y S5Icq3GjP5vEucdzWnnrzSgmHB330lea1DJTC9Nwj1uLSnGlwuvIOhb58wvnCnhk6Nt6 jPkDSX3YFcrvbdF8Cb3Z1uOxNbaZ7qFetWQkMM64qT4ec18MtQ7RU/I1wUabJyZktw70 jaMQ== X-Gm-Message-State: APjAAAWP0o+JXkJ1ilsFUvOJabm6qyQ4gc+1SpwE91RgrMUJDNQ7R0Ka EyJ3cBXuZHE4djR4LD0FxvgpxTAlwPd7/ameNq5tJyWaZI3fw5YUCbkorVxHZMBUDf/nOmcHBud jM4zNKg6hkfp2/CXXwpw= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr1982028vsm.180.1581698383574; Fri, 14 Feb 2020 08:39:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxl7ueRfOsGXV8VqBx1+v13OoZ15NvpQGzQi8h5vVRZs9A9NgcmnRfA4XTG68UBzfrijJZ9AH/LGc5oZpHjxjU= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr1982015vsm.180.1581698383346; Fri, 14 Feb 2020 08:39:43 -0800 (PST) MIME-Version: 1.0 References: <20191202091517.17461-1-ciara.power@intel.com> <20200214161725.36104-1-ciara.power@intel.com> In-Reply-To: <20200214161725.36104-1-ciara.power@intel.com> From: David Marchand Date: Fri, 14 Feb 2020 17:39:32 +0100 Message-ID: To: Ciara Power Cc: Olivier Matz , Andrew Rybchenko , dev , Bruce Richardson , dpdk stable X-MC-Unique: Fv2xn0sxO_qmfHbWQu4AnA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] lib: fix unnecessary double negation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Feb 14, 2020 at 5:28 PM Ciara Power wrote: > > An equality expression already returns either 0 or 1. > There is no need to use double negation for these cases. > > Fixes: ea672a8b1655 ("mbuf: remove the rte_pktmbuf structure") > Fixes: a0fd91cefcc0 ("mempool: rename functions with confusing names") > Cc: stable@dpdk.org > > Signed-off-by: Ciara Power > Acked-by: Olivier Matz > Reviewed-by: Ferruh Yigit Applied, thanks. -- David Marchand