From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCD9FA034F; Tue, 1 Mar 2022 09:44:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 405D141203; Tue, 1 Mar 2022 09:44:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1313E40DF6 for ; Tue, 1 Mar 2022 09:44:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646124248; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fe48klb2Ub5uHatuTpo7f/khRMPKQBEUp0FDjEmSy8o=; b=U+pLpObbfTZvNVhc71/Nz7jDlggFEaAU7+atYlT667KI5EROdJOZ5UU/fATilHt0lwk9jX gPHoLY8YfQN4kxkUPWHc6EEjR9eaGl1nB4veroseSR92UGdufnkm9EtLvSGiK0YdQ+7ZK9 lw5xFa61r8pixDdt7ENuanPfZxHpwmI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-O_MJTUWuPeSZNRV8eC3BLA-1; Tue, 01 Mar 2022 03:44:07 -0500 X-MC-Unique: O_MJTUWuPeSZNRV8eC3BLA-1 Received: by mail-lj1-f199.google.com with SMTP id bf20-20020a2eaa14000000b0024634b36cdaso6965935ljb.0 for ; Tue, 01 Mar 2022 00:44:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fe48klb2Ub5uHatuTpo7f/khRMPKQBEUp0FDjEmSy8o=; b=mr/fsMdxuhN6mSt/dRxwmSHDytdBQSxCK4MrDPm3iafbGMWwBjsJupOkg5lMmjjNdW xxNA7xbGeMnSLOfgOMgqToYGe4wxE/uNC566xw36HxL/47Ckp5S28t4XiQ9QT6uwp1DM hEOYVEIxg3zN+d0RTX3QR5eXBiMO8y2hvFLRkDhNbebM4H3/QnmB9VlEuujMiADNvMbM 950vGMcLfYIYRmxeNJ8jfuyzpkQb3V6PGM5uztaqccKZZaOSPJIReXqf7HezJohE9AvY MG2IZUBJT6/OLslwOaEPFk6Y/mZhUaWIK26Fr0ithLkUW6RuXvKuAQVO4DWjn/NRKJer HBrA== X-Gm-Message-State: AOAM531uMbrAYwJtj+PRhuV5YP928Kl4lf0ztVpQSh9WjLYCDYQ69Bo2 j4F/jD+voI4nC1trzsNFFVDlDno0H8G8YVZYCNwA9gGoqhoWIsfYlmlMQ7ccp3q9HOXa+EKXzJR 4/ndBHlGa8tz65hc5hA4= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr16694490lji.333.1646124246097; Tue, 01 Mar 2022 00:44:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyCjmEpyeIHooQnKTWYRCEG27i7pe+tT6BojlS84qAN3gGqYw2kurtVmH1L2j53oyPkm2NQdoCwaNzveSttxUY= X-Received: by 2002:a2e:8603:0:b0:23a:6193:e2e2 with SMTP id a3-20020a2e8603000000b0023a6193e2e2mr16694482lji.333.1646124245914; Tue, 01 Mar 2022 00:44:05 -0800 (PST) MIME-Version: 1.0 References: <20220301072802.1349736-1-yuying.zhang@intel.com> In-Reply-To: <20220301072802.1349736-1-yuying.zhang@intel.com> From: David Marchand Date: Tue, 1 Mar 2022 09:43:54 +0100 Message-ID: Subject: Re: [PATCH v1] net/vhost: clear data of packet mbuf after sending pkts To: Yuying Zhang Cc: dev , Maxime Coquelin , "Xia, Chenbo" , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 1, 2022 at 8:29 AM Yuying Zhang wrote: > > The PMD frees a packet mbuf back into its original mempool > after sending a packet. However, old data is not cleaned up > which causes error in payload of new packets. This patch clear > data of packet mbuf before freeing mbuf. This patch looks wrong to me. What is the actual issue you want to fix? -- David Marchand