From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 121894298A; Wed, 19 Apr 2023 16:38:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 009B440E25; Wed, 19 Apr 2023 16:38:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 486A240A79 for ; Wed, 19 Apr 2023 16:38:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681915135; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VlksXSO6MsCRCx1X/gm6IRmptfHXLBvPKTsUIUWoMkM=; b=ESrW8dipJpbSM/M0xSvm6UTiqRupjsgOXFfq5mUVBtg1Cgxu5bJGfqnymceXjv9HEnSgjr UYdqNJXBNFvzi7D15VfzjyeeHVLGBdIbL6B0W6ixxW07XCzzMjrqX0qqx0Yt5i3GCQGHYH GaQk5LyC0g2yWuXoWip7u/k0/wCye2g= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-bk32mxB6PdGDi-VlXjVLMw-1; Wed, 19 Apr 2023 10:38:54 -0400 X-MC-Unique: bk32mxB6PdGDi-VlXjVLMw-1 Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-51bacd63947so1692398a12.0 for ; Wed, 19 Apr 2023 07:38:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681915133; x=1684507133; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VlksXSO6MsCRCx1X/gm6IRmptfHXLBvPKTsUIUWoMkM=; b=AB7+OuDNCxoEkEZgfmAL5EtRyTbR+ZsIxGlQZ+dcLBggAZ4sEy7g68Jl7Ktx6gFwgj GNAR48V866XMuJzn0kDxxZPqwWyZBPDLV9KceBn8fSNPqycgzNYZwTv8WglGoMKMTO6k sw8X2RAINxZmtPsqrOyXZO2ugc5jEo1XDdmevcXDSSeASgWFg+1t9W5e6E1I7KPJegWi dF4JU2AKeTtO8uun0+hkZE6zNWnE5u7qiIZiwzR6zwGsvCEdkoT7jtCCFQJ6UFKBFWgS nSphk6wo7TpTmDnStJymh9hUaXvoArFIa6YW2KGQJ5scIe6fruC0rIeMjBQY6eyWz+B+ 4ueQ== X-Gm-Message-State: AAQBX9fCtiT6sT8kjGJzAK+8XXHtqidC2HyoOYQn4OW9fY1IzCooTvb9 OQpBnn2Tw1F/TnJ7Xd/dyX5VlM+tOQbba01oKSbIZDlpdPE6hrbf1Mplkjn9fl1uSpWJIkFpneK pI9xAfVOakOQg4w/Prf4ib/Iz+ec= X-Received: by 2002:a17:90b:1b4d:b0:23b:3699:b8a9 with SMTP id nv13-20020a17090b1b4d00b0023b3699b8a9mr3041841pjb.17.1681915133433; Wed, 19 Apr 2023 07:38:53 -0700 (PDT) X-Google-Smtp-Source: AKy350au6nb/ky29erEJuaUQbU3dbZeERVP0WtjMO8UnwHTUNLKxDpZ+RxlDTB3ywnIyQutiTbk5WPrRPVk8Sl2Drx0= X-Received: by 2002:a17:90b:1b4d:b0:23b:3699:b8a9 with SMTP id nv13-20020a17090b1b4d00b0023b3699b8a9mr3041831pjb.17.1681915133200; Wed, 19 Apr 2023 07:38:53 -0700 (PDT) MIME-Version: 1.0 References: <20230228172909.2054386-1-ferruh.yigit@amd.com> <20230414152522.83636-1-ferruh.yigit@amd.com> In-Reply-To: From: David Marchand Date: Wed, 19 Apr 2023 16:38:42 +0200 Message-ID: Subject: Re: [PATCH v2] kni: fix build with Linux 6.3 To: Ferruh Yigit Cc: dev@dpdk.org, Vamsi Krishna Attunuru X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > On Fri, Apr 14, 2023 at 5:25=E2=80=AFPM Ferruh Yigit wrote: > > > > KNI calls `get_user_pages_remote()` API which is using `FOLL_TOUCH` > > flag, but `FOLL_TOUCH` is no more in public headers since v6.3, > > causing a build error. > > > > `FOLL_*` defines in Linux kernel first moved to another header [1], > > later some of them moved to memory subsystem internal header [2] for 6.= 3 > > > > `get_user_pages_remote()` already sets `FOLL_TOUCH` internally, > > no need to set this flag externally anyway, moving flag from the call > > altogether. > > > > [1] > > Commit b5054174ac7c ("mm: move FOLL_* defs to mm_types.h") > > > > [2] > > Commit 2c2241081f7d ("mm/gup: move private gup FOLL_ flags to internal.= h") > > > > Signed-off-by: Ferruh Yigit > > Reviewed-by: David Marchand Applied, thanks Ferruh. --=20 David Marchand