From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C830F4292F; Thu, 13 Apr 2023 09:22:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B83040A84; Thu, 13 Apr 2023 09:22:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 423E04021F for ; Thu, 13 Apr 2023 09:22:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681370540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hNH4U55BD1k8oywHBhSKb//PS/ckpFbspiJDQuaqIMk=; b=fAXxHBTepM/+Rp1ta6JBIsipUMYOySiQblUO9CEKbdJJOzOZ9HbcSbggOTP0XJZ17nSRJg tOdmxgk/zGc+9m6v8QYKq2SCGgXz4yB2eBU4fNXgeP82GjvwOmQg+6VsMmRtV160sY9n4K GdBgKznew65W8LEsr3Zo6VIurwWqXmo= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-pOL5m90SOx-KltZECxvSgw-1; Thu, 13 Apr 2023 03:22:18 -0400 X-MC-Unique: pOL5m90SOx-KltZECxvSgw-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-246f722ef3fso346054a91.3 for ; Thu, 13 Apr 2023 00:22:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681370537; x=1683962537; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNH4U55BD1k8oywHBhSKb//PS/ckpFbspiJDQuaqIMk=; b=B5j4iNsPLC29UwOZB8u/iWRYHNsBkJ/tJ4Fz40KV3eRfk48NMpANK+79sRbgEZo4Dm jl2uFDovkO+RN9GGr+cIQOHRqlQBexBlhZlzZTi3Oc/vDumih7lGDYLaoHK1khBuSUJz r6fQdAW5m9YC1+BSxKXgOGXn42MTCzCTvMZDOWUqQby1ctrIOr4SwircgmoJ1qELOGRK 8GT+uF+jVggii9AKc9NhFy2UTPT02t+s230CuGvReKishTS8RpGDjE09BqXazJHLDsMZ nZe1CKHwd8j4oo9o8HJFDIvV3dJVEYiiASfmVtutG2a/xQKyKoTspOjgFD8o+lHqTyKv QVCA== X-Gm-Message-State: AAQBX9dYtZCy8ZCbfr6O5FbaxIeIdCytIb1c5jFhzrfIqnmySdjVAIWt tES8kLbUGAigTOHfAQyfb9bXTmKHh+i6fZZXkfebiAKSx/Y1YSC6DnKj4rizUD1B29C0SCztSBk BG7zUF638JRXp7JNQvmE= X-Received: by 2002:a05:6a00:1396:b0:63b:3577:ade with SMTP id t22-20020a056a00139600b0063b35770ademr551424pfg.5.1681370537078; Thu, 13 Apr 2023 00:22:17 -0700 (PDT) X-Google-Smtp-Source: AKy350aiNUL49H6KeW+A3yBPplmC6Bm7hwBX9dRYK6Fb2U2c2STMmrr8ETnrOqK1gyMDEXxw/oXqPwjrgfwF8FKXOg4= X-Received: by 2002:a05:6a00:1396:b0:63b:3577:ade with SMTP id t22-20020a056a00139600b0063b35770ademr551410pfg.5.1681370536782; Thu, 13 Apr 2023 00:22:16 -0700 (PDT) MIME-Version: 1.0 References: <20230228172909.2054386-1-ferruh.yigit@amd.com> In-Reply-To: From: David Marchand Date: Thu, 13 Apr 2023 09:22:05 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH] kni: fix build with Linux 6.3 To: Vamsi Krishna Attunuru , Ferruh Yigit Cc: Kiran Kumar Kokkilagadda , Jerin Jacob Kollanukkaran , "dev@dpdk.org" , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 24, 2023 at 4:04=E2=80=AFAM Vamsi Krishna Attunuru wrote: > > > So I think the dpdk commit e73831dc6c26 ("kni: support userspace VA") > > > uselessly introduced call to this flag and we can remove it. > > > Adding author and reviewers of this change. > > > > Alternatively, we could go with passing 0 in flags when FOLL_TOUCH is n= ot > > exported. > > Something like: > > Yes, this flag is useless, I vaguely remember like I added it from v1(in = that patch series) itself along with multiple kernel version checks, > but by looking at the internals neither of them would not need it. > > We could pass 0 in flags as suggested. Ok, thanks for the confirmation Vamsi. Ferruh, can you submit a v2? --=20 David Marchand