From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C0D6A09D9; Wed, 11 Nov 2020 16:56:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61C6D31FC; Wed, 11 Nov 2020 16:56:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 96658DED for ; Wed, 11 Nov 2020 16:56:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605110213; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VOKaMVuPCkhkNRMGvlLP5zc0vSwSOvJNLo23G20KFDs=; b=a5UzJr9JDLkkVCH4EisQiLbl89Hor8SLTWfzG71ZBtippWBilIBgRDKPeLbYbYzcEFFbqi +0sVSXzTRIxCYiHBBzYs6EsZqhpUCNEvzteqP3NJENdbiF4zJwCfir4OkrrXXxmDD5xjSu HiidepvIWvOl3a9GD4S0+RVW6ljESEw= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-201-c_W86dWLN66sJNPkGQisYA-1; Wed, 11 Nov 2020 10:56:49 -0500 X-MC-Unique: c_W86dWLN66sJNPkGQisYA-1 Received: by mail-vk1-f198.google.com with SMTP id v3so649902vkn.19 for ; Wed, 11 Nov 2020 07:56:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VOKaMVuPCkhkNRMGvlLP5zc0vSwSOvJNLo23G20KFDs=; b=FPhNj+MddgiXUEfX3n6BMLlVM2wOx8xeyUy1ZdoyDyqJ/fHu4ToBbn348KJUt4QHLX sBtu5HGuCfXYIHXh06CSJX+vgXkGyFq5+cOop4Jpymq5D1dRRz17mltZ5v2peNGcqtNV DKXYMvnZv8Rdes9oHVbnwXqfacnGJEDNfqguxpgMdzOZJqnPZAarkvW40Puknmu+moMq KF/rvci33clX3gaPYOGq6E+OZ3A7N7cJ6Byd+CjHkyYAxKZcX1To3Wna0h2Z69HHZ2BI nA4NKxH8SKqCnLLagjv+RFUhyUITaoPrgsuEFmhbpsq5Kt5000da6RLNp0yzA8Vjbf27 S+SA== X-Gm-Message-State: AOAM533lJ2MMahsmBJ4CEcyHeQLOeocBd4Ff412RY1TDZZIkQjNjRV4L hD0njVgotgBUvH3RO7ujRL78nVXSs2hyn1+QXUFbntow7wou2ea3MmzQOwLwxm2eArOGpiK2zir DR+VRXCyePSk7bGyYnhY= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr16454329vsp.18.1605110208670; Wed, 11 Nov 2020 07:56:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyIX5cMujOsIh3Np0wry39UiLWRYhRDrlbWHftVLJtzUzObMIkxGBmOzvF4eX6fDvsHpOyUH7Q6UbrBLpm2lAQ= X-Received: by 2002:a67:f8c5:: with SMTP id c5mr16454313vsp.18.1605110208519; Wed, 11 Nov 2020 07:56:48 -0800 (PST) MIME-Version: 1.0 References: <20201111154007.13426-1-yong.liu@intel.com> <20201111155346.GD1500@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201111155346.GD1500@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Wed, 11 Nov 2020 16:56:37 +0100 Message-ID: To: Bruce Richardson Cc: David Christensen , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" , Maxime Coquelin , "Xia, Chenbo" , dev , Marvin Liu , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/virtio: enable packet data prefetch on x86 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 11, 2020 at 4:54 PM Bruce Richardson wrote: > > On Wed, Nov 11, 2020 at 04:45:25PM +0100, David Marchand wrote: > > On Wed, Nov 11, 2020 at 4:40 PM Marvin Liu wrote: > > > > > > Data prefetch instruction can preload data into cpu=E2=80=99s hierarc= hical > > > cache before data access. Virtio datapath utilized this feature for > > > data access acceleration. As config RTE_PMD_PACKET_PREFETCH was > > > discarded, now packet data prefetch is enabled based on architecture. > > > > IIUC, this config item was set for all architectures under make compila= tion. > > > > $ git grep RTE_PMD_PACKET_PREFETCH v20.08 config/ > > v20.08:config/common_base:CONFIG_RTE_PMD_PACKET_PREFETCH=3Dy > > > > Now that we switched to meson, it got lost and this patch only > > restores it for x86. > > Can other architectures check this? > > > If it was globally enabled before, it probably should just be added to > config/rte_config.h file. > Restoring globally is the probably the best fix, yes. I am still surprised nobody but x86 testers caught a perf regression. --=20 David marchand