From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3329A455E4; Tue, 9 Jul 2024 17:42:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03D51402A9; Tue, 9 Jul 2024 17:42:58 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id CA75D4025C for ; Tue, 9 Jul 2024 17:42:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720539776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c17gJN0+2I9rL+3xm+x18OV/Co2IGClO42SM26AIHjg=; b=WPySjdvtoJWZEGQ/fBvmvcRwBbLp/ZKo/NO5A35J4icOcauiLsAUSgcVDNZzPCFdWrafGP 24FYWQZHsnZNg3bXXNkO+lZCE8xQxhLEl/mgKfkoHy4WBxMAjJ5Li7lowfmqaEOZqQCq8K r0OlgAnPrVwLclIF0z7t/5SkpWifLDg= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-395-iYbKr0eFOBC6kgBO1KfJqw-1; Tue, 09 Jul 2024 11:42:52 -0400 X-MC-Unique: iYbKr0eFOBC6kgBO1KfJqw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2ee87546e5eso55502161fa.0 for ; Tue, 09 Jul 2024 08:42:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720539771; x=1721144571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c17gJN0+2I9rL+3xm+x18OV/Co2IGClO42SM26AIHjg=; b=ED7UkaGj4cb9QgdKiYs28ND9FBPxXucUREAtMbbzs0EjRm9HLjT/AoytK5iP1uIuY2 n8ZG951ZWk7abz5+c0LHYCM1IXCVwz5ZgtdAXw67xonNZ+d07XCKZY3Ksm20YXSHB6Yw vC7wbw/wXxzcxXWTIiElY+8TQiBOllqXufS+laL8lu5zNU2nm2Zq6kZR1L+NjlM3pN6Z jfy1+ody6Sj3Osk7EWkUbL5kHVYxlP3TLkwG5rg1J/oF5DtAS1ss9rxa+Mm3FelvZlc9 wMCBjp9PUNTbhjhG4xKU05+8dK3V5qwMtgtNvlG8sUBAkmzkhMahAo0YjCGtSKpVEptm WJXg== X-Gm-Message-State: AOJu0YzQp1xSOtARtMmnGkinvzWHWXjwJoEoMa7QtGwQRCuQiQ4bAbHM R41aC3EaR2s/lnmEoonOIAP4n1V12dzMVHVG9+FjwUl92/OdSE1jxXi2pnUVkGEXNaHrUR76gdO n7TG/A4n02V+wWxNyGaWCrG6tyAp7/AcboaLNkmWhxUucb2E4X0Dg26M/DlyW65H+DqfFMP9+ws VV0RXrFXjdaCNH3B0= X-Received: by 2002:a2e:8784:0:b0:2ec:51fc:2f5a with SMTP id 38308e7fff4ca-2eeb30ba00dmr19564331fa.4.1720539771274; Tue, 09 Jul 2024 08:42:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUJZ6+AidVYx6GcCtHgA/Uu+2rnJCickNwWxgiYzJLJxwC0w7yZd+Jrp8jG4iqg823jBh4nUSqNFkBg7STUxc= X-Received: by 2002:a2e:8784:0:b0:2ec:51fc:2f5a with SMTP id 38308e7fff4ca-2eeb30ba00dmr19564141fa.4.1720539770869; Tue, 09 Jul 2024 08:42:50 -0700 (PDT) MIME-Version: 1.0 References: <20240302234812.9137-1-mb@smartsharesystems.com> <20240709132735.25671-1-mb@smartsharesystems.com> In-Reply-To: <20240709132735.25671-1-mb@smartsharesystems.com> From: David Marchand Date: Tue, 9 Jul 2024 17:42:39 +0200 Message-ID: Subject: Re: [PATCH v9] eal/x86: improve rte_memcpy const size 16 performance To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.v.ananyev@yandex.ru, stephen@networkplumber.org, roretzla@linux.microsoft.com, mattias.ronnblom@ericsson.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jul 9, 2024 at 3:28=E2=80=AFPM Morten Br=C3=B8rup wrote: > > When the rte_memcpy() size is 16, the same 16 bytes are copied twice. > In the case where the size is known to be 16 at build time, omit the > duplicate copy. > > Reduced the amount of effectively copy-pasted code by using #ifdef > inside functions instead of outside functions. > > Suggested-by: Stephen Hemminger > Signed-off-by: Morten Br=C3=B8rup > Acked-by: Bruce Richardson > Acked-by: Konstantin Ananyev > --- > v9: > * Remove dependency on other patch; it has been applied already. > * Add extra casts to fix warnings in OVS build. (David Marchand) I'll wait for the CI to finish. On my side, OVS compilation now passes (though we still have a regression in net/virtio-user + control q :-( ). v8: https://github.com/david-marchand/ovs/actions/runs/9858595974/job/272217243= 40#step:12:517 v9: https://github.com/david-marchand/ovs/actions/runs/9858595974/job/272204425= 47 --=20 David Marchand