From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id C99B3A04A2;
Tue, 12 May 2020 11:31:47 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 16EF31BFE8;
Tue, 12 May 2020 11:31:47 +0200 (CEST)
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 5DF891BFDD
for <dev@dpdk.org>; Tue, 12 May 2020 11:31:45 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1589275904;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=SRvIqP1fJgREDbLuG6hw+THXwLR621BnOiadS6R4mIM=;
b=QAgOLD5s0toPimaVU8VFcLIq758GwS1CI9AEEyJbkUQm0dd05qKG/7ZEjDKoUH+HkvODi/
K1YuDGwbcxz6wTpaRSMk9zw8rtG7p2cMLchwfN5rEUrdjaEadYhsX/u43g8LvIlDKEDyTp
hR6FDqMPTc7hPjs9lnit7hhfqJxcm1s=
Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com
[209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-468-soRQIYNgOLiLA96x0IkEaQ-1; Tue, 12 May 2020 05:31:38 -0400
X-MC-Unique: soRQIYNgOLiLA96x0IkEaQ-1
Received: by mail-vk1-f197.google.com with SMTP id j206so5581448vke.11
for <dev@dpdk.org>; Tue, 12 May 2020 02:31:38 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc:content-transfer-encoding;
bh=SRvIqP1fJgREDbLuG6hw+THXwLR621BnOiadS6R4mIM=;
b=uQpU/eefX5PlvH8FvHdrAU3CrIzehAAQuOrcuhYa9cUKPgN4ph5PpV977On5Ue2RnT
Cd7ChT0NHQAa6B6eoxm7xJ/0orhyhPhXECjSdxiQci4PAfRVgxRaEKCDoTn6megZQw0P
9b8+q/gVJH6xVHDl7owqMbE8AstC2gMybfyOjW3b/mx6odubAhp8R+w9aIZYBdJjzyMO
2jQtmTTd7NqpIFpIGAqW33MUIAO3Ck9L4yQgtVPZRaeWn8HcH0N48Np/a4mX6wUe8yFf
hgq5KDU/z7D6OrWlDApS+sW5+BbNmkADzTbZn/+u1MqiOXuDS813EJYnp//D62FU4G0C
8ELA==
X-Gm-Message-State: AGi0PuaXfV6+73Tgs/gtXX+1jlouka96Eu+dWeyABnI4fJN7Yyik///h
cRxbC1fKZBlwgQS0X6dVMEwOAm18mpAnfXh5L3OYsAsqZpJKWUeWTU0Vo1knU5HLZ2KeFWCmdBk
mxTnvBeaTOxzAy2C/AIU=
X-Received: by 2002:a67:680e:: with SMTP id d14mr15404595vsc.180.1589275898031;
Tue, 12 May 2020 02:31:38 -0700 (PDT)
X-Google-Smtp-Source: APiQypLMoSLkpis0GSAi/FrORNd9/PBaBliqeoSeG1P1Tf7jiX7LTN5elUCXr9XOEc+DFb4ugkM9uVv3cN666kTRqRo=
X-Received: by 2002:a67:680e:: with SMTP id d14mr15404579vsc.180.1589275897772;
Tue, 12 May 2020 02:31:37 -0700 (PDT)
MIME-Version: 1.0
References: <20200405085613.1336841-1-jerinj@marvell.com>
<20200411141428.1987768-1-jerinj@marvell.com>
<20200411141428.1987768-21-jerinj@marvell.com>
In-Reply-To: <20200411141428.1987768-21-jerinj@marvell.com>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 12 May 2020 11:31:26 +0200
Message-ID: <CAJFAV8wx9hSyqrkyfesguds6vkRbm0kJKm=Mcnx3Ni7LtstRUg@mail.gmail.com>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>
Cc: Pavan Nikhilesh <pbhagavatula@marvell.com>, dev <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>,
=?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,
Kiran Kumar Kokkilagadda <kirankumark@marvell.com>,
Xiao Wang <xiao.w.wang@intel.com>, Andrzej Ostruszka <amo@semihalf.com>
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH v5 20/29] node: ipv4 lookup for arm64
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Sat, Apr 11, 2020 at 4:16 PM <jerinj@marvell.com> wrote:
>
> From: Nithin Dabilpuram <ndabilpuram@marvell.com>
>
> Add arm64 specific IPv4 lookup process function
> for ip4_lookup node. This node performs LPM lookup
> on every packet received and forwards it to a next
> node that is identified by lookup result.
>
> Signed-off-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
> Signed-off-by: Kiran Kumar K <kirankumark@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
> lib/librte_node/ip4_lookup.c | 6 +
> lib/librte_node/ip4_lookup_neon.h | 238 ++++++++++++++++++++++++++++++
> 2 files changed, 244 insertions(+)
> create mode 100644 lib/librte_node/ip4_lookup_neon.h
Checking OVS dpdk-latest branch, I caught a build issue on Ubuntu
16.04 for aarch64.
I reproduced it in travis by forcing the distribution to xenial in .travis.=
yml.
FAILED: gcc -Ilib/lib@@rte_node@sta -Ilib -I../lib -Ilib/librte_node
-I../lib/librte_node -I. -I../ -Iconfig -I../config
-Ilib/librte_eal/include -I../lib/librte_eal/include
-Ilib/librte_eal/linux/include -I../lib/librte_eal/linux/include
-Ilib/librte_eal/arm/include -I../lib/librte_eal/arm/include
-Ilib/librte_eal/common -I../lib/librte_eal/common -Ilib/librte_eal
-I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs
-Ilib/librte_telemetry/../librte_metrics
-I../lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry
-I../lib/librte_telemetry -Ilib/librte_graph -I../lib/librte_graph
-Ilib/librte_mbuf -I../lib/librte_mbuf -Ilib/librte_mempool
-I../lib/librte_mempool -Ilib/librte_ring -I../lib/librte_ring
-Ilib/librte_lpm -I../lib/librte_lpm -Ilib/librte_hash
-I../lib/librte_hash -Ilib/librte_ethdev -I../lib/librte_ethdev
-Ilib/librte_net -I../lib/librte_net -Ilib/librte_meter
-I../lib/librte_meter -Ilib/librte_cryptodev -I../lib/librte_cryptodev
-fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall
-Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual
-Wdeprecated -Wformat-nonliteral -Wformat-security
-Wmissing-declarations -Wmissing-prototypes -Wnested-externs
-Wold-style-definition -Wpointer-arith -Wsign-compare
-Wstrict-prototypes -Wundef -Wwrite-strings
-Wno-missing-field-initializers -D_GNU_SOURCE -fPIC
-DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -fno-strict-aliasing
-MD -MQ 'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o' -MF
'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o.d' -o
'lib/lib@@rte_node@sta/librte_node_ip4_lookup.c.o' -c
../lib/librte_node/ip4_lookup.c
In file included from ../lib/librte_node/ip4_lookup.c:34:0:
../lib/librte_node/ip4_lookup_neon.h: In function =E2=80=98ip4_lookup_node_=
process=E2=80=99:
../lib/librte_node/ip4_lookup_neon.h:25:12: error: =E2=80=98dip=E2=80=99 ma=
y be used
uninitialized in this function [-Werror=3Dmaybe-uninitialized]
int32x4_t dip;
^
cc1: all warnings being treated as errors
ninja: build stopped: subcommand failed.
The odd thing is that a more recent gcc does not complain.
So there must be a catch, can you have a look?
Thanks.
--=20
David Marchand