From: David Marchand <david.marchand@redhat.com>
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: dev@dpdk.org, Jakub Palider <jpalider@marvell.com>, jerinj@marvell.com
Subject: Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging
Date: Fri, 24 Nov 2023 08:56:56 +0100 [thread overview]
Message-ID: <CAJFAV8wxCFwVRtv9hdWH+EmtbmjC0TLWC628KQQE9TFnD3MjPA@mail.gmail.com> (raw)
In-Reply-To: <20231114080446.3574237-1-tduszynski@marvell.com>
Hello,
On Tue, Nov 14, 2023 at 9:05 AM Tomasz Duszynski <tduszynski@marvell.com> wrote:
[snip]
> @@ -15,6 +16,11 @@
> #include "cnxk_bphy_irq.h"
> #include "rte_pmd_bphy.h"
>
> +extern int bphy_rawdev_logtype;
> +
> +#define BPHY_LOG(level, fmt, args...) \
> + rte_log(RTE_LOG_ ## level, bphy_rawdev_logtype, "%s(): " fmt "\n", __func__, ##args)
> +
> static const struct rte_pci_id pci_bphy_map[] = {
> {RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CNXK_BPHY)},
> {
> @@ -81,7 +87,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
> goto err_desc;
> if (descs != 1) {
> ret = -ENODEV;
> - plt_err("Wrong number of descs reported\n");
> + BPHY_LOG(ERR, "Wrong number of descs reported\n");
I think it is the only occurence in this patch, please remove trailing
\n since BPHY_LOG appends one.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2023-11-24 7:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 8:04 Tomasz Duszynski
2023-11-15 0:15 ` Stephen Hemminger
2023-11-23 20:36 ` [EXT] " Tomasz Duszynski
2023-11-24 7:56 ` David Marchand [this message]
2023-11-27 18:11 ` [PATCH v2] " Tomasz Duszynski
2023-12-06 14:09 ` Jerin Jacob
2024-02-21 1:59 ` Thomas Monjalon
2024-02-21 8:43 ` [EXT] " Tomasz Duszynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wxCFwVRtv9hdWH+EmtbmjC0TLWC628KQQE9TFnD3MjPA@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=tduszynski@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).