DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev <dev@dpdk.org>, michallinuxstuff@gmail.com
Subject: Re: [dpdk-dev] [PATCH 21.02] eal/linux: improve no hugepages logging
Date: Tue, 12 Jan 2021 12:17:07 +0100	[thread overview]
Message-ID: <CAJFAV8wxHX6LSx3jo-71O67ZztNKLWksWKfcGijL_Lt2x1zTfQ@mail.gmail.com> (raw)
In-Reply-To: <11a0d8735a3ee33d02bc57dc702995486051f5d6.1605022892.git.anatoly.burakov@intel.com>

On Tue, Nov 10, 2020 at 4:41 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
> When no hugepages are found, we log a message about it, but we never
> specify on which node. We also implicitly declare the page size based
> on the directory name, but that's not very user friendly.
> Fix both by changing the text of the message to note the NUMA node (if
> applicable) and explicitly mention page size in kilobytes.

Not sure it is worth aligning but another log uses bytes.
From my tests (after unmounting 2M hugetlbfs mountpoint):
EAL: 512 hugepages of size 2097152 reserved, but no mounted hugetlbfs
found for that size

> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>

The rest lgtm.

Reviewed-by: David Marchand <david.marchand@redhat.com>

David Marchand

  reply	other threads:[~2021-01-12 11:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 15:41 Anatoly Burakov
2021-01-12 11:17 ` David Marchand [this message]
2021-01-19 12:13   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wxHX6LSx3jo-71O67ZztNKLWksWKfcGijL_Lt2x1zTfQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=michallinuxstuff@gmail.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).