From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 6CA1D1BD40 for ; Thu, 20 Dec 2018 16:09:55 +0100 (CET) Received: by mail-ua1-f65.google.com with SMTP id p9so664689uaa.5 for ; Thu, 20 Dec 2018 07:09:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/kVtQIaZkaYL8xEjImE+Z8t0neyrQ/FhV/LDZPvz6NM=; b=XSRi2tPXVNVLmFl25XRK76/LoxHQ61xgiglA/PXUAUI6b8prsAPnCWUIStuD0ehIBd h7lxefQgSaHg6dzdTFw30DjSKDqriiZh79Zc2R41jGveSORyqCxCrHUY2f8s6nhpiftI pXfg3LJ2bsGHIz0b16Lhwbl24dRB2isZe7HJSbTHgg2R9xOwNz7CYhZCx/AqxfG46t+a 3+9fymVmflru4ipatJBIDV67tDWtiA9LdB6OlwsQOebEwELm/S7FzEq8sEQGeEoQdNYQ WNmi+FWCFEsK7OSvhexITo4BdEkX2WoffzzHZDFoRnRZyX/o/+9jiJNe1nxX7PHcH9Pr NKXQ== X-Gm-Message-State: AA+aEWZnsSRiU74kwMBnp26MoerdteLkA2Ar4Vtl2QDu7/GqI11vSgYV iggD3MDqWB0jxqr8RxJ5OrsFAC/h19lSPuAd5UxNxg== X-Google-Smtp-Source: AFSGD/X7Ddtv0rG8LgRp7WUHzAANrXPGsIxsOgSRYYYTcwp9WD10UJRVgl+KcxdMtlfGEsludjcfVGg1iFFaA6aO9ys= X-Received: by 2002:ab0:3484:: with SMTP id c4mr7587499uar.39.1545318594546; Thu, 20 Dec 2018 07:09:54 -0800 (PST) MIME-Version: 1.0 References: <20181220104246.5590-1-gavin.hu@arm.com> <20181220104246.5590-5-gavin.hu@arm.com> In-Reply-To: From: David Marchand Date: Thu, 20 Dec 2018 16:09:43 +0100 Message-ID: To: "Gavin Hu (Arm Technology China)" Cc: "dev@dpdk.org" , Thomas Monjalon , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "bruce.richardson@intel.com" , "chaozhu@linux.vnet.ibm.com" , nd , Honnappa Nagarahalli Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v1 4/5] spinlock: move the implementation to arm specific file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 15:09:55 -0000 On Thu, Dec 20, 2018 at 3:36 PM Gavin Hu (Arm Technology China) < Gavin.Hu@arm.com> wrote: > >> On Thu, Dec 20, 2018 at 11:44 AM Gavin Hu > wrote: > >> remove the hard code #ifdef RTE_FORCE_INTRINSICS, move the > implementation > >> to the arm specific file, x86 and POWER have their own implementations= . > > > No, x86 and ppc define their own implementation when _not_ having > RTE_FORCE_INTRINSICS. > > David Marchand > > Hi David, > > Your reply is out of format, I re-format it to text based. > I suppose this is an issue with your mail client. > Yes, x86 and ppc define their own implementation, so this change is arm > specific. > Only arm have RTE_FORCE_INTRINSICS, x86 and ppc don't define it in the > config files. > This change breaks the use of intrinsics in x86 case at least. $ git reset --hard origin/master HEAD is now at 476c847 malloc: add option --match-allocations $ git am ~/Downloads/v1-4-5-spinlock-move-the-implementation-to-arm-specific-file.pa= tch Applying: spinlock: move the implementation to arm specific file # default config $ rm -rf master; make defconfig O=3Dmaster && make -j4 O=3Dmaster [...] Build complete [x86_64-native-linuxapp-gcc] # then enable use of intrinsics $ echo CONFIG_RTE_FORCE_INTRINSICS=3Dy >> master/.config && make O=3Dmaster [...] CC eal.o In file included from /home/dmarchan/git/pub/dpdk/master/include/rte_spinlock.h:12:0, from /home/dmarchan/git/pub/dpdk/master/include/rte_malloc_heap.h:10, from /home/dmarchan/git/pub/dpdk/master/include/rte_eal_memconfig.h:12, from /home/dmarchan/git/pub/dpdk/lib/librte_eal/linuxapp/eal/eal.c:35: /home/dmarchan/git/pub/dpdk/master/include/generic/rte_spinlock.h:58:1: error: =E2=80=98rte_spinlock_lock=E2=80=99 used but never defined [-Werror] rte_spinlock_lock(rte_spinlock_t *sl); ^ /home/dmarchan/git/pub/dpdk/master/include/generic/rte_spinlock.h:67:1: error: =E2=80=98rte_spinlock_unlock=E2=80=99 used but never defined [-Werro= r] rte_spinlock_unlock (rte_spinlock_t *sl); ^ /home/dmarchan/git/pub/dpdk/master/include/generic/rte_spinlock.h:78:1: error: =E2=80=98rte_spinlock_trylock=E2=80=99 used but never defined [-Werr= or] rte_spinlock_trylock (rte_spinlock_t *sl); ^ cc1: all warnings being treated as errors make[5]: *** [eal.o] Error 1 make[4]: *** [eal] Error 2 --=20 David Marchand