DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Cc: dev@dpdk.org, hofors@lysator.liu.se, harry.van.haaren@intel.com,
	 Stefan Sundkvist <stefan.sundkvist@ericsson.com>
Subject: Re: [PATCH v2] service: extend service function call statistics
Date: Wed, 2 Oct 2024 20:26:08 +0200	[thread overview]
Message-ID: <CAJFAV8wz6H8oaZ2DzL6L6SxkytyYFys5Wx6F-AjpuJ8862177A@mail.gmail.com> (raw)
In-Reply-To: <20240909191103.697554-1-mattias.ronnblom@ericsson.com>

Hello Mattias,

On Mon, Sep 9, 2024 at 9:28 PM Mattias Rönnblom
<mattias.ronnblom@ericsson.com> wrote:
> @@ -46,9 +49,21 @@ testsuite_teardown(void)
>  static int32_t dummy_cb(void *args)
>  {
>         RTE_SET_USED(args);
> -       service_tick++;
> +
> +       service_calls++;
> +
> +       switch (rte_rand_max(3)) {
> +       case 0:
> +               return 0;
> +       case 1:
> +               service_idle_calls++;
> +               return -EAGAIN;
> +       default:
> +               service_error_calls++;
> +               return -ENOENT;
> +       }
> +
>         rte_delay_ms(SERVICE_DELAY);
> -       return 0;
>  }
>
>  static int32_t dummy_mt_unsafe_cb(void *args)

Coverity flagged this patch with issue #445158.
rte_delay_ms() is now unreachable.

I suppose this delay is not that important for the unit test and we
can remove it, but as I am not sure I'll let you have a look and send
a fix.

Thanks.


-- 
David Marchand


  parent reply	other threads:[~2024-10-02 18:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 19:15 [RFC] " Mattias Rönnblom
2024-01-25 23:19 ` Morten Brørup
2024-01-26  8:28   ` Mattias Rönnblom
2024-01-26 10:07     ` Morten Brørup
2024-01-27 19:31       ` Mattias Rönnblom
2024-01-29 12:50         ` Van Haaren, Harry
2024-01-30  7:16           ` Mattias Rönnblom
2024-08-09 20:25 ` [PATCH] " Mattias Rönnblom
2024-09-09 19:11   ` [PATCH v2] " Mattias Rönnblom
2024-09-10  1:19     ` fengchengwen
2024-09-10  7:19       ` Mattias Rönnblom
2024-09-12  9:18     ` Van Haaren, Harry
2024-10-01 15:24     ` David Marchand
2024-10-02 18:26     ` David Marchand [this message]
2024-10-02 18:56       ` Mattias Rönnblom
2024-10-02 19:08         ` David Marchand
2024-10-02 19:43           ` Mattias Rönnblom
2024-10-03  9:53             ` Van Haaren, Harry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wz6H8oaZ2DzL6L6SxkytyYFys5Wx6F-AjpuJ8862177A@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=hofors@lysator.liu.se \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stefan.sundkvist@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).