From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 295D2A00C5;
Thu, 15 Sep 2022 09:47:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 17C8540E28;
Thu, 15 Sep 2022 09:47:32 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 90DF640156
for <dev@dpdk.org>; Thu, 15 Sep 2022 09:47:29 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1663228049;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=HRBJP5USYr+lgrOp+ApCNMPygGI3cG+w4YRQ/BTwiFk=;
b=eUZndmhIdIfM6bJhoQMIs0NBNEj58u5lYMNdiUblS1eeiiKdScIK3Cru6REalkVdI0LZqt
6LmSq3ZTEEa3c5X6TvY8PpiSynrIuiIOHgQSzBhi/3DuC3KLwXd+Z26dul2LOQcS660cSN
T2pDH0z0K+bqgusXRCFSjn5M99I+f4c=
Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com
[209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id
us-mta-158-YkyHOGxjMm-p7wkblkvf_Q-1; Thu, 15 Sep 2022 03:47:27 -0400
X-MC-Unique: YkyHOGxjMm-p7wkblkvf_Q-1
Received: by mail-lj1-f200.google.com with SMTP id
e1-20020a2e8ec1000000b0026c27b66a2aso1698556ljl.11
for <dev@dpdk.org>; Thu, 15 Sep 2022 00:47:27 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=cc:to:subject:message-id:date:from:in-reply-to:references
:mime-version:x-gm-message-state:from:to:cc:subject:date;
bh=HRBJP5USYr+lgrOp+ApCNMPygGI3cG+w4YRQ/BTwiFk=;
b=iOkQP4Xe+GmVpNBCwu2K4GoEgPcivFAyJE2UPgLjVlleCm/NSnIDIScZX9Oiae8d58
4Bjzlndrzsn3MD+pCgdzp0zaBm+EBootoT/oaG6OS6ChI9GyMEbTWDdCfJcZIljU/JfJ
y+AX03i1+m1GmqL+YOuUTXvoi//31uOZUekllsUSd7UZuzTyzshSwcjRC+JguFtBfLkI
RX0QRydl1WqJyF5LCgU1V5XA1FuJyKN7top4ej8ZeOM81DJvBoaEm2KZm3fWZDtQd+az
cd3m/WjFpghpc2zuUpIY1ll1m7UmHYzdAwJHvWJxTy2tqSbEOYKT+Y0snQ8n3OUNPqb3
zKLQ==
X-Gm-Message-State: ACgBeo1DrDibjbcTg3T8HvhnBwbI5VZpPjV0meyFS1TDb1A5fSfCDkOj
4UL4zuXf32PFrhg5PT7wpRbE3TDMX34+rfIxhdlNB0rHeyXsj80BpH9Lq0Ze5UqbKkggldfoAoR
tXknsk8a8L/vB4v2n2RE=
X-Received: by 2002:a05:6512:c1:b0:497:acd3:10cf with SMTP id
c1-20020a05651200c100b00497acd310cfmr12800938lfp.484.1663228046385;
Thu, 15 Sep 2022 00:47:26 -0700 (PDT)
X-Google-Smtp-Source: AA6agR4P7Ku52z9Hk8hkSkAy/rcWQNGqY3XHnjDz5uytqJZE8B3/+KegkPya8VoMcm2YdDIzXhWX02e/LK5FK0D4l94=
X-Received: by 2002:a05:6512:c1:b0:497:acd3:10cf with SMTP id
c1-20020a05651200c100b00497acd310cfmr12800928lfp.484.1663228046089; Thu, 15
Sep 2022 00:47:26 -0700 (PDT)
MIME-Version: 1.0
References: <20220810074518.1695013-1-leyi.rong@intel.com>
<20220915021452.272075-1-leyi.rong@intel.com>
<20220915021452.272075-2-leyi.rong@intel.com>
In-Reply-To: <20220915021452.272075-2-leyi.rong@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 15 Sep 2022 09:47:15 +0200
Message-ID: <CAJFAV8x+6ukkBWSB=BMJo1b2U70-e=cUmm9gitReCR=M17g_Dg@mail.gmail.com>
Subject: Re: [PATCH v3 1/2] member: implement NitroSketch mode
To: Leyi Rong <leyi.rong@intel.com>
Cc: ferruh.yigit@xilinx.com, suanmingm@nvidia.com, yipeng1.wang@intel.com,
zaoxingliu@gmail.com, sameh.gobriel@intel.com, dev@dpdk.org
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Thu, Sep 15, 2022 at 4:15 AM Leyi Rong <leyi.rong@intel.com> wrote:
>
> Sketching algorithm provide high-fidelity approximate measurements and
> appears as a promising alternative to traditional approaches such as
> packet sampling.
>
> NitroSketch [1] is a software sketching framework that optimizes
> performance, provides accuracy guarantees, and supports a variety of
> sketches.
>
> This commit adds a new data structure called sketch into
> membership library. This new data structure is an efficient
> way to profile the traffic for heavy hitters. Also use min-heap
> structure to maintain the top-k flow keys.
>
> [1] Zaoxing Liu, Ran Ben-Basat, Gil Einziger, Yaron Kassner, Vladimir
> Braverman, Roy Friedman, Vyas Sekar, "NitroSketch: Robust and General
> Sketch-based Monitoring in Software Switches", in ACM SIGCOMM 2019.
> https://dl.acm.org/doi/pdf/10.1145/3341302.3342076
>
> Signed-off-by: Alan Liu <zaoxingliu@gmail.com>
> Signed-off-by: Yipeng Wang <yipeng1.wang@intel.com>
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> ---
> lib/member/meson.build | 42 +-
> lib/member/rte_member.c | 75 ++++
> lib/member/rte_member.h | 154 ++++++-
> lib/member/rte_member_heap.h | 424 ++++++++++++++++++
> lib/member/rte_member_sketch.c | 594 ++++++++++++++++++++++++++
> lib/member/rte_member_sketch.h | 97 +++++
> lib/member/rte_member_sketch_avx512.c | 69 +++
> lib/member/rte_member_sketch_avx512.h | 36 ++
> lib/member/rte_xxh64_avx512.h | 117 +++++
> lib/member/version.map | 9 +
> 10 files changed, 1613 insertions(+), 4 deletions(-)
> create mode 100644 lib/member/rte_member_heap.h
> create mode 100644 lib/member/rte_member_sketch.c
> create mode 100644 lib/member/rte_member_sketch.h
> create mode 100644 lib/member/rte_member_sketch_avx512.c
> create mode 100644 lib/member/rte_member_sketch_avx512.h
> create mode 100644 lib/member/rte_xxh64_avx512.h
>
> diff --git a/lib/member/meson.build b/lib/member/meson.build
> index e06fddc240..8de0c09a6a 100644
> --- a/lib/member/meson.build
> +++ b/lib/member/meson.build
> @@ -7,6 +7,46 @@ if is_windows
> subdir_done()
> endif
>
> -sources = files('rte_member.c', 'rte_member_ht.c', 'rte_member_vbf.c')
> +sources = files('rte_member.c', 'rte_member_ht.c', 'rte_member_vbf.c', 'rte_member_sketch.c')
> headers = files('rte_member.h')
> deps += ['hash']
> +includes += include_directories('../hash', '../ring')
> +
> +# compile AVX512 version if:
> +# we are building 64-bit binary AND binutils can generate proper code
> +if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok
> + # compile AVX512 version if either:
> + # a. we have AVX512 supported in minimum instruction set
> + # baseline
> + # b. it's not minimum instruction set, but supported by
> + # compiler
> + #
> + # in former case, just add avx512 C file to files list
> + # in latter case, compile c file to static lib, using correct
> + # compiler flags, and then have the .o file from static lib
> + # linked into main lib.
> +
> + #check if all required flags already enabled
> + sketch_avx512_flags = ['__AVX512F__', '__AVX512DQ__', '__AVX512IFMA__']
> +
> + sketch_avx512_on = true
> + foreach f:sketch_avx512_flags
> + if cc.get_define(f, args: machine_args) == ''
> + sketch_avx512_on = false
> + endif
> + endforeach
> +
> + if sketch_avx512_on == true
> + cflags += ['-DCC_AVX512_SUPPORT']
> + sources += files('rte_member_sketch_avx512.c')
> + elif cc.has_multi_arguments('-mavx512f', '-mavx512dq', '-mavx512ifma')
> + cflags += ['-DCC_AVX512_SUPPORT']
> + cflags += ['-mavx512f', '-mavx512dq', '-mavx512ifma']
No.
Again, you can't push AVX512 flags to the variable cflags.
On my laptop, running with Fedora 36:
$ DPDK_TEST=member_autotest ./build-gcc/app/test/dpdk-test --no-huge -m 2048
EAL: Detected CPU lcores: 12
EAL: Detected NUMA nodes: 1
EAL: Detected shared linkage of DPDK
EAL: Multi-process socket /run/user/1000/dpdk/rte/mp_socket
EAL: Selected IOVA mode 'VA'
APP: HPET is not enabled, using TSC as default timer
RTE>>member_autotest
Expected error section begin...
rte_member_create_vbf(): Membership vBF create with invalid parameters
rte_member_create_vbf(): Membership vBF create with invalid parameters
rte_member_create_vbf(): Membership vBF create with invalid parameters
rte_member_create_ht(): Membership HT create with invalid parameters
rte_member_create_ht(): Membership HT create with invalid parameters
rte_member_create_ht(): Membership HT create with invalid parameters
Expected error section end...
rte_member_create_ht(): Hash table based filter created, the table has
65536 entries, 4096 buckets
rte_member_create(): Creating a setsummary table with mode 0
rte_member_create_ht(): Hash table based filter created, the table has
65536 entries, 4096 buckets
rte_member_create(): Creating a setsummary table with mode 0
rte_member_create_ht(): Hash table based filter created, the table has
65536 entries, 4096 buckets
rte_member_create(): Creating a setsummary table with mode 0
Illegal instruction (core dumped)
The reason is the same as I reported earlier, and this can be
reproduced like this:
$ touch lib/member/rte_member_sketch*
$ ninja -C build-gcc -vv
ninja: Entering directory `build-gcc'
[1/9] ccache gcc -Ilib/member/libsketch_avx512_tmp.a.p -Ilib/member
-I../lib/member -Ilib/hash -I../lib/hash -Ilib/ring -I../lib/ring -I.
-I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include
-Ilib/eal/linux/include -I../lib/eal/linux/include
-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs
-I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry
-I../lib/telemetry -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64
-Wall -Winvalid-pch -Wextra -Werror -O3 -g -include rte_config.h
-Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral
-Wformat-security -Wmissing-declarations -Wmissing-prototypes
-Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare
-Wstrict-prototypes -Wundef -Wwrite-strings
-Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
-fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-Wno-format-truncation -DCC_AVX512_SUPPORT -mavx512f -mavx512dq
-mavx512ifma -MD -MQ
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o -MF
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o.d -o
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o -c
../lib/member/rte_member_sketch_avx512.c
[2/9] ccache gcc -Ilib/librte_member.a.p -Ilib -I../lib -Ilib/hash
-I../lib/hash -Ilib/ring -I../lib/ring -Ilib/member -I../lib/member
-I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include
-Ilib/eal/linux/include -I../lib/eal/linux/include
-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs
-I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry
-I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf
-Ilib/mempool -I../lib/mempool -Ilib/rcu -I../lib/rcu
-fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
-Wextra -Werror -O3 -g -include rte_config.h -Wcast-qual -Wdeprecated
-Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wold-style-definition
-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
-fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-Wno-format-truncation -DCC_AVX512_SUPPORT -mavx512f -mavx512dq
-mavx512ifma -DRTE_LOG_DEFAULT_LOGTYPE=lib.member -MD -MQ
lib/librte_member.a.p/member_rte_member.c.o -MF
lib/librte_member.a.p/member_rte_member.c.o.d -o
lib/librte_member.a.p/member_rte_member.c.o -c
../lib/member/rte_member.c
Here, the rte_member.c file is compiled with "-mavx512f -mavx512dq
-mavx512ifma".
The compiler might insert AVX512 instruction in this generic code.
[3/9] ccache gcc -Ilib/librte_member.a.p -Ilib -I../lib -Ilib/hash
-I../lib/hash -Ilib/ring -I../lib/ring -Ilib/member -I../lib/member
-I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include
-Ilib/eal/linux/include -I../lib/eal/linux/include
-Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common
-I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs
-I../lib/kvargs -Ilib/metrics -I../lib/metrics -Ilib/telemetry
-I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf
-Ilib/mempool -I../lib/mempool -Ilib/rcu -I../lib/rcu
-fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch
-Wextra -Werror -O3 -g -include rte_config.h -Wcast-qual -Wdeprecated
-Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations
-Wmissing-prototypes -Wnested-externs -Wold-style-definition
-Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef
-Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned
-Wno-missing-field-initializers -Wno-zero-length-bounds -D_GNU_SOURCE
-fPIC -march=native -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API
-Wno-format-truncation -DCC_AVX512_SUPPORT -mavx512f -mavx512dq
-mavx512ifma -DRTE_LOG_DEFAULT_LOGTYPE=lib.member -MD -MQ
lib/librte_member.a.p/member_rte_member_sketch.c.o -MF
lib/librte_member.a.p/member_rte_member_sketch.c.o.d -o
lib/librte_member.a.p/member_rte_member_sketch.c.o -c
../lib/member/rte_member_sketch.c
Idem.
[4/9] rm -f lib/member/libsketch_avx512_tmp.a && gcc-ar csrDT
lib/member/libsketch_avx512_tmp.a
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o
[5/9] rm -f lib/librte_member.a && gcc-ar csrD lib/librte_member.a
lib/librte_member.a.p/member_rte_member.c.o
lib/librte_member.a.p/member_rte_member_ht.c.o
lib/librte_member.a.p/member_rte_member_vbf.c.o
lib/librte_member.a.p/member_rte_member_sketch.c.o
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o
[6/9] /usr/bin/meson --internal exe --capture lib/member.sym_chk --
/home/dmarchan/git/pub/dpdk.org/buildtools/check-symbols.sh
/home/dmarchan/git/pub/dpdk.org/lib/member/version.map
lib/librte_member.a
[7/9] gcc -o lib/librte_member.so.23.0
lib/member/libsketch_avx512_tmp.a.p/rte_member_sketch_avx512.c.o
lib/librte_member.a.p/member_rte_member.c.o
lib/librte_member.a.p/member_rte_member_ht.c.o
lib/librte_member.a.p/member_rte_member_vbf.c.o
lib/librte_member.a.p/member_rte_member_sketch.c.o -Wl,--as-needed
-Wl,--no-undefined -Wl,-O1 -shared -fPIC -Wl,--start-group
-Wl,-soname,librte_member.so.23 -Wl,--no-as-needed -pthread -lm -ldl
-lnuma -lfdt -larchive '-Wl,-rpath,$ORIGIN/'
-Wl,-rpath-link,/home/dmarchan/git/pub/dpdk.org/build-gcc/lib
lib/librte_eal.so.23.0 lib/librte_kvargs.so.23.0
lib/librte_telemetry.so.23.0 lib/librte_hash.so.23.0
lib/librte_net.so.23.0 lib/librte_mbuf.so.23.0
lib/librte_mempool.so.23.0 lib/librte_ring.so.23.0
lib/librte_rcu.so.23.0
-Wl,--version-script=/home/dmarchan/git/pub/dpdk.org/lib/member/version.map
/usr/lib64/libbsd.so -Wl,--end-group
[8/9] /usr/bin/meson --internal symbolextractor
/home/dmarchan/git/pub/dpdk.org/build-gcc lib/librte_member.so.23.0
lib/librte_member.so.23.0
lib/librte_member.so.23.0.p/librte_member.so.23.0.symbols
> + sketch_avx512_tmp = static_library('sketch_avx512_tmp',
> + 'rte_member_sketch_avx512.c',
> + include_directories: includes,
> + dependencies: static_rte_eal,
> + c_args: cflags)
> + objs += sketch_avx512_tmp.extract_objects('rte_member_sketch_avx512.c')
> + endif
> +endif
--
David Marchand