From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B539A0547; Thu, 17 Nov 2022 12:41:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1584F40E03; Thu, 17 Nov 2022 12:41:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 40ED040DDA for ; Thu, 17 Nov 2022 12:41:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668685280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rXPGHqkvsjk6Lz4A/qWBOoLxX8d4vJI9mDXBg7GIi1k=; b=ZMjgSGHpdxN0sfHyjsuPUy1aBW7GUh7twDZG6ja8Gb4+sEj9YrZ0Cmee24fehn6l0CTrZk c8gBANHnyBOx25u2x88jM24dKP0mQmSHwK71TiD59a6OWrN4e/q5y5gGiLfrdXQnOV5k1B 3Q+UMimggBW2zUp+dV4qiI8DqN4RIKg= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-607-Hacg9_pDPkG0Qebl3QW4jQ-1; Thu, 17 Nov 2022 06:41:19 -0500 X-MC-Unique: Hacg9_pDPkG0Qebl3QW4jQ-1 Received: by mail-pf1-f199.google.com with SMTP id cj8-20020a056a00298800b0056cee8a0cf8so1041848pfb.9 for ; Thu, 17 Nov 2022 03:41:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rXPGHqkvsjk6Lz4A/qWBOoLxX8d4vJI9mDXBg7GIi1k=; b=BhHkpqcWCn3Bl3GxdgpP6eSjCt5thFmIbFTpEOJulhu+TNnstGlg3085YD1uTUz3tW PjszF48aKR6c+RIyUo6o+aQUHjlqwJEhq35U0WQy5Hen90xi9WuRPGcLUsh00ImGLcKa gxBVdayhkbBbASw2aZWLAUid6yPSdhVQwwiMPAMc8zdjfd6ao1cSwiZ3NxkfwgR1f3jb 5Whs9PgYdfOZmZhjW6xDlQxPPFyFeAkuJFc5TqGDxK8zfZtIc6orS9O/U0OyPX+yahFn bFzvpugsZumv6rUxs923iPeIgur1HLjN7AuvJKxgkaa0+j1G8Miu7M4dVWWaq1SA6huo x6sg== X-Gm-Message-State: ANoB5pmcMQUh9hZIK7SHXW7wfQzgf/6FD+wLaosRWrvWdQGiWbkNbWpg U2L9Wr3c1NaXrWVhRL+u9OiogiHGSICikokUuqBpYUAsQqud/BSf+zJUmxieTPOTJH347xVB6Ku SQNKHjlKK8fXszgqXV5o= X-Received: by 2002:a17:903:2448:b0:188:f5c7:4d23 with SMTP id l8-20020a170903244800b00188f5c74d23mr681374pls.125.1668685278477; Thu, 17 Nov 2022 03:41:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf4wu4R9tftxG40AjFm52OvVNqEmg2skas1Htf+o1GVLpr601dOtZ1+iNQQhnrm6Ll52aML5hHmnRiiq5RCPAi4= X-Received: by 2002:a17:903:2448:b0:188:f5c7:4d23 with SMTP id l8-20020a170903244800b00188f5c74d23mr681354pls.125.1668685278220; Thu, 17 Nov 2022 03:41:18 -0800 (PST) MIME-Version: 1.0 References: <20221117085537.24372-1-suanmingm@nvidia.com> In-Reply-To: <20221117085537.24372-1-suanmingm@nvidia.com> From: David Marchand Date: Thu, 17 Nov 2022 12:41:07 +0100 Message-ID: Subject: Re: [PATCH] app/testpmd: fix action destruction memory leak To: Suanming Mou Cc: Aman Singh , Yuying Zhang , dev@dpdk.org, Andrew Rybchenko , Ferruh Yigit , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 17, 2022 at 9:56 AM Suanming Mou wrote: > > In case action handle destroy fails, the job memory was not freed > properly. This commit fixes the possible memory leak in the action > handle destruction failed case. > > Fixes: c9dc03840873 ("ethdev: add indirect action async query") > Reported-by: David Marchand > Signed-off-by: Suanming Mou LGTM. Reviewed-by: David Marchand Thanks. -- David Marchand