From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A31342D12; Wed, 21 Jun 2023 10:36:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5A23406BC; Wed, 21 Jun 2023 10:36:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4593D4068E for ; Wed, 21 Jun 2023 10:36:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687336588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jNZHY7TMzN2ZHU3tMHHx6iAZ/uvC3cehtB0Kkt9sIyA=; b=LH7kSmeW0HVEFfBsqMrpIGTFJDmALfnQgsDffKrLC/9Hq1/9HRT1IPn+kPBljV4jHXMfGj wfcvNgbto4+ihk8arULYbo428QurrWuhQV819rxyhJqLrysmpiH1P1jFP9Nx2o2A/YuxS+ GbHMyIqcOa9qaLXWJWd1PY0m6pUK66g= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-Dm6yER0aNxyHuyAgnt1-9A-1; Wed, 21 Jun 2023 04:36:27 -0400 X-MC-Unique: Dm6yER0aNxyHuyAgnt1-9A-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-1ad17b9fcd8so380291fac.0 for ; Wed, 21 Jun 2023 01:36:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687336587; x=1689928587; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jNZHY7TMzN2ZHU3tMHHx6iAZ/uvC3cehtB0Kkt9sIyA=; b=T8D/KV5VNyU/XM0vZTivcVHSYrSbbPVsKCZSV+SYgCxXMLM2bGlUEP3rDgbBkdempM u9tMUnhlTJx0wGbBn+2MfpORpzf5mDcdK4t5g/auFcdtEkf9HQONPu9s2G6h6y9FXl7P wZMP9ga9k2WV4N2lR7PiEexw3O2h/Do/ND5fqUR1a6g5CLix6uDdJ5n5zp8OmfnLifxh 7wUrDZs12zfjfTANnBAJyiL7+xCt/JX6BqklqlRfwmz1MG//ojDvYcPATZpxoSksNJFk sB2kY7TZ/shJPpfkO6xwNd/qYsfk73xArgCRvR4uGgZq+/mWxbQwO2qLqAIzSBZe+rS2 V9fg== X-Gm-Message-State: AC+VfDxbUQ+pEa+ux9a3/O51kw2We3Ne7zhITN3xNuO5vWOrK7FV3rX0 IpVcK3MDnxC2F0CzRBd4M1j/hx+H1KYiFAwmfcMmG0nupm95ubWWU/pjJQ1GTqaOok6Zp62KnzK 8b6yGwyqiH5wdNRWFn2I= X-Received: by 2002:a05:6870:ecac:b0:19e:fa1f:fc2f with SMTP id eo44-20020a056870ecac00b0019efa1ffc2fmr12984284oab.38.1687336586949; Wed, 21 Jun 2023 01:36:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5vGusCGgaDbGWwsgpV/VR7+BBJDY9g1ny7jZGQTV3L5/NrdiF/9krosfaDflQhiwVqWYCkqQrrkc6+GdIhGKc= X-Received: by 2002:a05:6870:ecac:b0:19e:fa1f:fc2f with SMTP id eo44-20020a056870ecac00b0019efa1ffc2fmr12984278oab.38.1687336586700; Wed, 21 Jun 2023 01:36:26 -0700 (PDT) MIME-Version: 1.0 References: <20230615070744.93340-1-changfengnan@bytedance.com> In-Reply-To: <20230615070744.93340-1-changfengnan@bytedance.com> From: David Marchand Date: Wed, 21 Jun 2023 10:36:15 +0200 Message-ID: Subject: Re: [PATCH v2] eal: fix prompt info when remap_segment failed To: Fengnan Chang Cc: anatoly.burakov@intel.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 15, 2023 at 9:08=E2=80=AFAM Fengnan Chang wrote: > > When there is not enough space to memsegs, we should prompt > which configuration should be modified instead of printing > some numbers. > > Signed-off-by: Fengnan Chang This lgtm, but I have a question: $ git grep 'RTE_STR(RTE_MAX' app/test/test_eal_flags.c: "-l", RTE_STR(RTE_MAX_LCORE) }; app/test/test_eal_flags.c: "-l", "1-"RTE_STR(RTE_MAX_LCORE) }; lib/eal/common/eal_common_dynmem.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/common/eal_common_dynmem.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/freebsd/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/linux/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); lib/eal/linux/eal_memory.c: RTE_STR(RTE_MAX_MEMSEG_LISTS)); The first two hits are false positives, but the mentions of RTE_MAX_MEMSEG_LISTS are all in log messages. Could you have a look and confirm it is related to your change? --=20 David Marchand