* [PATCH] gpu/cuda: fix build
@ 2022-09-23 8:25 Thomas Monjalon
2022-09-23 8:29 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2022-09-23 8:25 UTC (permalink / raw)
To: dev; +Cc: Elena Agostini, Bruce Richardson, Dmitry Kozlyuk
A recent commit removed errno.h from rte_common.h.
It has to be added in various places where it is used,
and wad implicitly included via rte_common.h,
but was forgotten in gpu/cuda.
As a result, the compilation is broken:
drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
Note that rte_errno.h does not include errno.h.
The include of errno.h is added.
Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/gpu/cuda/common.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/cuda/common.h b/drivers/gpu/cuda/common.h
index 5144694d60..e809988503 100644
--- a/drivers/gpu/cuda/common.h
+++ b/drivers/gpu/cuda/common.h
@@ -6,6 +6,7 @@
#define CUDA_COMMON_H
#include <dlfcn.h>
+#include <errno.h>
#include <rte_common.h>
#include <rte_log.h>
--
2.36.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu/cuda: fix build
2022-09-23 8:25 [PATCH] gpu/cuda: fix build Thomas Monjalon
@ 2022-09-23 8:29 ` David Marchand
2022-09-23 8:41 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2022-09-23 8:29 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Elena Agostini, Bruce Richardson, Dmitry Kozlyuk
On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A recent commit removed errno.h from rte_common.h.
> It has to be added in various places where it is used,
> and wad implicitly included via rte_common.h,
was*
> but was forgotten in gpu/cuda.
>
> As a result, the compilation is broken:
> drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
>
> Note that rte_errno.h does not include errno.h.
> The include of errno.h is added.
>
> Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
I installed the cuda library headers and can confirm the build issue is fixed.
Tested-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu/cuda: fix build
2022-09-23 8:29 ` David Marchand
@ 2022-09-23 8:41 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2022-09-23 8:41 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Elena Agostini, Bruce Richardson, Dmitry Kozlyuk
On Fri, Sep 23, 2022 at 10:29 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > A recent commit removed errno.h from rte_common.h.
> > It has to be added in various places where it is used,
> > and wad implicitly included via rte_common.h,
>
> was*
>
> > but was forgotten in gpu/cuda.
> >
> > As a result, the compilation is broken:
> > drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
> >
> > Note that rte_errno.h does not include errno.h.
> > The include of errno.h is added.
> >
> > Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-23 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23 8:25 [PATCH] gpu/cuda: fix build Thomas Monjalon
2022-09-23 8:29 ` David Marchand
2022-09-23 8:41 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).