From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1EDFA04B5; Mon, 11 Jan 2021 10:47:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EC84140CB8; Mon, 11 Jan 2021 10:47:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 65F90140CAF for ; Mon, 11 Jan 2021 10:47:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610358469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KQCAZk5CYyVXFx/p0gKt/InDC9DUN4gwT50rttWSqvc=; b=R0NzaWHqKimBSLVarWj/ltMkDA9a5i6Bx40pAjqCIQPk54A1I/08nqEblIEh75s5qe0fVD POXUKwpIi5CbdvDT5OnJHqB5dipkGw78OBkn2ulI1VjWiCm5jDXbETcus9cowH5oifqo+p z7+/NE1iSaTqxNuiUoW8bRoFFEixC7A= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-EHFZtnYkNPCp-Rz7PF28Lg-1; Mon, 11 Jan 2021 04:47:47 -0500 X-MC-Unique: EHFZtnYkNPCp-Rz7PF28Lg-1 Received: by mail-vs1-f69.google.com with SMTP id x16so4382760vsx.6 for ; Mon, 11 Jan 2021 01:47:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KQCAZk5CYyVXFx/p0gKt/InDC9DUN4gwT50rttWSqvc=; b=BxwcOPGXQj4HTjw4q2dhB9CDIDLQRMC7Mu/drnog0CthPG+JsHQbjZiBfOYHJxI2/a 5QdB5kpNc6z1dzjd4cTTtpqQ6KzdXl/9th45iQC05+i2hw1E+QhBv0ktbububE6nENgO g8LJoobVUsqPubb9dc0HcVM4jh4WUZugM4t0aJ+/I0b/BrfDxZL0j6R3LLBG11AgWYi2 O0UuDftiQkOS3CsxIQHAFAMCdeRu6EWcKKXhgni0ovoDuKeL1j6OPWwmp7bvKDxEsHCX 1tTauwX5bdalJJ2pcPbt0WiS2qIPnn02APbke5OP31R/LiGutTeplLsnVVWnOfAdoC8v 7Xwg== X-Gm-Message-State: AOAM531J7TGpnoNSEMOV5/cXKmyW3B3tvFajuCP7B+X/kC845FWF6Rz/ HU6k+cVBUcerhaOYKgsPFwmibjQRZyifX64EClEywDmJT4Tlx7nAgFAiv4aTetDvqiaKpQOXT6c Zk41N1FdPFh3WAFNE/8o= X-Received: by 2002:a67:2fd3:: with SMTP id v202mr12930948vsv.17.1610358467330; Mon, 11 Jan 2021 01:47:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJxerGW65WfuzisfQFuw6Pk+tVDEFq0u4eZr+HqF/P9XrjMHt1lK0lbVi001hjWV1XD4js2tmuIUgRnDcsFIoBg= X-Received: by 2002:a67:2fd3:: with SMTP id v202mr12930938vsv.17.1610358467108; Mon, 11 Jan 2021 01:47:47 -0800 (PST) MIME-Version: 1.0 References: <20200824094021.2323605-1-ferruh.yigit@intel.com> <20201119115900.4095566-1-ferruh.yigit@intel.com> In-Reply-To: <20201119115900.4095566-1-ferruh.yigit@intel.com> From: David Marchand Date: Mon, 11 Jan 2021 10:47:36 +0100 Message-ID: To: Ferruh Yigit Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [v21.02 v3 00/10] cppcheck X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 19, 2020 at 12:59 PM Ferruh Yigit wrote: > > Fix a few of issues identified by cppcheck. > There are more to address, cppcheck can be run as: > "cppcheck --enable=all --force ." > > These are very trivial issues, I think can be postponed to next release. > > Ferruh Yigit (10): > app/procinfo: fix redundant condition > app/procinfo: fix negative check on unsigned variable > app/procinfo: remove suspicious sizeof > app/procinfo: remove useless assignment > net/pcap: remove local variable shadowing outer one > net/bonding: remove local variable shadowing outer one > net/af_xdp: remove useless assignment > net/bnxt: fix redundant return > app/crypto-perf: remove always true condition > net/avp: remove always true condition Fixed style issue in the pcap patch, and applied the series. Thanks. -- David Marchand