From: David Marchand <david.marchand@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>,
Andy Moreton <amoreton@xilinx.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/sfc: allow control threads for counter queue polling
Date: Wed, 3 Nov 2021 14:00:33 +0100 [thread overview]
Message-ID: <CAJFAV8x0DOhQpEgACyTu_FkNyis571dEqd73CrwL+W0tftOrDQ@mail.gmail.com> (raw)
In-Reply-To: <20211103124021.251256-1-andrew.rybchenko@oktetlabs.ru>
On Wed, Nov 3, 2021 at 1:40 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> From: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
>
> MAE counters can be polled from a control thread if no service core is
> allocated for this.
>
> Signed-off-by: Viacheslav Galaktionov <viacheslav.galaktionov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
> ---
> The problem to require service cores for HW offload was raised by
> David on review in 21.08 release cycle.
>
> v2:
> - add sleep in the case of empty queue to avoid CPU burn
> - pair release/acquire for thread run/stop condition
The release notes update was dropped. Not sure it was intentional.
Otherwise, patch lgtm, thanks.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2021-11-03 13:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 7:03 [dpdk-dev] [PATCH] " Andrew Rybchenko
2021-10-21 20:23 ` Ferruh Yigit
2021-10-21 20:43 ` Ferruh Yigit
2021-10-21 20:28 ` David Marchand
2021-10-22 7:19 ` Andrew Rybchenko
2021-11-03 12:40 ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2021-11-03 13:00 ` David Marchand [this message]
2021-11-03 13:13 ` Andrew Rybchenko
2021-11-03 13:13 ` [dpdk-dev] [PATCH v3] " Andrew Rybchenko
2021-11-04 17:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x0DOhQpEgACyTu_FkNyis571dEqd73CrwL+W0tftOrDQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=amoreton@xilinx.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=viacheslav.galaktionov@oktetlabs.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).