From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f42.google.com (mail-ua1-f42.google.com [209.85.222.42]) by dpdk.org (Postfix) with ESMTP id 067211B532 for ; Wed, 19 Dec 2018 10:12:18 +0100 (CET) Received: by mail-ua1-f42.google.com with SMTP id z11so6716633uaa.10 for ; Wed, 19 Dec 2018 01:12:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j+NpBXOoLKX+fBec7Tdo5MLj408KbQcGutjJbv6IQzQ=; b=tv7gmbgR47ogKHJ5cduIcYN8j3Xi0JkzXyYu6gy5up2OHKHxOig7nlDVkQK3lCJuFK FTzyicY65JunzpFhHcJu3wp/6Wg/2RDjNH7W61HECPfaB9yg3kJSPof59DRwpWftLVJp FbuWxqQuSiJUIuDIMNikaLw5bhpDqXOdLsPDXtHWkggqT9/8HPjUC/6jIIdxYlu7OcJd pkSadLfLLYcXzAUivAppNaUCYebMxfFVGrqsf0Fq3AQwImUuCRPUG5FX0l8X9TdJlN3c IV5YoExe8S55FFvCHPOex5A9/6diO5ldYjaYz+U8dHw4eNThckicV5D2zriHAbR5yTCf CfkQ== X-Gm-Message-State: AA+aEWZ7rScA9LoLoO5+8beEVUzFM5V0hoCV8GD0ViS2DcGRKDA5m1IY P7NiQBFQbBq1HZfLUty+7e42ZkVcPH5ujHKqoe0aZA== X-Google-Smtp-Source: AFSGD/W3+rcIdYnu9tDvroG2oiEH9U+x0qkEpzxm8B3XYQyloZ3gkSnH7CUspHYiMaKbVkPLVtuaNzefUa+RmqzjCo0= X-Received: by 2002:ab0:2508:: with SMTP id j8mr30347uan.130.1545210737432; Wed, 19 Dec 2018 01:12:17 -0800 (PST) MIME-Version: 1.0 References: <20181203164724.GA12316@hmswarspite.think-freely.org> <20181204151457.GA31778@hmswarspite.think-freely.org> <20181205122124.GA6752@hmswarspite.think-freely.org> <20181218122500.GB2078@hmswarspite.think-freely.org> In-Reply-To: From: David Marchand Date: Wed, 19 Dec 2018 10:12:06 +0100 Message-ID: To: Neil Horman , Thomas Monjalon Cc: "Yigit, Ferruh" , dev@dpdk.org, Timothy Redaelli , adrien.mazarguil@6wind.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Marking symbols as experimental in the headers only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 09:12:18 -0000 On Tue, Dec 18, 2018 at 1:27 PM David Marchand wrote: > > On Tue, Dec 18, 2018 at 1:25 PM Neil Horman wrote: > >> On Tue, Dec 18, 2018 at 11:41:34AM +0100, David Marchand wrote: >> >> > The real issue in the end is that the __rte_experimental in headers is >> the >> > most important thing and can be missed during reviews. >> > But I found no easy way to detect this. >> > >> > Do you have any idea ? >> > >> The most direct way is to add a regular expression search to the script >> that >> checks the object files. That would be some tricky grep/awk magic, but it >> should be possible >> > So, wrote something that I hooked in rte.lib.mk. On a fresh master branch, I can see: == Build lib/librte_bbdev ERROR: rte_bbdev_dequeue_dec_ops is not marked as experimental in this library headers ERROR: rte_bbdev_dequeue_enc_ops is not marked as experimental in this library headers ERROR: rte_bbdev_devices is not marked as experimental in this library headers ERROR: rte_bbdev_enqueue_dec_ops is not marked as experimental in this library headers ERROR: rte_bbdev_enqueue_enc_ops is not marked as experimental in this library headers ERROR: rte_bbdev_op_pool_create is not marked as experimental in this library headers ERROR: rte_bbdev_op_type_str is not marked as experimental in this library headers == Build lib/librte_cryptodev ERROR: rte_crypto_asym_op_strings is not marked as experimental in this library headers ERROR: rte_crypto_asym_xform_strings is not marked as experimental in this library headers == Build lib/librte_vhost ERROR: rte_vhost_va_from_guest_pa is not marked as experimental in this library headers Those warnings seem valid, need to double check (bbdev is already known). But my script still needs some work to make it lighter... A fresh build went from: real 3m25.823s user 2m42.026s sys 1m2.730s to: real 3m42.442s user 2m56.733s sys 1m5.565s I think I'd rather adapt it to hook in checkpatches.sh. Maintainers can then ignore it when the check is broken (my regexp skills are lacking :)). -- David Marchand