From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by dpdk.org (Postfix) with ESMTP id DB6EC1B727 for ; Fri, 22 Mar 2019 18:23:13 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id z6so1833732vsc.0 for ; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ckb65Ig5nIAF25L/s2oW/9ivLYfr8qy+nuGmoEBsgLg=; b=YpHMouMvthDptNF0dDB8fPQnPA8eK9GafRAYguIHxJwXVlL/QVg4WLTvYCcKSOgIPE KpG3cYCq6mHD0NZ3/Bs5nH6w/lm3i2ysP1YKznoXYP7zJDVu8243V9TTWv2ylyOsAyZI gx6ZhwLbBYHWJ7UCPdKtXwv43v7jXyKZWmqcaNc0gkuWCYo1X42D/YWOPBRmBrxnGtYX 09aur26CgZ4yFCHAcpowrpmOTLlp09tFF3y/AOf8DVpe8I4bZW12j2SyQ6OQQEC5Y+kb qk3m6pGdfLE8caBQwHaO4c/Qcp9sOMBjza7kzcjWq+DwyLEX2/DGgajyXf5GmfclRqwI f1Wg== X-Gm-Message-State: APjAAAWffA4EHn4s+sloxvhduFDvhwfNLejlj809k1CS/n14u+ZeXUUS 8jwchN8C9B7jBZEc3DisHFULfa8WcgYptDMTpBHOmA== X-Google-Smtp-Source: APXvYqzRn45CpvCF65zy98cAuXaqxtpWZllJJjWQ/jIGvHLgzMTKDFWnP9dI5Ve+c4aPYW0WxY0o3Ctd89iRUCvFR8g= X-Received: by 2002:a67:ea02:: with SMTP id g2mr6623974vso.141.1553275393242; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> In-Reply-To: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> From: David Marchand Date: Fri, 22 Mar 2019 18:23:02 +0100 Message-ID: To: Maxime Coquelin Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , Andrew Rybchenko , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 17:23:14 -0000 On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin wrote: > > > On 3/22/19 2:37 PM, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > > > After: > > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > > > Fixes: af75078fece3 ("first public release") > > Cc:stable@dpdk.org > > While the patch is good, I wonder whether we should backport it. > Indeed, it might break some scripts parsing testpmd output. > > Any thoughts? > It seems unlikely, this feature is disabled by default. But yes, I would avoid backporting it. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 48BDFA00E6 for ; Fri, 22 Mar 2019 18:23:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DA941B72A; Fri, 22 Mar 2019 18:23:16 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by dpdk.org (Postfix) with ESMTP id DB6EC1B727 for ; Fri, 22 Mar 2019 18:23:13 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id z6so1833732vsc.0 for ; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ckb65Ig5nIAF25L/s2oW/9ivLYfr8qy+nuGmoEBsgLg=; b=YpHMouMvthDptNF0dDB8fPQnPA8eK9GafRAYguIHxJwXVlL/QVg4WLTvYCcKSOgIPE KpG3cYCq6mHD0NZ3/Bs5nH6w/lm3i2ysP1YKznoXYP7zJDVu8243V9TTWv2ylyOsAyZI gx6ZhwLbBYHWJ7UCPdKtXwv43v7jXyKZWmqcaNc0gkuWCYo1X42D/YWOPBRmBrxnGtYX 09aur26CgZ4yFCHAcpowrpmOTLlp09tFF3y/AOf8DVpe8I4bZW12j2SyQ6OQQEC5Y+kb qk3m6pGdfLE8caBQwHaO4c/Qcp9sOMBjza7kzcjWq+DwyLEX2/DGgajyXf5GmfclRqwI f1Wg== X-Gm-Message-State: APjAAAWffA4EHn4s+sloxvhduFDvhwfNLejlj809k1CS/n14u+ZeXUUS 8jwchN8C9B7jBZEc3DisHFULfa8WcgYptDMTpBHOmA== X-Google-Smtp-Source: APXvYqzRn45CpvCF65zy98cAuXaqxtpWZllJJjWQ/jIGvHLgzMTKDFWnP9dI5Ve+c4aPYW0WxY0o3Ctd89iRUCvFR8g= X-Received: by 2002:a67:ea02:: with SMTP id g2mr6623974vso.141.1553275393242; Fri, 22 Mar 2019 10:23:13 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> In-Reply-To: <3f88ea40-fbc3-1ee7-ecef-5dc93ad4ff83@redhat.com> From: David Marchand Date: Fri, 22 Mar 2019 18:23:02 +0100 Message-ID: To: Maxime Coquelin Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , Andrew Rybchenko , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322172302.YfFo_PUXJ37w0Opc3nKlv9rDcng9kGDjMbB0B_IjyoQ@z> On Fri, Mar 22, 2019 at 6:17 PM Maxime Coquelin wrote: > > > On 3/22/19 2:37 PM, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > > > After: > > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > > > Fixes: af75078fece3 ("first public release") > > Cc:stable@dpdk.org > > While the patch is good, I wonder whether we should backport it. > Indeed, it might break some scripts parsing testpmd output. > > Any thoughts? > It seems unlikely, this feature is disabled by default. But yes, I would avoid backporting it. -- David Marchand