From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B21CFA0553; Mon, 17 Feb 2020 15:57:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 902971DAB4; Mon, 17 Feb 2020 15:57:40 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 93E311DAB3 for ; Mon, 17 Feb 2020 15:57:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581951459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o+hqTdANYsaWGz6ACelgMQNT1HqdLMXR3/qkoHF5C8k=; b=aq/IjlGDcewrrAYro+M1/74wchWKqAyyLBuLLPEvLsW1NaqSnNCFOTStjLmudyCEt68A/Q 3qCRSs2o9De0ZBPusE8iFtvjnlue7ulgfR6Lbft+90+9fVLPBRaPimhnv507mPZIdl/GrT QaBoURzveKPIUpkeTbc9qGI8aQDa/Lk= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-YO7Ump5bO8uL39nN3MNRxQ-1; Mon, 17 Feb 2020 09:57:37 -0500 Received: by mail-vk1-f200.google.com with SMTP id d28so6893944vkn.15 for ; Mon, 17 Feb 2020 06:57:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=o+hqTdANYsaWGz6ACelgMQNT1HqdLMXR3/qkoHF5C8k=; b=aGe4OYdibihuVZI0rGih3A0iLXbyenofSH33XFGIv5n0b7ipM9UiIZNrrrye7JSS5Q 7weNUG5UoSEMIC45Cv5gD2pdjU/VVclrB8dcO/xGgF9oScDTjhRh3TBiEj2NxmLOgwEK 78L28LODNfTlD5RjpLCD1iSZJQ/N+Ku1F88XHq6F7lpAb9igKjx6zspOrL20QWwK/SOT Yv93z6sZ1A/LzNKIaRB3bc8kJUTgDkbWbB0ghZLNFJyiBq7vtu0leLedTGGPBrmDX1l5 gXz3Cxh/ByfcIWScjrpdoAn5z25dR961XIhNdaN2cb7GgwceUOEAe0Qo558fm77CVNiU 9MeQ== X-Gm-Message-State: APjAAAXBYAxVpPVOxGGIOdLX4evdiO6Jgc267rAUSOf1AnLvBS1k5zTh hrnWQT2l9HUwTVtASxXrB8sDCZcgwNrGMOObA+smlgZOOObzpw721uUntr1UUM/CJxWwMXQNW+6 dq86wPZ+C8GcbM8paKrk= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr8502833vsm.180.1581951457294; Mon, 17 Feb 2020 06:57:37 -0800 (PST) X-Google-Smtp-Source: APXvYqw5sCsL6geeXPpJy5wT+uUxAlpfgffx9c1bMEZ8ut8dE5aMv2V4JBswtgW4M8cTLGvjjPI/hI5hpUOTYuawEj8= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr8502821vsm.180.1581951457040; Mon, 17 Feb 2020 06:57:37 -0800 (PST) MIME-Version: 1.0 References: <20200217164345.6207-1-taox.zhu@intel.com> In-Reply-To: From: David Marchand Date: Mon, 17 Feb 2020 15:57:25 +0100 Message-ID: To: Jerin Jacob Cc: taox.zhu@intel.com, Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , dpdk-dev , Luca Boccassi X-MC-Unique: YO7Ump5bO8uL39nN3MNRxQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Feb 17, 2020 at 2:06 PM Jerin Jacob wrote: > > On Mon, Feb 17, 2020 at 1:39 PM wrote: > > > > From: Tao Zhu > > > > Change the definition of C99 style to C90 style. > > compile log as below: > > > > otx2_mempool_ops.c: In function =E2=80=98otx2_npa_populate=E2=80=99: > > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \ > > =E2=80=98for=E2=80=99 loop initial declarations are only allowe= d in C99 mode > > for (int i =3D 0; i < OTX2_L1D_NB_SETS; i++) > > ^ > > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \ > > note: use option -std=3Dc99 or -std=3Dgnu99 to compile your cod= e > > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level: > > cc1: error: unrecognized command line option \ > > "-Wno-address-of-packed-member" [-Werror] > > cc1: all warnings being treated as errors > > make[6]: *** [otx2_mempool_ops.o] Error 1 > > make[5]: *** [octeontx2] Error 2 > > make[4]: *** [mempool] Error 2 > > > > Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architectur= e") > > > > Signed-off-by: Tao Zhu > > Just for understanding purposes, Why one need to use C90 instead of > C99? May I know, What environment, Do you see this issue? > In any case, > > Reviewed-by: Jerin Jacob We can see this in RHEL/Centos 7 and SLE 12 (thanks Luca). -- David Marchand