From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E58CA04DB; Thu, 15 Oct 2020 18:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7C4991DE35; Thu, 15 Oct 2020 18:49:32 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 6F9F91DD99 for ; Thu, 15 Oct 2020 18:49:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602780568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UaPg2sZ3NBmGlRn2RTvk3LRQk5om7hRlMstzfa9SaZE=; b=XqUAomao6Ow1Qm4humjOamLEkATBo+omI736VrmfjHB3lONBdj2GNd9XbuG6wwYNlD6w6Q iNiV3NdRL0V0FlXQyo6Yhk8Gmwu3gEubS1ISx3tPQ1z9csUhkT9CoqD8bCMAqlUjucEZAG yRbwoCg5o5g3tkMm1zvIyEMVsnXkXFs= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-439--j9j4Nd3OWOfd1Nzb6o3-g-1; Thu, 15 Oct 2020 12:49:27 -0400 X-MC-Unique: -j9j4Nd3OWOfd1Nzb6o3-g-1 Received: by mail-vk1-f197.google.com with SMTP id j185so827394vkh.6 for ; Thu, 15 Oct 2020 09:49:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UaPg2sZ3NBmGlRn2RTvk3LRQk5om7hRlMstzfa9SaZE=; b=FEg41M87wOWvyPkLM7IMfQJxULYaWx0eJeJoru9GNHWfAO8kkkQ81HdpT1oN+VGuxE KQEkH6YRKp/AUViA52IwMVHB5Dm/l/fTEZcLHgZrIb/4OuTw3g9OYazVvDGYI5sKkHO+ h+mIdqGFR0ujEmy+LH8Cu5PICDZlMcHFCoeH+hxA55h0cv1kFV3dMwTZ92NQW9O+tLiQ CHUmIqrG3QV90ePaW8k3Pi2gEXLcPynS6naXS4B3F03qENzKLfLoNs7zhAVCCWwBsY7c z1RnCkJFgHbJuZF2ss1odZn0p0FFLY+Iq9OF4gKAlvBkeCWxxizPjP9kNeD7kOPcbQxh E5iQ== X-Gm-Message-State: AOAM533Kc/DjCXPlStTs+T77dlct7iHnBDoJMDaYGIGbWaZ/Z5hS+W6i 5g8WpARb+lWk9UgGrGEwDoE2qV63SLwEm9IIA4h74rIt7VUxO9dgn657ogqbNm0La+HMzXuweml io+A2XWj7ndZnjFKrFxE= X-Received: by 2002:ab0:4287:: with SMTP id j7mr2466375uaj.53.1602780566651; Thu, 15 Oct 2020 09:49:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZPsNrnT1NME8BILEkoRsdcwQy6/BtwYGZQ8cRKsbVyjBqiZwZ/8u3lmFyu5E2Cx1aVpzZS+ygwn41h2htCe4= X-Received: by 2002:ab0:4287:: with SMTP id j7mr2466360uaj.53.1602780566331; Thu, 15 Oct 2020 09:49:26 -0700 (PDT) MIME-Version: 1.0 References: <20201015151017.8060-1-elibr@nvidia.com> In-Reply-To: <20201015151017.8060-1-elibr@nvidia.com> From: David Marchand Date: Thu, 15 Oct 2020 18:49:15 +0200 Message-ID: To: Eli Britstein Cc: dev , Thomas Monjalon , Asaf Penso Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH V2 1/1] eal: fix build with conflicting libc variable memory_order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 5:10 PM Eli Britstein wrote: > > The cited commit introduced functions with 'int memory_order' argument. > The C11 standard section 7.17.1.4 defines 'memory_order' as the > "enumerated type whose enumerators identify memory ordering constraints". > > A compilation error occurs: > error: declaration of 'memory_order' shadows a global declaration > [-Werror=shadow] > rte_atomic_thread_fence(int memory_order) > > This issue was hit when trying to compile OVS with gcc 4.8.5. This > compiler version does not provide stdatomic.h, so enum memory_order is > redefined in OVS code. > In another case, if the compiler does provide stdatomic.h header, > passing -Wsystem-headers in the CFLAGS will also cause that failure. > > Fix it by changing the argument name 'memory_order' to 'memorder'. > > Fixes: 672a15056380 ("eal: add wrapper for C11 atomic thread fence") > > Signed-off-by: Eli Britstein Please, report previous review/acks, and thread replies with original. Reviewed-by: Asaf Penso Acked-by: Thomas Monjalon Acked-by: David Marchand Reviewed-by: Honnappa Nagarahalli Applied, thanks. -- David Marchand