From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4588CA0526; Tue, 21 Jul 2020 20:49:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C236B1C01E; Tue, 21 Jul 2020 20:49:29 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id EC5701C012 for ; Tue, 21 Jul 2020 20:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595357367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x5AfssaWHqcMFIs4eAUMk04tYSGxdRL839jlb4WbDUA=; b=CbimgiRZn4z51UqeMzKwCB08Rk9guAkIYQSJwT4R72wUXpiF2QDIuXlHWXq/0JMbmeqr6Z jGHCfwX0WGScV0oyhVeJwNKGz+L8YW/a/8lO6Zv1qThFKqe9OzEaGJv7hpGynvinKtQ4zz //Purntri3NDLXy3N0UJu7OblgPVQ50= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-0ZYntXWWOSanqem71V9ppQ-1; Tue, 21 Jul 2020 14:49:25 -0400 X-MC-Unique: 0ZYntXWWOSanqem71V9ppQ-1 Received: by mail-vk1-f197.google.com with SMTP id v84so8631569vkv.8 for ; Tue, 21 Jul 2020 11:49:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=x5AfssaWHqcMFIs4eAUMk04tYSGxdRL839jlb4WbDUA=; b=eGFhaW14qbfIidkaQaCApAnEmjF7mFwvf5/l9fDUXeAjVjiSo2GB1BAhSZG4E/i9Vl YkgMZk4IVp2jx1y/ZKY6s5u40Dmmd5biQZs5TDroQbk7TU4KIvX9SapTQLV6Cx3qnfBg pd20SBQmWAcmESBZUQKFX8o5NkZfKLaTlE4GooxRHkPQVVo7PfTuKnRMu6JLtdqU5l5x FG+HTZ9U8fRE6iu1sVo7VDKfh8//1wgtiqsNB6iZRvx7W8WTyDT6Xgem1uYcN2YbqVVf 0Rp9TkpyyJS54HZ7yoVUk4sp70dGCqIcvlfebwpzHZRiAVn4fokxl48tBeD/OtSYDDYd NK0A== X-Gm-Message-State: AOAM531RnQeeQo8a/HFzR7eGuDrgBSWCUN4CS3oTZPhsZkA4Vfv808g/ 7IlA+HuzQmUl/dN9N4Un833GNYPfGHXLYvNloWH0u3bzifb4fM+fjSVkm5UxnKcAHhLJygZTwAu TFioY9Oa95gJcnWn6M24= X-Received: by 2002:ab0:316:: with SMTP id 22mr21924797uat.41.1595357365328; Tue, 21 Jul 2020 11:49:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyogoosRVXcB67NqupGgSSSqq2BLLiYKcSLzxmhCTmGJPFOW97iuV49tEfVGnhBBHVHWG3OQWs9tTkdeRpvrjc= X-Received: by 2002:ab0:316:: with SMTP id 22mr21924786uat.41.1595357365076; Tue, 21 Jul 2020 11:49:25 -0700 (PDT) MIME-Version: 1.0 References: <20200716051903.94195-1-ruifeng.wang@arm.com> <20200716154920.167185-1-ruifeng.wang@arm.com> In-Reply-To: <20200716154920.167185-1-ruifeng.wang@arm.com> From: David Marchand Date: Tue, 21 Jul 2020 20:49:13 +0200 Message-ID: To: Ruifeng Wang Cc: Bruce Richardson , Vladimir Medvedkin , dev , nd , Honnappa Nagarahalli , Phil Yang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2] lpm: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 16, 2020 at 5:49 PM Ruifeng Wang wrote: > > Coverity complains about unchecked return value of rte_rcu_qsbr_dq_enqueue. > By default, defer queue size is big enough to hold all tbl8 groups. When > enqueue fails, return error to the user to indicate system issue. > > Coverity issue: 360832 > Fixes: 8a9f8564e9f9 ("lpm: implement RCU rule reclamation") > > Signed-off-by: Ruifeng Wang Acked-by: Vladimir Medvedkin Acked-by: Bruce Richardson Applied, thanks. -- David Marchand