From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B613A0543; Mon, 13 Jun 2022 11:22:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 185D340150; Mon, 13 Jun 2022 11:22:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5CDE1400EF for ; Mon, 13 Jun 2022 11:22:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655112138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gDMTV+1TOgNj6ublAJjE0CXXEd9lPMy35f4WQMvlMWA=; b=UQlOmJMdVPhWnAm/xz8v3+u8cKoFPgWb54StYq7OerfSevNwvX2r6fxwLR0cNx+zMEeblG FIxvvdgmCQhl9NxAs/rWE+CIaUxMAwIGNYPISVFuBciuNmt1fcOFZYLpohF7j03oo8bpTk MhxDztKRo5mRebLNWm8C0ehUzvkJPBY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-854ek0pTMqW8696Fejvf_A-1; Mon, 13 Jun 2022 05:22:15 -0400 X-MC-Unique: 854ek0pTMqW8696Fejvf_A-1 Received: by mail-lj1-f199.google.com with SMTP id y9-20020a2e3209000000b002557ab0a436so523781ljy.7 for ; Mon, 13 Jun 2022 02:22:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gDMTV+1TOgNj6ublAJjE0CXXEd9lPMy35f4WQMvlMWA=; b=57lGrJYusJdtq5UOtjP0iH6g+1E/ypp43Mk8H0L/pf2qJNxibZR2q1kiPWrlm7iDUk ypIBciDQpkl7OT1b/QiGZ6pOh+3Yf+qwsPZzf+8c2Xvz3WpEOG+t/C4HRMHVZ6oVAtU9 xFzBHOjJTJB8c/mMgn68I8pRRMesctAkQk1FZeI8VBbimsGLt6pbRyjGkuCv0vACwdx1 y+3IGr5PalftL/dILcDajwm0SfKctU4RwxS91clwoziSu7cw5ScpfkAwKZUJ+f865us8 Otn3qOFZ5hg4RymrxIbJws4cY1XO3RVZECWMyvEyyb/PvvNdY3anu+KxyUsU3WRNpz21 flAg== X-Gm-Message-State: AJIora/IJvN8T4czzCD9gWGefGm+vK+LgUYDigYGjz8gDyRQ5kwaZlRK 0aKrLuEnIjr+OdDBJg6K5x21vtlEQWQy10LMGmSCV/bkSuKwkQbu/uWnzWILZwjM7CinXCb1dr2 GzBDKVb5qlolPCSgGxAE= X-Received: by 2002:a05:6512:4015:b0:479:cb6:f8da with SMTP id br21-20020a056512401500b004790cb6f8damr1686296lfb.484.1655112133724; Mon, 13 Jun 2022 02:22:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNHlXV4RbXVAZ7S82VyEkI0/0bZPf1LhTvjQUbKlaYG90poT0dq0EaHz08gKayw+sOQocVxMxTZhWMS1uyh7g= X-Received: by 2002:a05:6512:4015:b0:479:cb6:f8da with SMTP id br21-20020a056512401500b004790cb6f8damr1686285lfb.484.1655112133527; Mon, 13 Jun 2022 02:22:13 -0700 (PDT) MIME-Version: 1.0 References: <20220520145631.137962-1-bruce.richardson@intel.com> <20220610142406.580943-1-bruce.richardson@intel.com> In-Reply-To: <20220610142406.580943-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 13 Jun 2022 11:22:02 +0200 Message-ID: Subject: Re: [PATCH v3 0/2] fix uncallable unit tests (Bugzilla 1002) To: Bruce Richardson Cc: dev , Olivier Matz Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 10, 2022 at 4:24 PM Bruce Richardson wrote: > > The dump* unit tests are uncallable from our test framework because the command > validation in the unit test binary is incorrect. Rather than trying to fix this > directly in the binary, a better approach is to add command validation to the > cmdline library - which already has 99% of what we need already - and use that > from the test app. > > Patch fix not CC'ed to stable, as fix requires new function in cmdline library. Series applied, thanks Bruce. -- David Marchand