From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A12BA0C43; Tue, 19 Oct 2021 10:48:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EED5040142; Tue, 19 Oct 2021 10:48:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id DD56D4003E for ; Tue, 19 Oct 2021 10:48:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634633283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aj6oGx5BxWWGgBLMMOdC7Ufy2JqFAb07oh1q1Numev8=; b=TAyIfw43vkqJvqSII+bJsBC6EbRvhKyp2IDbES5iLUwGpl0iHsE/rb7DPshrvCC4iwTdZ1 a9BH7VkR37SIjAMPP4zaKIDfsr5lcw8jcPQFYFDlAidnza3k1mk0rsB0O+qItAvnY45F9H Xx/lgnTdG+ezgQusKltzJQSYcAI2Yzk= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-mmkagMUQOM2Phnet8jZ3gg-1; Tue, 19 Oct 2021 04:48:02 -0400 X-MC-Unique: mmkagMUQOM2Phnet8jZ3gg-1 Received: by mail-lf1-f69.google.com with SMTP id f17-20020a0565123b1100b003fda40b659aso1130800lfv.23 for ; Tue, 19 Oct 2021 01:48:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aj6oGx5BxWWGgBLMMOdC7Ufy2JqFAb07oh1q1Numev8=; b=wZsdU0AWJsY900qMYF78iGvIE3zpNxHVD5zzY5fuEJtYMGFN57SjupueUxC4Y+arz2 tDgxqu57XYc7X8eO+1QWOxwG1sW+X2QiPmqaSUFR8feQCyhwT3sJR2dfIOoWzxemqIUq LPnqKSbyxFYBKd1sa6jHQWz+k3v6/M6aIWVz2tFbRaY0pxxKeTrfoc+c/RxC0vIMR6JJ MgVOZ3/nztwzHWEOPyacD9EgpUJ8Hg6wILQzyrlNSegPwA/D7XGgr+IASMYXQDj3EjP5 DjzjtvPfrQJm9Th6eD8+8lmFQpusKOlty1hbKIwv5e3F4RT+bWCYPEnlhF1KOMymVdbf hzPg== X-Gm-Message-State: AOAM530lXi223iA8hJlm+ZsxZkmW/wkyW4DC93DWPQv3ur9mp4Shb7lQ d7hBx0qusl8d3Ipyhy6DVG7GTWlA0SC7ByCqnHv+Cicxrr2dLMDIHbKVB2Jru8uJoT/4QRVcBhk f1BDY00PmtIype99aTB4= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr4711546lfs.560.1634633280501; Tue, 19 Oct 2021 01:48:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq8xt3eYdCmc/SBHT13ETrWub5kxHxgUPalO1fUIQhVAwmIlncII9pz+x1CbWDjs6Ac5w9RZgMVjpm8cDoxbM= X-Received: by 2002:a05:6512:202a:: with SMTP id s10mr4711531lfs.560.1634633280278; Tue, 19 Oct 2021 01:48:00 -0700 (PDT) MIME-Version: 1.0 References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru> <20211018144907.1145028-4-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20211018144907.1145028-4-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Tue, 19 Oct 2021 10:47:49 +0200 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Anoob Joseph , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 3/6] mempool: add namespace to internal but still visible API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 4:49 PM Andrew Rybchenko wrote: > > Add RTE_ prefix to internal API defined in public header. > Use the prefix instead of double underscore. > Use uppercase for macros in the case of name conflict. Fwiw, I see no use out of dpdk for those helpers/macros. $ git grep-all -E '\<(__MEMPOOL_STAT_ADD|__mempool_contig_blocks_check_cookies|__mempool_check_cookies|__mempool_generic_get|__mempool_generic_put|__mempool_get_trailer|__mempool_get_header)\>' Not a review, just something that caught my eye below: [snip] > @@ -1384,7 +1385,7 @@ rte_mempool_put_bulk(struct rte_mempool *mp, void * const *obj_table, > struct rte_mempool_cache *cache; > cache = rte_mempool_default_cache(mp, rte_lcore_id()); > rte_mempool_trace_put_bulk(mp, obj_table, n, cache); > - rte_mempool_generic_put(mp, obj_table, n, cache); > + rte_mempool_do_generic_put(mp, obj_table, n, cache); Is this change expected? > } > > /** [snip] > @@ -1541,7 +1542,7 @@ rte_mempool_get_bulk(struct rte_mempool *mp, void **obj_table, unsigned int n) > struct rte_mempool_cache *cache; > cache = rte_mempool_default_cache(mp, rte_lcore_id()); > rte_mempool_trace_get_bulk(mp, obj_table, n, cache); > - return rte_mempool_generic_get(mp, obj_table, n, cache); > + return rte_mempool_do_generic_get(mp, obj_table, n, cache); > } > > /** Idem. -- David Marchand